From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/icl: Factor out combo PHY lane
 power setup helper
Date: Thu, 25 Apr 2019 12:17:44 +0300
Message-ID: <20190425091744.GA29764@ideak-desk.fi.intel.com>
References: <20190424152632.8301-1-imre.deak@intel.com>
 <87ftq6trkj.fsf@intel.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C90E68914F
 for <intel-gfx@lists.freedesktop.org>; Thu, 25 Apr 2019 09:17:52 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <87ftq6trkj.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBBcHIgMjUsIDIwMTkgYXQgMTE6MzA6MzZBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gT24gV2VkLCAyNCBBcHIgMjAxOSwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t
PiB3cm90ZToKPiA+IEZhY3RvciBvdXQgdGhlIGNvbWJvIFBIWSBsYW5lIHBvd2VyIGNvbmZpZ3Vy
YXRpb24gY29kZSB0byBhIHNlcGFyYXRlCj4gPiBoZWxwZXI7IGl0IHdpbGwgYmUgYWxzbyBuZWVk
ZWQgYnkgdGhlIG5leHQgcGF0Y2ggYWRkaW5nIHRoZSBzYW1lCj4gPiBjb25maWd1cmF0aW9uIGZv
ciBEREkgcG9ydHMuCj4gPgo+ID4gV2hpbGUgYXQgaXQgYWxzbyBhZGQgc3VwcG9ydCB0byBoYW5k
bGUgbGFuZSByZXZlcnNhbCB3aGljaCB3YXNuJ3QKPiA+IG5lZWRlZCBmb3IgRFNJLCBidXQgd2ls
bCBiZSBuZWVkZWQgYnkgRERJIHBvcnRzLgo+ID4KPiA+IEFsc28sIHJlbW92ZSB0aGUgbWFjcm9z
IGZvciB0aGUgcG93ZXIgZG93biBmbGFncywgdGhleSBhcmVuJ3QKPiA+IG5lZWRlZCBhbnkgbW9y
ZSBzaW5jZSB3ZSBub3cgY2FsY3VsYXRlIHRoZSBwb3dlciBkb3duIG1hc2suIE1hbnkgb2YKPiA+
IHRob3NlIG1hY3JvIHZhbHVlcyAobW9zdGx5IHRoZSBvbmVzIGZvciB0aGUgY3VycmVudGx5IHVu
dXNlZCByZXZlcnNlZAo+ID4gbGFuZSBjb25maWdzKSB3ZXJlIGFjdHVhbGx5IHVuZGVmaW5lZCBp
biB0aGUgc3BlYyBhbmQgZGlkbid0IG1ha2UgbXVjaAo+ID4gc2Vuc2UgZWl0aGVyLgo+IAo+IE9u
bHkgUFdSX0RPV05fTE5fMSBpcyB1bmRlZmluZWQgaW4gdGhlIHNwZWMuCgpBcmcsIHllcyBJIG1p
c3NlZCB0aGUgRERJL0RTSSBkaWZmZXJlbmNlLiBOb3Qgc3VyZSBob3cgc2luY2UgaXQncyBxdWl0
ZQpjbG9zZSB0b2dldGhlciBpbiB0aGUgc3BlYyBhbmQgdGhlIGV4aXN0aW5nIDIgYW5kIDMgbGFu
ZSBEU0kgY2FzZXMgaW4gdGhlCmNvZGUgc2hvdWxkJ3ZlIG1hZGUgaXQgY2xlYXIgdGhhdCB0aGVy
ZSBpcyBhIGRpZmZlcmVuY2UuCgo+IAo+ID4KPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1
bGFAaW50ZWwuY29tPgo+ID4gQ2M6IE1hZGhhdiBDaGF1aGFuIDxtYWRoYXYuY2hhdWhhbkBpbnRl
bC5jb20+Cj4gPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j
b20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4g
PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICB8ICAzICsr
Kwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICAgIHwgIDkgLS0tLS0t
LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jICAgICAgICAgfCAyNiArKyst
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nv
bWJvX3BoeS5jIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDQgZmls
ZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBpbmRleCBkYzc0ZDMzYzIwYWEuLjEyMDdlZjA4MGFhZSAx
MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+IEBAIC0zNTE1LDYgKzM1MTUsOSBA
QCB2b2lkIGljbF9jb21ib19waHlzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2KTsKPiA+ICB2b2lkIGljbF9jb21ib19waHlzX3VuaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYpOwo+ID4gIHZvaWQgY25sX2NvbWJvX3BoeXNfaW5pdChzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ID4gIHZvaWQgY25sX2NvbWJvX3BoeXNfdW5pbml0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gPiArdm9pZCBpY2xfY29tYm9f
cGh5X3Bvd2VyX3VwX2xhbmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+
ICsJCQkJICBlbnVtIHBvcnQgcG9ydCwgaW50IGxhbmVfY291bnQsCj4gPiArCQkJCSAgYm9vbCBs
YW5lX3JldmVyc2FsKTsKPiA+ICAKPiA+ICBpbnQgaW50ZWxfZ3B1X2ZyZXEoc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiA+ICBpbnQgaW50ZWxfZnJlcV9vcGNv
ZGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiA+IGRpZmYg
LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9yZWcuaAo+ID4gaW5kZXggYjc0ODI0ZjBiNWIxLi4yOWYxNmJjNDBiMGEgMTAw
NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBAQCAtMTgwNywxNSArMTgwNyw2IEBA
IGVudW0gaTkxNV9wb3dlcl93ZWxsX2lkIHsKPiA+ICAjZGVmaW5lICBQR19TRVFfREVMQVlfT1ZF
UlJJREVfTUFTSwkoMyA8PCAyNSkKPiA+ICAjZGVmaW5lICBQR19TRVFfREVMQVlfT1ZFUlJJREVf
U0hJRlQJMjUKPiA+ICAjZGVmaW5lICBQR19TRVFfREVMQVlfT1ZFUlJJREVfRU5BQkxFCSgxIDw8
IDI0KQo+ID4gLSNkZWZpbmUgIFBXUl9VUF9BTExfTEFORVMJCSgweDAgPDwgNCkKPiA+IC0jZGVm
aW5lICBQV1JfRE9XTl9MTl8zXzJfMQkJKDB4ZSA8PCA0KQo+ID4gLSNkZWZpbmUgIFBXUl9ET1dO
X0xOXzNfMgkJKDB4YyA8PCA0KQo+ID4gLSNkZWZpbmUgIFBXUl9ET1dOX0xOXzMJCQkoMHg4IDw8
IDQpCj4gPiAtI2RlZmluZSAgUFdSX0RPV05fTE5fMl8xXzAJCSgweDcgPDwgNCkKPiA+IC0jZGVm
aW5lICBQV1JfRE9XTl9MTl8xXzAJCSgweDMgPDwgNCkKPiA+IC0jZGVmaW5lICBQV1JfRE9XTl9M
Tl8xCQkJKDB4MiA8PCA0KQo+ID4gLSNkZWZpbmUgIFBXUl9ET1dOX0xOXzNfMQkJKDB4YSA8PCA0
KQo+ID4gLSNkZWZpbmUgIFBXUl9ET1dOX0xOXzNfMV8wCQkoMHhiIDw8IDQpCj4gPiAgI2RlZmlu
ZSAgUFdSX0RPV05fTE5fTUFTSwkJKDB4ZiA8PCA0KQo+ID4gICNkZWZpbmUgIFBXUl9ET1dOX0xO
X1NISUZUCQk0Cj4gPiAgCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNs
X2RzaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jCj4gPiBpbmRleCA5ZDk2MmVh
MWU2MzUuLjg4OTU5NTE3YjY2OCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ljbF9kc2kuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jCj4gPiBA
QCAtMzYzLDMwICszNjMsMTAgQEAgc3RhdGljIHZvaWQgZ2VuMTFfZHNpX3Bvd2VyX3VwX2xhbmVz
KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiA+ICAJc3RydWN0
IGludGVsX2RzaSAqaW50ZWxfZHNpID0gZW5jX3RvX2ludGVsX2RzaSgmZW5jb2Rlci0+YmFzZSk7
Cj4gPiAgCWVudW0gcG9ydCBwb3J0Owo+ID4gLQl1MzIgdG1wOwo+ID4gLQl1MzIgbGFuZV9tYXNr
Owo+ID4gIAo+ID4gLQlzd2l0Y2ggKGludGVsX2RzaS0+bGFuZV9jb3VudCkgewo+ID4gLQljYXNl
IDE6Cj4gPiAtCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zXzFfMDsKPiA+IC0JCWJyZWFrOwo+
ID4gLQljYXNlIDI6Cj4gPiAtCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zXzE7Cj4gPiAtCQli
cmVhazsKPiA+IC0JY2FzZSAzOgo+ID4gLQkJbGFuZV9tYXNrID0gUFdSX0RPV05fTE5fMzsKPiA+
IC0JCWJyZWFrOwo+ID4gLQljYXNlIDQ6Cj4gPiAtCWRlZmF1bHQ6Cj4gPiAtCQlsYW5lX21hc2sg
PSBQV1JfVVBfQUxMX0xBTkVTOwo+ID4gLQkJYnJlYWs7Cj4gPiAtCX0KPiA+IC0KPiA+IC0JZm9y
X2VhY2hfZHNpX3BvcnQocG9ydCwgaW50ZWxfZHNpLT5wb3J0cykgewo+ID4gLQkJdG1wID0gSTkx
NV9SRUFEKElDTF9QT1JUX0NMX0RXMTAocG9ydCkpOwo+ID4gLQkJdG1wICY9IH5QV1JfRE9XTl9M
Tl9NQVNLOwo+ID4gLQkJSTkxNV9XUklURShJQ0xfUE9SVF9DTF9EVzEwKHBvcnQpLCB0bXAgfCBs
YW5lX21hc2spOwo+ID4gLQl9Cj4gCj4gSSBsb29rIGF0IHRoYXQgYW5kIGl0IHRha2VzIG1lIG1h
eWJlIDEwIHNlY29uZHMgdG8gZmlndXJlIG91dCB3aGF0J3MKPiBnb2luZyBvbiwgYXNzdW1pbmcg
dGhlIFBXUl9ET1dOX0xOXyogbWFjcm9zIGFyZSByaWdodC4KPiAKPiA+ICsJZm9yX2VhY2hfZHNp
X3BvcnQocG9ydCwgaW50ZWxfZHNpLT5wb3J0cykKPiA+ICsJCWljbF9jb21ib19waHlfcG93ZXJf
dXBfbGFuZXMoZGV2X3ByaXYsIHBvcnQsCj4gPiArCQkJCQkgICAgIGludGVsX2RzaS0+bGFuZV9j
b3VudCwgZmFsc2UpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBnZW4xMV9kc2lfY29u
ZmlnX3BoeV9sYW5lc19zZXF1ZW5jZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiA+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19waHkuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbWJvX3BoeS5jCj4gPiBpbmRleCAyYmY0MzU5ZDdl
NDEuLmUzZWQ1ODRlY2E0NyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2NvbWJvX3BoeS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21i
b19waHkuYwo+ID4gQEAgLTIwMyw2ICsyMDMsMzcgQEAgc3RhdGljIGJvb2wgaWNsX2NvbWJvX3Bo
eV92ZXJpZnlfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAly
ZXR1cm4gcmV0Owo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgdWludDhfdCByZXZlcnNlX25pYmJs
ZV9iaXRzKHVpbnQ4X3QgdmFsKQo+ID4gK3sKPiA+ICsjZGVmaW5lIE1PVkJJVCh2LCBmcm9tLCB0
bykgKCEhKCh2KSAmIEJJVChmcm9tKSkgPDwgKHRvKSkKPiA+ICsjZGVmaW5lIFNXUEJJVCh2LCBi
MSwgYjIpIChNT1ZCSVQoKHYpLCAoYjEpLCAoYjIpKSB8IE1PVkJJVCgodiksIChiMiksIChiMSkp
KQo+ID4gKwo+ID4gKwlyZXR1cm4gU1dQQklUKHZhbCwgMCwgMykgfCBTV1BCSVQodmFsLCAxLCAy
KTsKPiA+ICsjdW5kZWYgU1dQQklUCj4gPiArI3VuZGVmIE1PVkJJVAo+ID4gK30KPiA+ICsKPiA+
ICt2b2lkIGljbF9jb21ib19waHlfcG93ZXJfdXBfbGFuZXMoc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2LAo+ID4gKwkJCQkgIGVudW0gcG9ydCBwb3J0LCBpbnQgbGFuZV9jb3VudCwK
PiA+ICsJCQkJICBib29sIGxhbmVfcmV2ZXJzYWwpCj4gPiArewo+ID4gKwl1MzIgcHdyX2Rvd25f
bWFzazsKPiA+ICsJdTMyIHZhbDsKPiA+ICsKPiA+ICsJV0FSTl9PTigodTMyKWxhbmVfY291bnQg
PiA0KTsKPiA+ICsKPiA+ICsJcHdyX2Rvd25fbWFzayA9IEJJVChsYW5lX2NvdW50KSAtIDE7Cj4g
PiArCWlmIChsYW5lX3JldmVyc2FsKQo+ID4gKwkJcHdyX2Rvd25fbWFzayA9IHJldmVyc2Vfbmli
YmxlX2JpdHMocHdyX2Rvd25fbWFzayk7Cj4gPiArCj4gPiArCXB3cl9kb3duX21hc2sgPSB+cHdy
X2Rvd25fbWFzayAmIDB4ZjsKPiA+ICsKPiA+ICsJdmFsID0gSTkxNV9SRUFEKElDTF9QT1JUX0NM
X0RXMTAocG9ydCkpOwo+ID4gKwl2YWwgJj0gflBXUl9ET1dOX0xOX01BU0s7Cj4gPiArCUk5MTVf
V1JJVEUoSUNMX1BPUlRfQ0xfRFcxMChwb3J0KSwKPiA+ICsJCSAgIHZhbCB8IChwd3JfZG93bl9t
YXNrIDw8IFBXUl9ET1dOX0xOX1NISUZUKSk7Cj4gPiArfQo+IAo+IE1heWJlIEknbSBzbG93IHRv
ZGF5LCBidXQgaXQgdG9vayBtZSAxNS0zMCBtaW51dGVzIHRvIGZpZ3VyZSBvdXQgdGhhdAo+IHRo
aXMgc2NyZXdzIHVwIHRoZSAxIGFuZCAyIGxhbmUgRFNJIHZhbHVlcy4KPiAKPiBUaGUgdW5zaGlm
dGVkIHZhbHVlIGNoYW5nZXM6Cj4gCj4gRFNJIHgxOiAxMDExYiAtPiAxMTEwYgo+IERTSSB4Mjog
MTAxMGIgLT4gMTEwMGIKPiAKPiBEU0kgdXNlcyBkaWZmZXJlbnQgdmFsdWVzIGZyb20gRERJLgoK
WWVwLCBzb3JyeSBmb3IgdGhhdC4KCj4gVGhlcmUgKmlzKiB2YWx1ZSBpbiBrZWVwaW5nIGl0IHNp
bXBsZSBhbmQgbWVjaGFuaWMgaW5zdGVhZCBvZiB0cnlpbmcgdG8KPiBmb3JjZSBpdCBpbnRvIGEg
Zm9ybXVsYS4KClllcywgYWdyZWVkLCBrZWVwaW5nIHRoZSBjdXJyZW50IG1hY3JvcyBhbmQgc2Vs
ZWN0aW5nIHRoZSBjb3JyZWN0IG9uZQpiYXNlZCBvbiBkc2kvZGRpIHNlZW1zIHRvIGJlIGNsZWFy
ZXIuCgo+IAo+IAo+IEJSLAo+IEphbmkuCj4gCj4gCj4gPiArCj4gPiAgdm9pZCBpY2xfY29tYm9f
cGh5c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICB7Cj4gPiAg
CWVudW0gcG9ydCBwb3J0Owo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj
ZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50
ZWwtZ2Z4