Re: ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/icl: Factor out combo PHY lane power setup helper

Jani Nikula
2019-05-03T06:44:06Z

On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
> On Thu, May 02, 2019 at 05:45:45PM +0300, Jani Nikula wrote:
>> On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
>> > Thanks for the review, series pushed to -dinq, with the s/icl_/intel_/
>> > change and adding the headers to intel_combo_phy.h required by the
>> > recent header refactoring.
>>
>> Hey, I expected a resend. Please always resend the the rebased patches
>> for CI, and only push patches that have gone through CI!
>
> Ok, will do so.
>
> I assume though that trivial changes only in the commit message and/or
> code comments - if the reviewer has agreed to them - don't need a
> resend. That would only result in in an unecessary run through CI with
> unchanged code.

Yup.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center