From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH v2 1/2] drm/i915/icl: Factor out combo PHY
 lane power setup helper
Date: Tue, 30 Apr 2019 15:48:27 +0300
Message-ID: <20190430124827.GA25932@ideak-desk.fi.intel.com>
References: <20190425185253.3197-1-imre.deak@intel.com>
 <87y33rpsrz.fsf@intel.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4E59B89152
 for <intel-gfx@lists.freedesktop.org>; Tue, 30 Apr 2019 12:48:40 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <87y33rpsrz.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBBcHIgMzAsIDIwMTkgYXQgMDM6NDQ6MDBQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gT24gVGh1LCAyNSBBcHIgMjAxOSwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t
PiB3cm90ZToKPiA+IEZhY3RvciBvdXQgdGhlIGNvbWJvIFBIWSBsYW5lIHBvd2VyIGNvbmZpZ3Vy
YXRpb24gY29kZSB0byBhIHNlcGFyYXRlCj4gPiBoZWxwZXI7IGl0IHdpbGwgYmUgYWxzbyBuZWVk
ZWQgYnkgdGhlIG5leHQgcGF0Y2ggYWRkaW5nIHRoZSBzYW1lCj4gPiBjb25maWd1cmF0aW9uIGZv
ciBEREkgcG9ydHMuCj4gPgo+ID4gQWRkIHN1cHBvcnQgZm9yIERESSBwb3J0cyBhbmQgbGFuZSBy
ZXZlcnNhbCBhcyBwcmVwYXJhdGlvbiBmb3IgdGhlIG5leHQKPiA+IHBhdGNoLgo+ID4KPiA+IFRo
ZSBQV1JfRE9XTl9MTl8xIHZhbHVlIGlzIHVuc3BlY2lmaWVkIGluIHRoZSBCU3BlYyByZWdpc3Rl
ciBkZXNjcmlwdGlvbgo+ID4gc28gcmVtb3ZlIGl0Lgo+ID4KPiA+IHYyOgo+ID4gLSBGaXggdXAg
dGhlIHdyb25nIGFzc3VtcHRpb24gdGhhdCB0aGUgZW5jb2RpbmdzIGFyZSB0aGUgc2FtZSBmb3Ig
RERJCj4gPiAgIGFuZCBEU0kgcG9ydHMuIChKYW5pKQo+ID4KPiAKPiBCb3RoIHBhdGNoZXMgbG9v
ayBnb29kIHRvIG1lLCBidXQgSSdtIGFmcmFpZCBwYXRjaCAxIGNvbmZsaWN0cyB3aXRoIHRoZQo+
IGhlYWRlciByZWZhY3RvcmluZyBJIHB1c2hlZCBlYXJsaWVyLCBhcyB3ZWxsIGFzIHRoZSBmdW5j
dGlvbiBuYW1lCj4gY2hhbmdlcyBpbiBbMV0uIEkgdGhpbmsgSSdkIGxpa2UgdGhlIGZ1bmN0aW9u
IGhlcmUgdG8gYmUgcmVuYW1lZAo+IGFjY29yZGluZ2x5Lgo+IAo+IE90aGVyIHRoYW4gdGhhdCwg
Zm9yIGJvdGgsCj4gCj4gUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRl
bC5jb20+CgpUaGFua3MuIFllcywgdGhhdCBuYW1pbmcgc2NoZW1lIG1ha2VzIHNlbnNlLCB3aWxs
IGRvIHRoZSByZW5hbWUgYmVmb3JlCnB1c2hpbmcgdGhlIHBhdGNoZXMuCgo+IAo+IFsxXSBodHRw
Oi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8yMDE5MDQzMDEyNDEyOC4y
MzYwNi0xLWphbmkubmlrdWxhQGludGVsLmNvbQo+IAo+IAo+ID4gQ2M6IEphbmkgTmlrdWxhIDxq
YW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiBDYzogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1
aGFuQGludGVsLmNvbT4KPiA+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4
LmludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVs
LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAg
IHwgIDMgKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgICB8ICAx
IC0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMgICAgICAgICB8IDI2ICsrLS0t
LS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29tYm9fcGh5LmMg
fCA1MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiAgNCBmaWxlcyBjaGFu
Z2VkLCA1OCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZHJ2LmgKPiA+IGluZGV4IGRjNzRkMzNjMjBhYS4uODdmMjRkOTJlMzU1IDEwMDY0NAo+
ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gQEAgLTM1MTUsNiArMzUxNSw5IEBAIHZvaWQg
aWNsX2NvbWJvX3BoeXNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+
ID4gIHZvaWQgaWNsX2NvbWJvX3BoeXNfdW5pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdik7Cj4gPiAgdm9pZCBjbmxfY29tYm9fcGh5c19pbml0KHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdik7Cj4gPiAgdm9pZCBjbmxfY29tYm9fcGh5c191bmluaXQoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiA+ICt2b2lkIGljbF9jb21ib19waHlfcG93
ZXJfdXBfbGFuZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gKwkJCQkg
IGVudW0gcG9ydCBwb3J0LCBib29sIGlzX2RzaSwKPiA+ICsJCQkJICBpbnQgbGFuZV9jb3VudCwg
Ym9vbCBsYW5lX3JldmVyc2FsKTsKPiA+ICAKPiA+ICBpbnQgaW50ZWxfZ3B1X2ZyZXEoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiA+ICBpbnQgaW50ZWxfZnJl
cV9vcGNvZGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiA+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gaW5kZXggYjc0ODI0ZjBiNWIxLi5lMzMyYjlmNjlh
NGEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBAQCAtMTgxMyw3ICsxODEz
LDYgQEAgZW51bSBpOTE1X3Bvd2VyX3dlbGxfaWQgewo+ID4gICNkZWZpbmUgIFBXUl9ET1dOX0xO
XzMJCQkoMHg4IDw8IDQpCj4gPiAgI2RlZmluZSAgUFdSX0RPV05fTE5fMl8xXzAJCSgweDcgPDwg
NCkKPiA+ICAjZGVmaW5lICBQV1JfRE9XTl9MTl8xXzAJCSgweDMgPDwgNCkKPiA+IC0jZGVmaW5l
ICBQV1JfRE9XTl9MTl8xCQkJKDB4MiA8PCA0KQo+ID4gICNkZWZpbmUgIFBXUl9ET1dOX0xOXzNf
MQkJKDB4YSA8PCA0KQo+ID4gICNkZWZpbmUgIFBXUl9ET1dOX0xOXzNfMV8wCQkoMHhiIDw8IDQp
Cj4gPiAgI2RlZmluZSAgUFdSX0RPV05fTE5fTUFTSwkJKDB4ZiA8PCA0KQo+ID4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ljbF9kc2kuYwo+ID4gaW5kZXggOWQ5NjJlYTFlNjM1Li5mMjExM2QzNzk4YjAgMTAwNjQ0Cj4g
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMKPiA+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+ID4gQEAgLTM2MywzMCArMzYzLDEwIEBAIHN0YXRpYyB2
b2lkIGdlbjExX2RzaV9wb3dlcl91cF9sYW5lcyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl
cikKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNv
ZGVyLT5iYXNlLmRldik7Cj4gPiAgCXN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSA9IGVuY190
b19pbnRlbF9kc2koJmVuY29kZXItPmJhc2UpOwo+ID4gIAllbnVtIHBvcnQgcG9ydDsKPiA+IC0J
dTMyIHRtcDsKPiA+IC0JdTMyIGxhbmVfbWFzazsKPiA+ICAKPiA+IC0Jc3dpdGNoIChpbnRlbF9k
c2ktPmxhbmVfY291bnQpIHsKPiA+IC0JY2FzZSAxOgo+ID4gLQkJbGFuZV9tYXNrID0gUFdSX0RP
V05fTE5fM18xXzA7Cj4gPiAtCQlicmVhazsKPiA+IC0JY2FzZSAyOgo+ID4gLQkJbGFuZV9tYXNr
ID0gUFdSX0RPV05fTE5fM18xOwo+ID4gLQkJYnJlYWs7Cj4gPiAtCWNhc2UgMzoKPiA+IC0JCWxh
bmVfbWFzayA9IFBXUl9ET1dOX0xOXzM7Cj4gPiAtCQlicmVhazsKPiA+IC0JY2FzZSA0Ogo+ID4g
LQlkZWZhdWx0Ogo+ID4gLQkJbGFuZV9tYXNrID0gUFdSX1VQX0FMTF9MQU5FUzsKPiA+IC0JCWJy
ZWFrOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCWZvcl9lYWNoX2RzaV9wb3J0KHBvcnQsIGludGVsX2Rz
aS0+cG9ydHMpIHsKPiA+IC0JCXRtcCA9IEk5MTVfUkVBRChJQ0xfUE9SVF9DTF9EVzEwKHBvcnQp
KTsKPiA+IC0JCXRtcCAmPSB+UFdSX0RPV05fTE5fTUFTSzsKPiA+IC0JCUk5MTVfV1JJVEUoSUNM
X1BPUlRfQ0xfRFcxMChwb3J0KSwgdG1wIHwgbGFuZV9tYXNrKTsKPiA+IC0JfQo+ID4gKwlmb3Jf
ZWFjaF9kc2lfcG9ydChwb3J0LCBpbnRlbF9kc2ktPnBvcnRzKQo+ID4gKwkJaWNsX2NvbWJvX3Bo
eV9wb3dlcl91cF9sYW5lcyhkZXZfcHJpdiwgcG9ydCwgdHJ1ZSwKPiA+ICsJCQkJCSAgICAgaW50
ZWxfZHNpLT5sYW5lX2NvdW50LCBmYWxzZSk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lk
IGdlbjExX2RzaV9jb25maWdfcGh5X2xhbmVzX3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9lbmNvZGVy
ICplbmNvZGVyKQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nv
bWJvX3BoeS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29tYm9fcGh5LmMKPiA+IGlu
ZGV4IDJiZjQzNTlkN2U0MS4uNTQ3ODgwODg4NmYxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfY29tYm9fcGh5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2NvbWJvX3BoeS5jCj4gPiBAQCAtMjAzLDYgKzIwMyw1OCBAQCBzdGF0aWMgYm9v
bCBpY2xfY29tYm9fcGh5X3ZlcmlmeV9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYsCj4gPiAgCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gIAo+ID4gK3ZvaWQgaWNsX2NvbWJv
X3BoeV9wb3dlcl91cF9sYW5lcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
PiArCQkJCSAgZW51bSBwb3J0IHBvcnQsIGJvb2wgaXNfZHNpLAo+ID4gKwkJCQkgIGludCBsYW5l
X2NvdW50LCBib29sIGxhbmVfcmV2ZXJzYWwpCj4gPiArewo+ID4gKwl1OCBsYW5lX21hc2s7Cj4g
PiArCXUzMiB2YWw7Cj4gPiArCj4gPiArCWlmIChpc19kc2kpIHsKPiA+ICsJCVdBUk5fT04obGFu
ZV9yZXZlcnNhbCk7Cj4gPiArCj4gPiArCQlzd2l0Y2ggKGxhbmVfY291bnQpIHsKPiA+ICsJCWNh
c2UgMToKPiA+ICsJCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zXzFfMDsKPiA+ICsJCQlicmVh
azsKPiA+ICsJCWNhc2UgMjoKPiA+ICsJCQlsYW5lX21hc2sgPSBQV1JfRE9XTl9MTl8zXzE7Cj4g
PiArCQkJYnJlYWs7Cj4gPiArCQljYXNlIDM6Cj4gPiArCQkJbGFuZV9tYXNrID0gUFdSX0RPV05f
TE5fMzsKPiA+ICsJCQlicmVhazsKPiA+ICsJCWRlZmF1bHQ6Cj4gPiArCQkJTUlTU0lOR19DQVNF
KGxhbmVfY291bnQpOwo+ID4gKwkJCS8qIGZhbGwtdGhyb3VnaCAqLwo+ID4gKwkJY2FzZSA0Ogo+
ID4gKwkJCWxhbmVfbWFzayA9IFBXUl9VUF9BTExfTEFORVM7Cj4gPiArCQkJYnJlYWs7Cj4gPiAr
CQl9Cj4gPiArCX0gZWxzZSB7Cj4gPiArCQlzd2l0Y2ggKGxhbmVfY291bnQpIHsKPiA+ICsJCWNh
c2UgMToKPiA+ICsJCQlsYW5lX21hc2sgPSBsYW5lX3JldmVyc2FsID8gUFdSX0RPV05fTE5fMl8x
XzAgOgo+ID4gKwkJCQkJCSAgICBQV1JfRE9XTl9MTl8zXzJfMTsKPiA+ICsJCQlicmVhazsKPiA+
ICsJCWNhc2UgMjoKPiA+ICsJCQlsYW5lX21hc2sgPSBsYW5lX3JldmVyc2FsID8gUFdSX0RPV05f
TE5fMV8wIDoKPiA+ICsJCQkJCQkgICAgUFdSX0RPV05fTE5fM18yOwo+ID4gKwkJCWJyZWFrOwo+
ID4gKwkJZGVmYXVsdDoKPiA+ICsJCQlNSVNTSU5HX0NBU0UobGFuZV9jb3VudCk7Cj4gPiArCQkJ
LyogZmFsbC10aHJvdWdoICovCj4gPiArCQljYXNlIDQ6Cj4gPiArCQkJbGFuZV9tYXNrID0gUFdS
X1VQX0FMTF9MQU5FUzsKPiA+ICsJCQlicmVhazsKPiA+ICsJCX0KPiA+ICsJfQo+ID4gKwo+ID4g
Kwl2YWwgPSBJOTE1X1JFQUQoSUNMX1BPUlRfQ0xfRFcxMChwb3J0KSk7Cj4gPiArCXZhbCAmPSB+
UFdSX0RPV05fTE5fTUFTSzsKPiA+ICsJdmFsIHw9IGxhbmVfbWFzayA8PCBQV1JfRE9XTl9MTl9T
SElGVDsKPiA+ICsJSTkxNV9XUklURShJQ0xfUE9SVF9DTF9EVzEwKHBvcnQpLCB2YWwpOwo+ID4g
K30KPiA+ICsKPiA+ICB2b2lkIGljbF9jb21ib19waHlzX2luaXQoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJZW51bSBwb3J0IHBvcnQ7Cj4gCj4gLS0gCj4g
SmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=