From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 08/11] drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse() Date: Thu, 9 May 2019 18:50:42 +0300 Message-ID: <20190509155042.GG24299@intel.com> References: <20190509061954.10379-1-imre.deak@intel.com> <20190509061954.10379-9-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E90089BB0 for ; Thu, 9 May 2019 15:50:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190509061954.10379-9-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDksIDIwMTkgYXQgMDk6MTk6NTFBTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFRoZSBwb3dlciBnZXQvcHV0IHdhcyBhZGRlZCBpbgo+IAo+IGNvbW1pdCAxYzc2N2IzMzli MzkzOGIxOTA3NmZmZGM5ZDcwYWExZTQyMzVhNDViCj4gQXV0aG9yOiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gRGF0ZTogICBNb24gQXVnIDE4IDE0OjQyOjQyIDIwMTQgKzAzMDAK PiAKPiAgICAgZHJtL2k5MTU6IHRha2UgZGlzcGxheSBwb3J0IHBvd2VyIGRvbWFpbiBpbiBEUCBI UEQgaGFuZGxlCj4gCj4gdG8gYWNjb3VudCBmb3IgdGhlIEhXIGFjY2VzcyBpbiBpYnhfZGlnaXRh bF9wb3J0X2Nvbm5lY3RlZCgpLiBUaGlzCj4gbGF0dGVyIGNhbGwgd2FzIGluIHR1cm4gcmVtb3Zl ZCBpbgo+IAo+IGNvbW1pdCA3ZDIzZTNjMzdiYjNmYzY5NTJkYzg0MDA3ZWU2MGNiNTMzZmQyZDVj Cj4gQXV0aG9yOiBTaHViaGFuZ2kgU2hyaXZhc3RhdmEgPHNodWJoYW5naS5zaHJpdmFzdGF2YUBp bnRlbC5jb20+Cj4gRGF0ZTogICBXZWQgTWFyIDMwIDE4OjA1OjIzIDIwMTYgKzA1MzAKPiAKPiAg ICAgZHJtL2k5MTU6IENsZWFuaW5nIHVwIGludGVsX2RwX2hwZF9wdWxzZQo+IAo+IGFmdGVyIHdo aWNoIHdlIGRpZG4ndCBhY3R1YWxseSBuZWVkIHRoZSBwb3dlciByZWZlcmVuY2UuCj4gCj4gT25l IHdheSB3ZSBhcmUgYWNjZXNzaW5nIHRoZSBIVyBkdXJpbmcgSFBEIHB1bHNlIGhhbmRsaW5nIGlz IHZpYSBEUCBBVVgKPiB0cmFuc2ZlcnMsIGJ1dCB0aGUgdHJhbnNmZXIgZnVuY3Rpb24gdGFrZXMg aXRzIG93biByZWZlcmVuY2UsIHNvIGRvZXNuJ3QKPiBuZWVkIHRoZSByZWZlcmVuY2UgaW4gaW50 ZWxfZHBfaHBkX3B1bHNlKCkuCj4gCj4gVGhlIG90aGVyIHNwb3QgaXMgaW4gdGhlIFBTUiBjb2Rl IGRvaW5nIHJlZ2lzdGVyIGFjY2VzcywgZm9yIHRoYXQgd2UgY2FuCj4gdXNlIHRoZSBESVNQTEFZ X0NPUkUgcG93ZXIgZG9tYWluIGluIGEgc2ltaWxhciB3YXkgZG9uZSBpbiB0aGUgcHJldmlvdXMK PiBwYXRjaC4KCkkgZG9uJ3QgdGhpbmsgdGhlIFBTUiBjb2RlIHNob3VsZCB0b3VjaCB0aGUgaGFy ZHdhcmUgdW5sZXNzIHRoZSBjcnRjIGlzCmFjdGl2ZS4gU28gbm90IHN1cmUgaXQgcmVhbGx5IG5l ZWRzIGFueXRoaW5nLgoKPiAKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4K PiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gU2ln bmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8IDIwICsrKystLS0tLS0tLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgIDYgKysrKysrCj4gIDIgZmlsZXMg Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4gaW5kZXggMjRjY2ExMmE5YTNlLi5kZTg4MWJmZWEwMTEgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtNjMwOCw5ICs2MzA4LDYgQEAgZW51bSBpcnFyZXR1 cm4KPiAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVs X2RpZ19wb3J0LCBib29sIGxvbmdfaHBkKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwID0gJmludGVsX2RpZ19wb3J0LT5kcDsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+IC0JZW51bSBpcnFyZXR1cm4gcmV0ID0g SVJRX05PTkU7Cj4gLQlpbnRlbF93YWtlcmVmX3Qgd2FrZXJlZjsKPiAgCj4gIAlpZiAobG9uZ19o cGQgJiYgaW50ZWxfZGlnX3BvcnQtPmJhc2UudHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQKSB7Cj4g IAkJLyoKPiBAQCAtNjMzMyw5ICs2MzMwLDYgQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBp bnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LCBib29sIGxvbmdfaHBkKQo+ICAJCXJl dHVybiBJUlFfTk9ORTsKPiAgCX0KPiAgCj4gLQl3YWtlcmVmID0gaW50ZWxfZGlzcGxheV9wb3dl cl9nZXQoZGV2X3ByaXYsCj4gLQkJCQkJICBpbnRlbF9hdXhfcG93ZXJfZG9tYWluKGludGVsX2Rp Z19wb3J0KSk7Cj4gLQo+ICAJaWYgKGludGVsX2RwLT5pc19tc3QpIHsKPiAgCQlpZiAoaW50ZWxf ZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkgPT0gLUVJTlZBTCkgewo+ICAJCQkvKgo+IEBA IC02MzQ3LDcgKzYzNDEsOCBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0 YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gIAkJCWludGVsX2RwLT5p c19tc3QgPSBmYWxzZTsKPiAgCQkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50 ZWxfZHAtPm1zdF9tZ3IsCj4gIAkJCQkJCQlpbnRlbF9kcC0+aXNfbXN0KTsKPiAtCQkJZ290byBw dXRfcG93ZXI7Cj4gKwo+ICsJCQlyZXR1cm4gSVJRX05PTkU7Cj4gIAkJfQo+ICAJfQo+ICAKPiBA QCAtNjM1NywxNyArNjM1MiwxMCBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gIAkJaGFuZGxlZCA9 IGludGVsX2RwX3Nob3J0X3B1bHNlKGludGVsX2RwKTsKPiAgCj4gIAkJaWYgKCFoYW5kbGVkKQo+ IC0JCQlnb3RvIHB1dF9wb3dlcjsKPiArCQkJcmV0dXJuIElSUV9OT05FOwo+ICAJfQo+ICAKPiAt CXJldCA9IElSUV9IQU5ETEVEOwo+IC0KPiAtcHV0X3Bvd2VyOgo+IC0JaW50ZWxfZGlzcGxheV9w b3dlcl9wdXQoZGV2X3ByaXYsCj4gLQkJCQlpbnRlbF9hdXhfcG93ZXJfZG9tYWluKGludGVsX2Rp Z19wb3J0KSwKPiAtCQkJCXdha2VyZWYpOwo+IC0KPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4g SVJRX0hBTkRMRUQ7Cj4gIH0KPiAgCj4gIC8qIGNoZWNrIHRoZSBWQlQgdG8gc2VlIHdoZXRoZXIg dGhlIGVEUCBpcyBvbiBhbm90aGVyIHBvcnQgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ IGluZGV4IDk2MzY2M2JhMGVkZi4uODU2YTM5YzdlZTc3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcHNyLmMKPiBAQCAtMTI1MSwxMCArMTI1MSwxMyBAQCB2b2lkIGludGVsX3Bzcl9zaG9ydF9w dWxzZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJY29uc3QgdTggZXJyb3JzID0gRFBf UFNSX1JGQl9TVE9SQUdFX0VSUk9SIHwKPiAgCQkJICBEUF9QU1JfVlNDX1NEUF9VTkNPUlJFQ1RB QkxFX0VSUk9SIHwKPiAgCQkJICBEUF9QU1JfTElOS19DUkNfRVJST1I7Cj4gKwlpbnRlbF93YWtl cmVmX3Qgd2FrZXJlZjsKPiAgCj4gIAlpZiAoIUNBTl9QU1IoZGV2X3ByaXYpIHx8ICFpbnRlbF9k cF9pc19lZHAoaW50ZWxfZHApKQo+ICAJCXJldHVybjsKPiAgCj4gKwl3YWtlcmVmID0gaW50ZWxf ZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9ESVNQTEFZX0NPUkUpOwo+ ICsKPiAgCW11dGV4X2xvY2soJnBzci0+bG9jayk7Cj4gIAo+ICAJaWYgKCFwc3ItPmVuYWJsZWQg fHwgcHNyLT5kcCAhPSBpbnRlbF9kcCkKPiBAQCAtMTI5NCw2ICsxMjk3LDkgQEAgdm9pZCBpbnRl bF9wc3Jfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCWRybV9kcF9k cGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfUFNSX0VSUk9SX1NUQVRVUywgdmFsKTsKPiAg ZXhpdDoKPiAgCW11dGV4X3VubG9jaygmcHNyLT5sb2NrKTsKPiArCj4gKwlpbnRlbF9kaXNwbGF5 X3Bvd2VyX3B1dF9hc3luYyhkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX0RJU1BMQVlfQ09SRSwKPiAr CQkJCSAgICAgIHdha2VyZWYpOwo+ICB9Cj4gIAo+ICBib29sIGludGVsX3Bzcl9lbmFibGVkKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gLS0gCj4gMi4xNy4xCgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==