Re: [PATCH v2 00/11] drm/i915: Add support for asynchronous display power disabling

Ville Syrjälä
2019-05-09T16:25:49Z

On Thu, May 09, 2019 at 09:19:43AM +0300, Imre Deak wrote:
> This patchset is v2 of [1]. The main change is the rework of patch 1
> based on Chris' feedback.
>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
>
> [1] https://patchwork.freedesktop.org/series/60242/
>
> Imre Deak (11):
> drm/i915: Add support for tracking wakerefs w/o power-on guarantee
> drm/i915: Force printing wakeref tacking during pm_cleanup
> drm/i915: Verify power domains state during suspend in all cases
> drm/i915: Add support for asynchronous display power disabling
> drm/i915: Disable power asynchronously during DP AUX transfers
> drm/i915: WARN for eDP encoders in intel_dp_detect_dpcd()
> drm/i915: Remove the unneeded AUX power ref from intel_dp_detect()
> drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse()
> drm/i915: Replace use of PLLS power domain with DISPLAY_CORE domain
> drm/i915: Avoid taking the PPS lock for non-eDP/VLV/CHV
> drm/i915: Assert that TypeC ports are not used for eDP

I trust Chris scrutinized the wakeref stuff sufficiently so
I didn't pay all that much attention to those patches.

Patches 5-11 lgtm.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>
> drivers/gpu/drm/i915/i915_drv.h | 5 +
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_display.h | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 83 ++--
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 36 +-
> drivers/gpu/drm/i915/intel_drv.h | 52 ++-
> drivers/gpu/drm/i915/intel_psr.c | 6 +
> drivers/gpu/drm/i915/intel_runtime_pm.c | 595 +++++++++++++++++++++---
> drivers/gpu/drm/i915/intel_runtime_pm.h | 8 +
> 9 files changed, 662 insertions(+), 127 deletions(-)
>
> --
> 2.17.1

--
Ville Syrjälä
Intel