From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v2 08/11] drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse() Date: Thu, 9 May 2019 19:06:20 +0300 Message-ID: <20190509160620.GA25531@ideak-desk.fi.intel.com> References: <20190509061954.10379-1-imre.deak@intel.com> <20190509061954.10379-9-imre.deak@intel.com> <20190509155042.GG24299@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69E2B89DB0 for ; Thu, 9 May 2019 16:06:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190509155042.GG24299@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDksIDIwMTkgYXQgMDY6NTA6NDJQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgTWF5IDA5LCAyMDE5IGF0IDA5OjE5OjUxQU0gKzAzMDAsIEltcmUg RGVhayB3cm90ZToKPiA+IFRoZSBwb3dlciBnZXQvcHV0IHdhcyBhZGRlZCBpbgo+ID4gCj4gPiBj b21taXQgMWM3NjdiMzM5YjM5MzhiMTkwNzZmZmRjOWQ3MGFhMWU0MjM1YTQ1Ygo+ID4gQXV0aG9y OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gPiBEYXRlOiAgIE1vbiBBdWcgMTgg MTQ6NDI6NDIgMjAxNCArMDMwMAo+ID4gCj4gPiAgICAgZHJtL2k5MTU6IHRha2UgZGlzcGxheSBw b3J0IHBvd2VyIGRvbWFpbiBpbiBEUCBIUEQgaGFuZGxlCj4gPiAKPiA+IHRvIGFjY291bnQgZm9y IHRoZSBIVyBhY2Nlc3MgaW4gaWJ4X2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoKS4gVGhpcwo+ID4g bGF0dGVyIGNhbGwgd2FzIGluIHR1cm4gcmVtb3ZlZCBpbgo+ID4gCj4gPiBjb21taXQgN2QyM2Uz YzM3YmIzZmM2OTUyZGM4NDAwN2VlNjBjYjUzM2ZkMmQ1Ywo+ID4gQXV0aG9yOiBTaHViaGFuZ2kg U2hyaXZhc3RhdmEgPHNodWJoYW5naS5zaHJpdmFzdGF2YUBpbnRlbC5jb20+Cj4gPiBEYXRlOiAg IFdlZCBNYXIgMzAgMTg6MDU6MjMgMjAxNiArMDUzMAo+ID4gCj4gPiAgICAgZHJtL2k5MTU6IENs ZWFuaW5nIHVwIGludGVsX2RwX2hwZF9wdWxzZQo+ID4gCj4gPiBhZnRlciB3aGljaCB3ZSBkaWRu J3QgYWN0dWFsbHkgbmVlZCB0aGUgcG93ZXIgcmVmZXJlbmNlLgo+ID4gCj4gPiBPbmUgd2F5IHdl IGFyZSBhY2Nlc3NpbmcgdGhlIEhXIGR1cmluZyBIUEQgcHVsc2UgaGFuZGxpbmcgaXMgdmlhIERQ IEFVWAo+ID4gdHJhbnNmZXJzLCBidXQgdGhlIHRyYW5zZmVyIGZ1bmN0aW9uIHRha2VzIGl0cyBv d24gcmVmZXJlbmNlLCBzbyBkb2Vzbid0Cj4gPiBuZWVkIHRoZSByZWZlcmVuY2UgaW4gaW50ZWxf ZHBfaHBkX3B1bHNlKCkuCj4gPiAKPiA+IFRoZSBvdGhlciBzcG90IGlzIGluIHRoZSBQU1IgY29k ZSBkb2luZyByZWdpc3RlciBhY2Nlc3MsIGZvciB0aGF0IHdlIGNhbgo+ID4gdXNlIHRoZSBESVNQ TEFZX0NPUkUgcG93ZXIgZG9tYWluIGluIGEgc2ltaWxhciB3YXkgZG9uZSBpbiB0aGUgcHJldmlv dXMKPiA+IHBhdGNoLgo+IAo+IEkgZG9uJ3QgdGhpbmsgdGhlIFBTUiBjb2RlIHNob3VsZCB0b3Vj aCB0aGUgaGFyZHdhcmUgdW5sZXNzIHRoZSBjcnRjIGlzCj4gYWN0aXZlLiBTbyBub3Qgc3VyZSBp dCByZWFsbHkgbmVlZHMgYW55dGhpbmcuCgpBaCwgcmlnaHQsIHRoYW5rcyBmb3Igc3BvdHRpbmcg aXQuIEkgbm90aWNlZCB0aGUgYWNjZXNzIGluCgppbnRlbF9wc3Jfc2hvcnRfcHVsc2UoKS0+aW50 ZWxfcHNyX2Rpc2FibGVfbG9ja2VkKCkKCm9ubHkgYnkgY29kZSBpbnNwZWN0aW9uLCBkaWRuJ3Qg dGhpbmsgb2YgY2hlY2tpbmcgdGhlIHN0YXRlIGluIHdoaWNoIGl0CmNhbiBiZSBjYWxsZWQgKGV2 ZW4gdGhvdWdoIHRoZSBmbiBuYW1lIHNob3VsZCd2ZSBiZWVuIGluZGljYXRpdmUpLiBTbwp5ZXMg UFNSIGlzIGVuYWJsZWQgYXQgdGhhdCBwb2ludCBhbmQgdGhlIG1vZGVzZXQgc2hvdWxkIGhhdmUg YWxyZWFkeSBhbGwKdGhlIHBvd2VyIHJlZmVyZW5jZXMgbmVlZGVkIGZvciB0aGF0IGFjY2Vzcy4g SSB3aWxsIHJlbW92ZSB0aGUgZ2V0L3B1dApmcm9tIGludGVsX3Bzcl9zaG9ydF9wdWxzZSgpLgoK PiAKPiA+IAo+ID4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IENj OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiA+IFNpZ25l ZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgMjAgKysrKy0tLS0tLS0tLS0tLS0tLS0K PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8ICA2ICsrKysrKwo+ID4gIDIg ZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gPiAKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gaW5kZXggMjRjY2ExMmE5YTNlLi5kZTg4MWJmZWEw MTEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAtNjMwOCw5ICs2MzA4 LDYgQEAgZW51bSBpcnFyZXR1cm4KPiA+ICBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gPiAgewo+ID4g IAlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gJmludGVsX2RpZ19wb3J0LT5kcDsKPiA+IC0J c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZHBfdG9faTkxNShpbnRlbF9kcCk7 Cj4gPiAtCWVudW0gaXJxcmV0dXJuIHJldCA9IElSUV9OT05FOwo+ID4gLQlpbnRlbF93YWtlcmVm X3Qgd2FrZXJlZjsKPiA+ICAKPiA+ICAJaWYgKGxvbmdfaHBkICYmIGludGVsX2RpZ19wb3J0LT5i YXNlLnR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkgewo+ID4gIAkJLyoKPiA+IEBAIC02MzMzLDkg KzYzMzAsNiBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAq aW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gPiAgCQlyZXR1cm4gSVJRX05PTkU7Cj4g PiAgCX0KPiA+ICAKPiA+IC0Jd2FrZXJlZiA9IGludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9w cml2LAo+ID4gLQkJCQkJICBpbnRlbF9hdXhfcG93ZXJfZG9tYWluKGludGVsX2RpZ19wb3J0KSk7 Cj4gPiAtCj4gPiAgCWlmIChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gPiAgCQlpZiAoaW50ZWxfZHBf Y2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkgPT0gLUVJTlZBTCkgewo+ID4gIAkJCS8qCj4gPiBA QCAtNjM0Nyw3ICs2MzQxLDggQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LCBib29sIGxvbmdfaHBkKQo+ID4gIAkJCWludGVsX2Rw LT5pc19tc3QgPSBmYWxzZTsKPiA+ICAJCQlkcm1fZHBfbXN0X3RvcG9sb2d5X21ncl9zZXRfbXN0 KCZpbnRlbF9kcC0+bXN0X21nciwKPiA+ICAJCQkJCQkJaW50ZWxfZHAtPmlzX21zdCk7Cj4gPiAt CQkJZ290byBwdXRfcG93ZXI7Cj4gPiArCj4gPiArCQkJcmV0dXJuIElSUV9OT05FOwo+ID4gIAkJ fQo+ID4gIAl9Cj4gPiAgCj4gPiBAQCAtNjM1NywxNyArNjM1MiwxMCBAQCBpbnRlbF9kcF9ocGRf cHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9u Z19ocGQpCj4gPiAgCQloYW5kbGVkID0gaW50ZWxfZHBfc2hvcnRfcHVsc2UoaW50ZWxfZHApOwo+ ID4gIAo+ID4gIAkJaWYgKCFoYW5kbGVkKQo+ID4gLQkJCWdvdG8gcHV0X3Bvd2VyOwo+ID4gKwkJ CXJldHVybiBJUlFfTk9ORTsKPiA+ICAJfQo+ID4gIAo+ID4gLQlyZXQgPSBJUlFfSEFORExFRDsK PiA+IC0KPiA+IC1wdXRfcG93ZXI6Cj4gPiAtCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9w cml2LAo+ID4gLQkJCQlpbnRlbF9hdXhfcG93ZXJfZG9tYWluKGludGVsX2RpZ19wb3J0KSwKPiA+ IC0JCQkJd2FrZXJlZik7Cj4gPiAtCj4gPiAtCXJldHVybiByZXQ7Cj4gPiArCXJldHVybiBJUlFf SEFORExFRDsKPiA+ICB9Cj4gPiAgCj4gPiAgLyogY2hlY2sgdGhlIFZCVCB0byBzZWUgd2hldGhl ciB0aGUgZURQIGlzIG9uIGFub3RoZXIgcG9ydCAqLwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy LmMKPiA+IGluZGV4IDk2MzY2M2JhMGVkZi4uODU2YTM5YzdlZTc3IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Bzci5jCj4gPiBAQCAtMTI1MSwxMCArMTI1MSwxMyBAQCB2b2lkIGludGVs X3Bzcl9zaG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gIAljb25zdCB1 OCBlcnJvcnMgPSBEUF9QU1JfUkZCX1NUT1JBR0VfRVJST1IgfAo+ID4gIAkJCSAgRFBfUFNSX1ZT Q19TRFBfVU5DT1JSRUNUQUJMRV9FUlJPUiB8Cj4gPiAgCQkJICBEUF9QU1JfTElOS19DUkNfRVJS T1I7Cj4gPiArCWludGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+ID4gIAo+ID4gIAlpZiAoIUNBTl9Q U1IoZGV2X3ByaXYpIHx8ICFpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKQo+ID4gIAkJcmV0dXJu Owo+ID4gIAo+ID4gKwl3YWtlcmVmID0gaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYs IFBPV0VSX0RPTUFJTl9ESVNQTEFZX0NPUkUpOwo+ID4gKwo+ID4gIAltdXRleF9sb2NrKCZwc3It PmxvY2spOwo+ID4gIAo+ID4gIAlpZiAoIXBzci0+ZW5hYmxlZCB8fCBwc3ItPmRwICE9IGludGVs X2RwKQo+ID4gQEAgLTEyOTQsNiArMTI5Nyw5IEBAIHZvaWQgaW50ZWxfcHNyX3Nob3J0X3B1bHNl KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiAgCWRybV9kcF9kcGNkX3dyaXRlYigmaW50 ZWxfZHAtPmF1eCwgRFBfUFNSX0VSUk9SX1NUQVRVUywgdmFsKTsKPiA+ICBleGl0Ogo+ID4gIAlt dXRleF91bmxvY2soJnBzci0+bG9jayk7Cj4gPiArCj4gPiArCWludGVsX2Rpc3BsYXlfcG93ZXJf cHV0X2FzeW5jKGRldl9wcml2LCBQT1dFUl9ET01BSU5fRElTUExBWV9DT1JFLAo+ID4gKwkJCQkg ICAgICB3YWtlcmVmKTsKPiA+ICB9Cj4gPiAgCj4gPiAgYm9vbCBpbnRlbF9wc3JfZW5hYmxlZChz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gLS0gCj4gPiAyLjE3LjEKPiAKPiAtLSAKPiBW aWxsZSBTeXJqw6Rsw6QKPiBJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZng=