From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v3 08/11] drm/i915: Remove the unneeded AUX power ref from intel_dp_hpd_pulse() Date: Thu, 9 May 2019 20:48:13 +0300 Message-ID: <20190509174813.GC25531@ideak-desk.fi.intel.com> References: <20190509173446.31095-1-imre.deak@intel.com> <20190509173446.31095-9-imre.deak@intel.com> <4816bf2c86001fb640de47316f40db801d3524a0.camel@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DA8D89AAE for ; Thu, 9 May 2019 17:48:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <4816bf2c86001fb640de47316f40db801d3524a0.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDksIDIwMTkgYXQgMDg6NDM6MjVQTSArMDMwMCwgU291emEsIEpvc2Ugd3Jv dGU6Cj4gT24gVGh1LCAyMDE5LTA1LTA5IGF0IDIwOjM0ICswMzAwLCBJbXJlIERlYWsgd3JvdGU6 Cj4gPiBUaGUgcG93ZXIgZ2V0L3B1dCB3YXMgYWRkZWQgaW4KPiA+IAo+ID4gY29tbWl0IDFjNzY3 YjMzOWIzOSAoImRybS9pOTE1OiB0YWtlIGRpc3BsYXkgcG9ydCBwb3dlciBkb21haW4gaW4gRFAK PiA+IEhQRCBoYW5kbGVyIikKPiA+IEF1dGhvcjogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu Y29tPgo+ID4gRGF0ZTogICBNb24gQXVnIDE4IDE0OjQyOjQyIDIwMTQgKzAzMDAKPiA+IAo+ID4g dG8gYWNjb3VudCBmb3IgdGhlIEhXIGFjY2VzcyBpbiBpYnhfZGlnaXRhbF9wb3J0X2Nvbm5lY3Rl ZCgpLiBUaGlzCj4gPiBsYXR0ZXIgY2FsbCB3YXMgaW4gdHVybiByZW1vdmVkIGluCj4gPiAKPiA+ IGNvbW1pdCA3ZDIzZTNjMzdiYjMgKCJkcm0vaTkxNTogQ2xlYW5pbmcgdXAgaW50ZWxfZHBfaHBk X3B1bHNlIikKPiA+IEF1dGhvcjogU2h1YmhhbmdpIFNocml2YXN0YXZhIDxzaHViaGFuZ2kuc2hy aXZhc3RhdmFAaW50ZWwuY29tPgo+ID4gRGF0ZTogICBXZWQgTWFyIDMwIDE4OjA1OjIzIDIwMTYg KzA1MzAKPiA+IAo+ID4gYWZ0ZXIgd2hpY2ggd2UgZGlkbid0IGFjdHVhbGx5IG5lZWQgdGhlIHBv d2VyIHJlZmVyZW5jZS4KPiA+IAo+ID4gT25lIHdheSB3ZSBhcmUgYWNjZXNzaW5nIHRoZSBIVyBk dXJpbmcgSFBEIHB1bHNlIGhhbmRsaW5nIGlzIHZpYSBEUAo+ID4gQVVYCj4gPiB0cmFuc2ZlcnMs IGJ1dCB0aGUgdHJhbnNmZXIgZnVuY3Rpb24gdGFrZXMgaXRzIG93biByZWZlcmVuY2UsIHNvCj4g PiBkb2Vzbid0Cj4gPiBuZWVkIHRoZSByZWZlcmVuY2UgaW4gaW50ZWxfZHBfaHBkX3B1bHNlKCku Cj4gCj4gPERpZCBub3QgbG9vayBhdCB0aGUgb3RoZXIgcGF0Y2hlcyAvPgo+IAo+IFRoZSBwcm9i bGVtIG9mIHJlbW92aW5nIHRoYXQgcmVmZXJlbmNlIGlzIHRoYXQgZXZlcnkgYXV4IHRyYW5zZmVy IHdpbGwKPiB0YWtlIGEgbGl0dGxlIGJpdCBtb3JlIG9mIHRpbWUgYmVjYXVzZSBpdCB3aWxsIG5l ZWQgdG8gd2FpdCB0aGUgYXV4Cj4gcG93ZXIgd2VsbCB0byBiZSBlbmFibGVkL2Rpc2FibGVkLCB0 YWtpbmcgb25lIHJlZmVyZW5jZSBiZWZvcmUgaGFuZAo+IHNhdmUgdXMgdGhhdC4KClRoYXQgaXMg c29sdmVkIGJ5IGRpc2FibGluZyB0aGUgcG93ZXIgd2l0aCBhIGRlbGF5LiBCdXQgd2UgY291bGQg b25seQpjbGFpbSB0aGF0IHRoZXJlIHdvdWxkIGJlIGFueSBwcm9ibGVtIChldmVuIGluIHRoZSBs YWNrIG9mIHRoZSBkZWxheWVkCmRpc2FibGluZykgd2l0aCBhY3R1YWwgbnVtYmVycyBmb3IgdGhl IGVuYWJsaW5nL2Rpc2FibGluZyBkZWxheS4gUGxlYXNlCmNoZWNrIHRoZSBkaXNjdXNzaW9uIG9u IHBhdGNoIDQgZm9yIG1vcmUgZGV0YWlscy4KCj4gCj4gPiAKPiA+IFRoZSBvdGhlciBzcG90IGlz IGluCj4gPiAKPiA+IAlpbnRlbF9wc3Jfc2hvcnRfcHVsc2UoKS0+aW50ZWxfcHNyX2Rpc2FibGVf bG9ja2VkKCkKPiA+IAo+ID4gYnV0IHRoYXQgY2FuIG9ubHkgaGFwcGVuIHdoZW4gdGhlIHBhbmVs IGlzIGVuYWJsZWQgd2l0aCB0aGUKPiA+IGNvcnJlc3BvbmRpbmcgbW9kZXNldCBhbHJlYWR5IGhv bGRpbmcgdGhlIHJlcXVpcmVkIHBvd2VyIHJlZmVyZW5jZS4KPiA+IAo+ID4gdjI6Cj4gPiAtIFJl bW92ZSB0aGUgdW5uZWVkZWQgcG93ZXIgZ2V0L3B1dCBmcm9tIGludGVsX3Bzcl9kaXNhYmxlX2xv Y2tlZCgpLgo+ID4gICAoVmlsbGUpCj4gPiAtIENoZWNrcGF0Y2ggY29tbWl0IHF1b3RpbmcgZm9y bWF0IGZpeCBpbiB0aGUgY29tbWl0IGxvZy4KPiA+IAo+ID4gQ2M6IFZpbGxlIFN5cmphbGEgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KPiA+IENjOiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNv dXphQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGlu dGVsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYyB8IDIwICsrKystLS0tLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwLmMKPiA+IGluZGV4IDU1MzA3MTgxMmY2OS4uOGE5MWI0NTNiMmU5IDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTYzMDIsOSArNjMwMiw2IEBAIGVudW0gaXJxcmV0 dXJuCj4gPiAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmlu dGVsX2RpZ19wb3J0LCBib29sCj4gPiBsb25nX2hwZCkKPiA+ICB7Cj4gPiAgCXN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAgPSAmaW50ZWxfZGlnX3BvcnQtPmRwOwo+ID4gLQlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1KGludGVsX2RwKTsKPiA+IC0JZW51bSBp cnFyZXR1cm4gcmV0ID0gSVJRX05PTkU7Cj4gPiAtCWludGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+ ID4gIAo+ID4gIAlpZiAobG9uZ19ocGQgJiYgaW50ZWxfZGlnX3BvcnQtPmJhc2UudHlwZSA9PSBJ TlRFTF9PVVRQVVRfRURQKQo+ID4gewo+ID4gIAkJLyoKPiA+IEBAIC02MzI3LDkgKzYzMjQsNiBA QCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ID4gKmludGVs X2RpZ19wb3J0LCBib29sIGxvbmdfaHBkKQo+ID4gIAkJcmV0dXJuIElSUV9OT05FOwo+ID4gIAl9 Cj4gPiAgCj4gPiAtCXdha2VyZWYgPSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwK PiA+IC0JCQkJCSAgaW50ZWxfYXV4X3Bvd2VyX2RvbWFpbihpbnRlbF8KPiA+IGRpZ19wb3J0KSk7 Cj4gPiAtCj4gPiAgCWlmIChpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gPiAgCQlpZiAoaW50ZWxfZHBf Y2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkgPT0gLUVJTlZBTCkgewo+ID4gIAkJCS8qCj4gPiBA QCAtNjM0MSw3ICs2MzM1LDggQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQKPiA+ICppbnRlbF9kaWdfcG9ydCwgYm9vbCBsb25nX2hwZCkKPiA+ICAJCQlpbnRl bF9kcC0+aXNfbXN0ID0gZmFsc2U7Cj4gPiAgCQkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0 X21zdCgmaW50ZWxfZHAtCj4gPiA+bXN0X21nciwKPiA+ICAJCQkJCQkJaW50ZWxfZHAtCj4gPiA+ aXNfbXN0KTsKPiA+IC0JCQlnb3RvIHB1dF9wb3dlcjsKPiA+ICsKPiA+ICsJCQlyZXR1cm4gSVJR X05PTkU7Cj4gPiAgCQl9Cj4gPiAgCX0KPiA+ICAKPiA+IEBAIC02MzUxLDE3ICs2MzQ2LDEwIEBA IGludGVsX2RwX2hwZF9wdWxzZShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0Cj4gPiAqaW50ZWxf ZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gPiAgCQloYW5kbGVkID0gaW50ZWxfZHBfc2hvcnRf cHVsc2UoaW50ZWxfZHApOwo+ID4gIAo+ID4gIAkJaWYgKCFoYW5kbGVkKQo+ID4gLQkJCWdvdG8g cHV0X3Bvd2VyOwo+ID4gKwkJCXJldHVybiBJUlFfTk9ORTsKPiA+ICAJfQo+ID4gIAo+ID4gLQly ZXQgPSBJUlFfSEFORExFRDsKPiA+IC0KPiA+IC1wdXRfcG93ZXI6Cj4gPiAtCWludGVsX2Rpc3Bs YXlfcG93ZXJfcHV0KGRldl9wcml2LAo+ID4gLQkJCQlpbnRlbF9hdXhfcG93ZXJfZG9tYWluKGlu dGVsX2RpZ19wb3J0KSwKPiA+IC0JCQkJd2FrZXJlZik7Cj4gPiAtCj4gPiAtCXJldHVybiByZXQ7 Cj4gPiArCXJldHVybiBJUlFfSEFORExFRDsKPiA+ICB9Cj4gPiAgCj4gPiAgLyogY2hlY2sgdGhl IFZCVCB0byBzZWUgd2hldGhlciB0aGUgZURQIGlzIG9uIGFub3RoZXIgcG9ydCAqLwoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==