From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v4 4/8] drm/i915: Shuffle stride checking
 code around
Date: Fri, 10 May 2019 10:37:01 +0200
Message-ID: <20190510083701.GH17751@phenom.ffwll.local>
References: <20190509122159.24376-1-ville.syrjala@linux.intel.com>
 <20190509122159.24376-5-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com
 [IPv6:2a00:1450:4864:20::544])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2251C8938C
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 May 2019 08:37:05 +0000 (UTC)
Received: by mail-ed1-x544.google.com with SMTP id g57so4361712edc.12
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 May 2019 01:37:05 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20190509122159.24376-5-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXkgMDksIDIwMTkgYXQgMDM6MjE6NTVQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IFJlb3JnYW5pemUgc29tZSBmYiBzdHJpZGUgY2hlY2tpbmcgY29kZSBhIGJpdCB0
byBwcmVwYXJlIGZvcgo+IGd0dCByZW1hcHBpbmcuIEFuZCBkbyBhIGJpdCBvZiBzL3BpdGNoL3N0
cmlkZS8gcmVuYW1pbmcgaW4gdGhlCj4gcHJvY2VzcyBmb3IgYSBiaXQgbW9yZSB1bmlmb3JtaXR5
IChhcGFydCBmcm9tIHRoZSB3aG9sZQo+IGZiLT5waXRjaGVzW10gdGhpbmcpLgo+IAo+IENjOiBE
YW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFZp
bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1i
eTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDY0ICsrKysrKysrKysrKysrLS0tLS0t
LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDMyIGRlbGV0aW9u
cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5
LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBmNGU2ZTlh
OGJiZjkuLjMyMWNiNmQyYmM3NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5
LmMKPiBAQCAtMjUwOSw2ICsyNTA5LDMzIEBAIGJvb2wgaXNfY2NzX21vZGlmaWVyKHU2NCBtb2Rp
ZmllcikKPiAgCSAgICAgICBtb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRURfQ0NT
Owo+ICB9Cj4gIAo+ICtzdGF0aWMKPiArdTMyIGludGVsX2ZiX21heF9zdHJpZGUoc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQl1MzIgcGl4ZWxfZm9ybWF0LCB1NjQgbW9k
aWZpZXIpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ICsJc3RydWN0IGludGVs
X3BsYW5lICpwbGFuZTsKPiArCj4gKwkvKgo+ICsJICogV2UgYXNzdW1lIHRoZSBwcmltYXJ5IHBs
YW5lIGZvciBwaXBlIEEgaGFzCj4gKwkgKiB0aGUgaGlnaGVzdCBzdHJpZGUgbGltaXRzIG9mIHRo
ZW0gYWxsLgo+ICsJICovCj4gKwljcnRjID0gaW50ZWxfZ2V0X2NydGNfZm9yX3BpcGUoZGV2X3By
aXYsIFBJUEVfQSk7Cj4gKwlwbGFuZSA9IHRvX2ludGVsX3BsYW5lKGNydGMtPmJhc2UucHJpbWFy
eSk7Cj4gKwo+ICsJcmV0dXJuIHBsYW5lLT5tYXhfc3RyaWRlKHBsYW5lLCBwaXhlbF9mb3JtYXQs
IG1vZGlmaWVyLAo+ICsJCQkJIERSTV9NT0RFX1JPVEFURV8wKTsKPiArfQo+ICsKPiArc3RhdGlj
IHUzMgo+ICtpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVi
dWZmZXIgKmZiLCBpbnQgY29sb3JfcGxhbmUpCj4gK3sKPiArCWlmIChmYi0+bW9kaWZpZXIgPT0g
RFJNX0ZPUk1BVF9NT0RfTElORUFSKQo+ICsJCXJldHVybiA2NDsKPiArCWVsc2UKPiArCQlyZXR1
cm4gaW50ZWxfdGlsZV93aWR0aF9ieXRlcyhmYiwgY29sb3JfcGxhbmUpOwo+ICt9Cj4gKwo+ICBz
dGF0aWMgaW50Cj4gIGludGVsX2ZpbGxfZmJfaW5mbyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYsCj4gIAkJICAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gQEAgLTM1ODYs
MTUgKzM2MTMsNiBAQCBzdGF0aWMgYm9vbCBpOXh4X3BsYW5lX2dldF9od19zdGF0ZShzdHJ1Y3Qg
aW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAtc3RhdGljIHUz
Mgo+IC1pbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZm
ZXIgKmZiLCBpbnQgY29sb3JfcGxhbmUpCj4gLXsKPiAtCWlmIChmYi0+bW9kaWZpZXIgPT0gRFJN
X0ZPUk1BVF9NT0RfTElORUFSKQo+IC0JCXJldHVybiA2NDsKPiAtCWVsc2UKPiAtCQlyZXR1cm4g
aW50ZWxfdGlsZV93aWR0aF9ieXRlcyhmYiwgY29sb3JfcGxhbmUpOwo+IC19Cj4gLQo+ICBzdGF0
aWMgdm9pZCBza2xfZGV0YWNoX3NjYWxlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0Yywg
aW50IGlkKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfY3J0Yy0+YmFz
ZS5kZXY7Cj4gQEAgLTE0OTIxLDMxICsxNDkzOSwxMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRy
bV9mcmFtZWJ1ZmZlcl9mdW5jcyBpbnRlbF9mYl9mdW5jcyA9IHsKPiAgCS5kaXJ0eSA9IGludGVs
X3VzZXJfZnJhbWVidWZmZXJfZGlydHksCj4gIH07Cj4gIAo+IC1zdGF0aWMKPiAtdTMyIGludGVs
X2ZiX3BpdGNoX2xpbWl0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJ
IHUzMiBwaXhlbF9mb3JtYXQsIHU2NCBmYl9tb2RpZmllcikKPiAtewo+IC0Jc3RydWN0IGludGVs
X2NydGMgKmNydGM7Cj4gLQlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+IC0KPiAtCS8qCj4g
LQkgKiBXZSBhc3N1bWUgdGhlIHByaW1hcnkgcGxhbmUgZm9yIHBpcGUgQSBoYXMKPiAtCSAqIHRo
ZSBoaWdoZXN0IHN0cmlkZSBsaW1pdHMgb2YgdGhlbSBhbGwuCj4gLQkgKi8KPiAtCWNydGMgPSBp
bnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXZfcHJpdiwgUElQRV9BKTsKPiAtCXBsYW5lID0gdG9f
aW50ZWxfcGxhbmUoY3J0Yy0+YmFzZS5wcmltYXJ5KTsKPiAtCj4gLQlyZXR1cm4gcGxhbmUtPm1h
eF9zdHJpZGUocGxhbmUsIHBpeGVsX2Zvcm1hdCwgZmJfbW9kaWZpZXIsCj4gLQkJCQkgRFJNX01P
REVfUk9UQVRFXzApOwo+IC19Cj4gLQo+ICBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2lu
aXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKPiAgCQkJCSAgc3RydWN0IGRy
bV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgCQkJCSAgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIg
Km1vZGVfY21kKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0
b19pOTE1KG9iai0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSAm
aW50ZWxfZmItPmJhc2U7Cj4gLQl1MzIgcGl0Y2hfbGltaXQ7Cj4gKwl1MzIgbWF4X3N0cmlkZTsK
PiAgCXVuc2lnbmVkIGludCB0aWxpbmcsIHN0cmlkZTsKPiAgCWludCByZXQgPSAtRUlOVkFMOwo+
ICAJaW50IGk7Cj4gQEAgLTE0OTk3LDEzICsxNDk5NywxMyBAQCBzdGF0aWMgaW50IGludGVsX2Zy
YW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKPiAgCQln
b3RvIGVycjsKPiAgCX0KPiAgCj4gLQlwaXRjaF9saW1pdCA9IGludGVsX2ZiX3BpdGNoX2xpbWl0
KGRldl9wcml2LCBtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LAo+IC0JCQkJCSAgIG1vZGVfY21kLT5t
b2RpZmllclswXSk7Cj4gLQlpZiAobW9kZV9jbWQtPnBpdGNoZXNbMF0gPiBwaXRjaF9saW1pdCkg
ewo+ICsJbWF4X3N0cmlkZSA9IGludGVsX2ZiX21heF9zdHJpZGUoZGV2X3ByaXYsIG1vZGVfY21k
LT5waXhlbF9mb3JtYXQsCj4gKwkJCQkJIG1vZGVfY21kLT5tb2RpZmllclswXSk7Cj4gKwlpZiAo
bW9kZV9jbWQtPnBpdGNoZXNbMF0gPiBtYXhfc3RyaWRlKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygi
JXMgcGl0Y2ggKCV1KSBtdXN0IGJlIGF0IG1vc3QgJWRcbiIsCj4gIAkJCSAgICAgIG1vZGVfY21k
LT5tb2RpZmllclswXSAhPSBEUk1fRk9STUFUX01PRF9MSU5FQVIgPwo+ICAJCQkgICAgICAidGls
ZWQiIDogImxpbmVhciIsCj4gLQkJCSAgICAgIG1vZGVfY21kLT5waXRjaGVzWzBdLCBwaXRjaF9s
aW1pdCk7Cj4gKwkJCSAgICAgIG1vZGVfY21kLT5waXRjaGVzWzBdLCBtYXhfc3RyaWRlKTsKPiAg
CQlnb3RvIGVycjsKPiAgCX0KPiAgCj4gLS0gCj4gMi4yMS4wCj4gCgotLSAKRGFuaWVsIFZldHRl
cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu
Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4