Re: [igt-dev] [PATCH i-g-t 02/27] trace.pl: Ignore signaling on non i915 fences

Chris Wilson
2019-05-21T07:57:45Z

Quoting Tvrtko Ursulin (2019-05-20 15:47:14)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> gem_wsim uses the sw_fence timeline and confuses the script.
>
> v2:
> * Check the correct timeline as well. (Chris)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> scripts/trace.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 8c896cfde6b0..ac141a514055 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -443,6 +443,9 @@ while (<>) {
> } elsif ($tp_name eq 'dma_fence:dma_fence_signaled:') {
> my $nkey;
>
> + next unless $tp{'driver'} eq 'i915' and
> + $tp{'timeline'} eq 'signaled';

Hopefully that remains unique...
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

I do recall wanting to remove the strings from all the tracepoints :-p
-Chris