[PATCH i-g-t] lib/i915: End warning message with a newline

[PATCH i-g-t] lib/i915: End warning message with a newline

[Tvrtko Ursulin]

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Otherwise debug output looks messy when we trigger this.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 lib/i915/gem_engine_topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index 7ca3616687b9..d0c8bd5aaeac 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -123,7 +123,7 @@ static void init_engine(struct intel_execution_engine2 *e2,
 	if (__e2->name) {
 		e2->name = __e2->name;
 	} else {
-		igt_warn("found unknown engine (%d, %d)", class, instance);
+		igt_warn("found unknown engine (%d, %d)\n", class, instance);
 		e2->name = unknown_name;
 		e2->flags = -1;
 	}
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] lib/i915: End warning message with a newline

[Chris Wilson]

Quoting Tvrtko Ursulin (2019-05-22 17:06:58)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Otherwise debug output looks messy when we trigger this.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
>  lib/i915/gem_engine_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> index 7ca3616687b9..d0c8bd5aaeac 100644
> --- a/lib/i915/gem_engine_topology.c
> +++ b/lib/i915/gem_engine_topology.c
> @@ -123,7 +123,7 @@ static void init_engine(struct intel_execution_engine2 *e2,
>         if (__e2->name) {
>                 e2->name = __e2->name;
>         } else {
> -               igt_warn("found unknown engine (%d, %d)", class, instance);
> +               igt_warn("found unknown engine (%d, %d)\n", class, instance);

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] lib/i915: End warning message with a newline

[Andi Shyti]

Hi Tvrtko,

On Wed, May 22, 2019 at 05:06:58PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Otherwise debug output looks messy when we trigger this.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx