intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage
Date: Thu, 23 May 2019 00:28:24 +0300	[thread overview]
Message-ID: <20190522212824.GE5030@intel.intel> (raw)
In-Reply-To: <20190522163141.29252-1-tvrtko.ursulin@linux.intel.com>

Hi Tvrtko,

> +static void all(int i915)
> +{
> +	const struct intel_execution_engine2 *e;
> +
> +	__for_each_physical_engine(i915, e)
> +		basic(i915, e, false);

ops... there is an error in my previous patch.

I restored the meaining of flags because you and Chris didn't
like the boolean true/false meaning, indeed here I still check
with:

	if ((flags & HANG) == 0) {

but then I forgot to update the test cases.

This means that this line needs to be

	basic(i915, e, 0);

as the rest.

I'm sorry about the confusion! In any case,

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-05-22 21:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 16:31 [PATCH i-g-t] tests/i915: Restore some BAT coverage Tvrtko Ursulin
2019-05-22 16:45 ` [igt-dev] " Chris Wilson
2019-05-22 21:28 ` Andi Shyti [this message]
2019-05-23  6:37 ` [PATCH i-g-t v2] " Tvrtko Ursulin
2019-05-23  6:43   ` [igt-dev] " Tvrtko Ursulin
2019-05-23  6:58     ` Chris Wilson
2019-05-23 12:02       ` Mika Kuoppala
2019-05-23 12:08         ` Chris Wilson
2019-05-23 11:43   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522212824.GE5030@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).