From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 02/10] drm/i915/dmc: extract fw_info and table walk from intel_package_header Date: Thu, 23 May 2019 10:36:59 -0700 Message-ID: <20190523173659.GQ4441@intel.com> References: <20190523082420.10352-1-lucas.demarchi@intel.com> <20190523082420.10352-2-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8751E6E03A for ; Thu, 23 May 2019 17:36:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190523082420.10352-2-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMjMsIDIwMTkgYXQgMDE6MjQ6MTJBTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE1vdmUgZndfaW5mbyBvdXQgb2Ygc3RydWN0IGludGVsX3BhY2thZ2VfaGVhZGVy IHRvIGFsbG93IGl0IHRvIGdyb3cgbW9yZQo+IGVhc2lseSBpbiBmdXR1cmUuIFRvIG1ha2UgYSBj bGVhbmVyIG1vdmUsIGxldCdzIGFsc28gZXh0cmFjdCBhIGZ1bmN0aW9uIHRvCj4gc2VhcmNoIHRo ZSBoZWFkZXIgZm9yIHRoZSBkbWNfb2Zmc2V0Lgo+IAo+IFdoaWxlIHJldmlld2luZyB0aGlzIGNv ZGUgSSB3b25kZXJlZCB3aHkgd2UgY29udGludWVkIHRoZSBzZWFyY2ggZXZlbgo+IGFmdGVyIGZp bmRpbmcgYSBzdWl0YWJsZSBmaXJtd2FyZS4gQWRkIGEgY29tbWVudCB0byBleHBsYWluIHdlIHdp bGwKPiBjb250aW51ZSB0byB0cnkgdG8gZmluZCBhIG1vcmUgc3BlY2lmaWMgZmlybXdhcmUgdmVy c2lvbiwgZXZlbiBpZiB0aGlzCj4gaXMgbm90IHJlcXVpcmVkIGJ5IHRoZSBzcGVjLgo+IAo+IFNp Z25lZC1vZmYtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYyB8IDY4ICsrKysrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCsp LCAxNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY3NyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jc3IuYwo+IGluZGV4IGIw NWU3YTZhZWJjNy4uMDFhZTM1NmU2OWNjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Nzci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMK PiBAQCAtNzAsNiArNzAsNyBAQCBNT0RVTEVfRklSTVdBUkUoU0tMX0NTUl9QQVRIKTsKPiAgTU9E VUxFX0ZJUk1XQVJFKEJYVF9DU1JfUEFUSCk7Cj4gIAo+ICAjZGVmaW5lIENTUl9ERUZBVUxUX0ZX X09GRlNFVAkJMHhGRkZGRkZGRgo+ICsjZGVmaW5lIFBBQ0tBR0VfTUFYX0ZXX0lORk9fRU5UUklF UwkyMAo+ICAKPiAgc3RydWN0IGludGVsX2Nzc19oZWFkZXIgewo+ICAJLyogMHgwOSBmb3IgRE1D ICovCj4gQEAgLTEzOSw4ICsxNDAsNiBAQCBzdHJ1Y3QgaW50ZWxfcGFja2FnZV9oZWFkZXIgewo+ ICAKPiAgCS8qIE51bWJlciBvZiB2YWxpZCBlbnRyaWVzIGluIHRoZSBGV0luZm8gYXJyYXkgYmVs b3cgKi8KPiAgCXUzMiBudW1fZW50cmllczsKPiAtCj4gLQlzdHJ1Y3QgaW50ZWxfZndfaW5mbyBm d19pbmZvWzIwXTsKPiAgfSBfX3BhY2tlZDsKPiAgCj4gIHN0cnVjdCBpbnRlbF9kbWNfaGVhZGVy IHsKPiBAQCAtMjkyLDYgKzI5MSw0NiBAQCB2b2lkIGludGVsX2Nzcl9sb2FkX3Byb2dyYW0oc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJZ2VuOV9zZXRfZGNfc3RhdGVfZGVi dWdtYXNrKGRldl9wcml2KTsKPiAgfQo+ICAKPiArLyoKPiArICogU2VhcmNoIGZ3X2luZm8gdGFi bGUgZm9yIGRtY19vZmZzZXQgdG8gZmluZCBmaXJtd2FyZSBiaW5hcnk6IG51bV9lbnRyaWVzIGlz Cj4gKyAqIGFscmVhZHkgc2FuaXRpemVkLgo+ICsgKi8KPiArc3RhdGljIHUzMiBmaW5kX2RtY19m d19vZmZzZXQoY29uc3Qgc3RydWN0IGludGVsX2Z3X2luZm8gKmZ3X2luZm8sCj4gKwkJCSAgICAg IHVuc2lnbmVkIGludCBudW1fZW50cmllcywKPiArCQkJICAgICAgY29uc3Qgc3RydWN0IHN0ZXBw aW5nX2luZm8gKnNpKQo+ICt7Cj4gKwl1MzIgZG1jX29mZnNldCA9IENTUl9ERUZBVUxUX0ZXX09G RlNFVDsKPiArCXVuc2lnbmVkIGludCBpOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBudW1fZW50 cmllczsgaSsrKSB7Cj4gKwkJaWYgKGZ3X2luZm9baV0uc3Vic3RlcHBpbmcgPT0gJyonICYmCj4g KwkJICAgIHNpLT5zdGVwcGluZyA9PSBmd19pbmZvW2ldLnN0ZXBwaW5nKSB7Cj4gKwkJCWRtY19v ZmZzZXQgPSBmd19pbmZvW2ldLm9mZnNldDsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsKPiArCQlp ZiAoc2ktPnN0ZXBwaW5nID09IGZ3X2luZm9baV0uc3RlcHBpbmcgJiYKPiArCQkgICAgc2ktPnN1 YnN0ZXBwaW5nID09IGZ3X2luZm9baV0uc3Vic3RlcHBpbmcpIHsKPiArCQkJZG1jX29mZnNldCA9 IGZ3X2luZm9baV0ub2Zmc2V0Owo+ICsJCQlicmVhazsKPiArCQl9Cj4gKwo+ICsJCWlmIChmd19p bmZvW2ldLnN0ZXBwaW5nID09ICcqJyAmJgo+ICsJCSAgICBmd19pbmZvW2ldLnN1YnN0ZXBwaW5n ID09ICcqJykgewo+ICsJCQkvKgo+ICsJCQkgKiBJbiB0aGVvcnkgd2Ugc2hvdWxkIHN0b3AgdGhl IHNlYXJjaCBhcyBnZW5lcmljCj4gKwkJCSAqIGVudHJpZXMgc2hvdWxkIGFsd2FzIGNvbWUgYWZ0 ZXIgdGhlIG1vcmUgc3BlY2lmaWMKPiArCQkJICogb25lcywgYnV0IGxldCdzIGNvbnRpbnVlIHRv IG1ha2Ugc3VyZSB0byB3b3JrIGV2ZW4KPiArCQkJICogd2l0aCAiYnJva2VuIiBmaXJtd2FyZXMu IElmIHdlIGRvbid0IGZpbmQgYSBtb3JlCj4gKwkJCSAqIHNwZWNpZmljIG9uZSwgdGhlbiB3ZSB1 c2UgdGhpcyBlbnRyeQo+ICsJCQkgKi8KCmdvb2QgcG9pbnQuCgoKUmV2aWV3ZWQtYnk6IFJvZHJp Z28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KCgoKPiArCQkJZG1jX29mZnNldCA9IGZ3 X2luZm9baV0ub2Zmc2V0Owo+ICsJCX0KPiArCX0KPiArCj4gKwlyZXR1cm4gZG1jX29mZnNldDsK PiArfQo+ICsKPiAgc3RhdGljIHUzMiAqcGFyc2VfY3NyX2Z3KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiAgCQkJIGNvbnN0IHN0cnVjdCBmaXJtd2FyZSAqZncpCj4gIHsKPiBA QCAtMzAwLDcgKzMzOSw3IEBAIHN0YXRpYyB1MzIgKnBhcnNlX2Nzcl9mdyhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlzdHJ1Y3QgaW50ZWxfZG1jX2hlYWRlciAqZG1jX2hl YWRlcjsKPiAgCXN0cnVjdCBpbnRlbF9jc3IgKmNzciA9ICZkZXZfcHJpdi0+Y3NyOwo+ICAJY29u c3Qgc3RydWN0IHN0ZXBwaW5nX2luZm8gKnNpID0gaW50ZWxfZ2V0X3N0ZXBwaW5nX2luZm8oZGV2 X3ByaXYpOwo+IC0JdTMyIGRtY19vZmZzZXQgPSBDU1JfREVGQVVMVF9GV19PRkZTRVQsIHJlYWRj b3VudCA9IDAsIG5ieXRlczsKPiArCXUzMiBkbWNfb2Zmc2V0LCBudW1fZW50cmllcywgcmVhZGNv dW50ID0gMCwgbmJ5dGVzOwo+ICAJdTMyIGk7Cj4gIAl1MzIgKmRtY19wYXlsb2FkOwo+ICAKPiBA QCAtMzQyLDI3ICszODEsMjIgQEAgc3RhdGljIHUzMiAqcGFyc2VfY3NyX2Z3KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICAocGFja2FnZV9oZWFkZXItPmhlYWRlcl9s ZW4gKiA0KSk7Cj4gIAkJcmV0dXJuIE5VTEw7Cj4gIAl9Cj4gKwo+ICAJcmVhZGNvdW50ICs9IHNp emVvZihzdHJ1Y3QgaW50ZWxfcGFja2FnZV9oZWFkZXIpOwo+ICsJbnVtX2VudHJpZXMgPSBwYWNr YWdlX2hlYWRlci0+bnVtX2VudHJpZXM7Cj4gKwlpZiAoV0FSTl9PTihwYWNrYWdlX2hlYWRlci0+ bnVtX2VudHJpZXMgPiBQQUNLQUdFX01BWF9GV19JTkZPX0VOVFJJRVMpKQo+ICsJCW51bV9lbnRy aWVzID0gUEFDS0FHRV9NQVhfRldfSU5GT19FTlRSSUVTOwo+ICAKPiAtCS8qIFNlYXJjaCBmb3Ig ZG1jX29mZnNldCB0byBmaW5kIGZpcndhcmUgYmluYXJ5LiAqLwo+IC0JZm9yIChpID0gMDsgaSA8 IHBhY2thZ2VfaGVhZGVyLT5udW1fZW50cmllczsgaSsrKSB7Cj4gLQkJaWYgKHBhY2thZ2VfaGVh ZGVyLT5md19pbmZvW2ldLnN1YnN0ZXBwaW5nID09ICcqJyAmJgo+IC0JCSAgICBzaS0+c3RlcHBp bmcgPT0gcGFja2FnZV9oZWFkZXItPmZ3X2luZm9baV0uc3RlcHBpbmcpIHsKPiAtCQkJZG1jX29m ZnNldCA9IHBhY2thZ2VfaGVhZGVyLT5md19pbmZvW2ldLm9mZnNldDsKPiAtCQkJYnJlYWs7Cj4g LQkJfSBlbHNlIGlmIChzaS0+c3RlcHBpbmcgPT0gcGFja2FnZV9oZWFkZXItPmZ3X2luZm9baV0u c3RlcHBpbmcgJiYKPiAtCQkJICAgc2ktPnN1YnN0ZXBwaW5nID09IHBhY2thZ2VfaGVhZGVyLT5m d19pbmZvW2ldLnN1YnN0ZXBwaW5nKSB7Cj4gLQkJCWRtY19vZmZzZXQgPSBwYWNrYWdlX2hlYWRl ci0+ZndfaW5mb1tpXS5vZmZzZXQ7Cj4gLQkJCWJyZWFrOwo+IC0JCX0gZWxzZSBpZiAocGFja2Fn ZV9oZWFkZXItPmZ3X2luZm9baV0uc3RlcHBpbmcgPT0gJyonICYmCj4gLQkJCSAgIHBhY2thZ2Vf aGVhZGVyLT5md19pbmZvW2ldLnN1YnN0ZXBwaW5nID09ICcqJykKPiAtCQkJZG1jX29mZnNldCA9 IHBhY2thZ2VfaGVhZGVyLT5md19pbmZvW2ldLm9mZnNldDsKPiAtCX0KPiArCWRtY19vZmZzZXQg PSBmaW5kX2RtY19md19vZmZzZXQoKHN0cnVjdCBpbnRlbF9md19pbmZvICopCj4gKwkJCQkJJmZ3 LT5kYXRhW3JlYWRjb3VudF0sIG51bV9lbnRyaWVzLCBzaSk7Cj4gIAlpZiAoZG1jX29mZnNldCA9 PSBDU1JfREVGQVVMVF9GV19PRkZTRVQpIHsKPiAgCQlEUk1fRVJST1IoIkRNQyBmaXJtd2FyZSBu b3Qgc3VwcG9ydGVkIGZvciAlYyBzdGVwcGluZ1xuIiwKPiAgCQkJICBzaS0+c3RlcHBpbmcpOwo+ ICAJCXJldHVybiBOVUxMOwo+ICAJfQo+ICsJLyogd2UgYWx3YXlzIGhhdmUgc3BhY2UgZm9yIFBB Q0tBR0VfTUFYX0ZXX0lORk9fRU5UUklFUyAqLwo+ICsJcmVhZGNvdW50ICs9IFBBQ0tBR0VfTUFY X0ZXX0lORk9fRU5UUklFUyAqIHNpemVvZihzdHJ1Y3QgaW50ZWxfZndfaW5mbyk7Cj4gKwo+ICAJ LyogQ29udmVydCBkbWNfb2Zmc2V0IGludG8gbnVtYmVyIG9mIGJ5dGVzLiBCeSBkZWZhdWx0IGl0 IGlzIGluIGR3b3JkcyovCj4gIAlkbWNfb2Zmc2V0ICo9IDQ7Cj4gIAlyZWFkY291bnQgKz0gZG1j X29mZnNldDsKPiAtLSAKPiAyLjIxLjAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4