From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 14/33] staging/olpc: lock_fb_info can't fail Date: Mon, 27 May 2019 09:10:10 +0200 Message-ID: <20190527071010.GK21222@phenom.ffwll.local> References: <20190524085354.27411-1-daniel.vetter@ffwll.ch> <20190524085354.27411-15-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190524085354.27411-15-daniel.vetter@ffwll.ch> Sender: linux-kernel-owner@vger.kernel.org To: LKML , Greg KH Cc: Intel Graphics Development , DRI Development , Daniel Vetter , Jens Frederich , Daniel Drake , Jon Nettleton List-Id: intel-gfx@lists.freedesktop.org On Fri, May 24, 2019 at 10:53:35AM +0200, Daniel Vetter wrote: > Simply because olpc never unregisters the damn thing. It also > registers the framebuffer directly by poking around in fbdev > core internals, so it's all around rather broken. > > Signed-off-by: Daniel Vetter > Cc: Jens Frederich > Cc: Daniel Drake > Cc: Jon Nettleton Hi Greg, Somehow get_maintainers didn't pick you up for this. Ack for merging this through drm/fbdev? It's part of a bigger series to rework fbdev/fbcon interactions. Thanks, Daniel > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c > index 6b714f740ac3..a254238be181 100644 > --- a/drivers/staging/olpc_dcon/olpc_dcon.c > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c > @@ -250,11 +250,7 @@ static bool dcon_blank_fb(struct dcon_priv *dcon, bool blank) > int err; > > console_lock(); > - if (!lock_fb_info(dcon->fbinfo)) { > - console_unlock(); > - dev_err(&dcon->client->dev, "unable to lock framebuffer\n"); > - return false; > - } > + lock_fb_info(dcon->fbinfo); > > dcon->ignore_fb_events = true; > err = fb_blank(dcon->fbinfo, > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch