From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO Date: Mon, 27 May 2019 09:22:58 +0200 Message-ID: <20190527072258.GD7997@kroah.com> References: <20190524085354.27411-1-daniel.vetter@ffwll.ch> <20190524085354.27411-33-daniel.vetter@ffwll.ch> <20190527071126.GL21222@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190527071126.GL21222@phenom.ffwll.local> Sender: linux-kernel-owner@vger.kernel.org To: LKML , Intel Graphics Development , DRI Development , Daniel Vetter , Jens Frederich , Daniel Drake , Jon Nettleton List-Id: intel-gfx@lists.freedesktop.org On Mon, May 27, 2019 at 09:11:26AM +0200, Daniel Vetter wrote: > On Fri, May 24, 2019 at 10:53:53AM +0200, Daniel Vetter wrote: > > this driver is pretty horrible from a design pov, and needs a complete > > overhaul. Concrete thing that annoys me is that it looks at > > registered_fb, which is an internal thing to fbmem.c and fbcon.c. And > > ofc it gets the lifetime rules all wrong (it should at least use > > get/put_fb_info). > > > > Looking at the history, there's been an attempt at dropping this from > > staging in 2016, but that had to be reverted. Since then not real > > effort except the usual stream of trivial patches, and fbdev has been > > formally closed for any new hw support. Time to try again and drop > > this? > > > > Signed-off-by: Daniel Vetter > > Cc: Jens Frederich > > Cc: Daniel Drake > > Cc: Jon Nettleton > > Hi Greg > > Again get_mainatiners didn't pick you up on this somehow (I manually added > you now for the next round). Do you want to pick this up to staging, or > ack for merging through drm/fbdev as part of the larger fbdev/fbcon > rework? > > Also, I think time to retry and attempt at dropping this imo ... Acked-by: Greg Kroah-Hartman