Re: [PATCH 00/21] Implicit dev_priv removal

Tvrtko Ursulin
2019-06-06T10:35:31Z

On 06/06/2019 11:05, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-06 10:36:18)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Mostly patches reworking the code and GEM init paths to remove some implicit
>> dev_priv dependencies (I915_READ/I915_WRITE), plus some small tweaks to tidy
>> GEM init paths to use more logical input parameters (enabled by the conversion
>> to uncore mmio accessors).
>
> Passing intel_uncore to non intel_uncore functions during init, I
> disagree with as it makes the layering violations worse for no apparent
> gain.

For gem_init_hw it is questionable I agree.

Idea was that it logically makes sense to pass what is functionally
used. And for majority this seems to be uncore with i915 being used only
for "what gen am I" checks.

But I haven't converted the guc related bits, or the intel_engines_init
also doesn't fit. So yes, it's not super clean so I can drop that bit
for now.

Regards,

Tvrtko