From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 17/21] drm/i915: Consolidate some open coded mmio rmw Date: Thu, 6 Jun 2019 06:46:47 -0700 Message-ID: <20190606134647.GE3452@intel.com> References: <20190606093639.9372-1-tvrtko.ursulin@linux.intel.com> <20190606093639.9372-18-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38D9F892CF for ; Thu, 6 Jun 2019 13:46:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190606093639.9372-18-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMDYsIDIwMTkgYXQgMTA6MzY6MzVBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBSZXBsYWNlIHNvbWUgZ2VuNi83IG9wZW4gY29kZWQgcm13IHdpdGggaW50ZWxfdW5jb3Jl X3Jtdy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A aW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVs LmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgNDIg KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9ndHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0 dC5jCj4gaW5kZXggYjJjMmRjOTliZjhhLi5mZTljZDRlYTk2NzEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBAIC0xNjk3LDEzICsxNjk3LDEwIEBAIHN0YXRpYyB2b2lk IGdlbjdfcHBndHRfZW5hYmxlKHN0cnVjdCBpbnRlbF91bmNvcmUgKnVuY29yZSkKPiAgewo+ICAJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSB1bmNvcmVfdG9faTkxNSh1bmNvcmUpOwo+ ICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+IC0JdTMyIGVjb2NoaywgZWNvYml0 czsKPiAgCWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+ICsJdTMyIGVjb2NoazsKPiAgCj4gLQll Y29iaXRzID0gaW50ZWxfdW5jb3JlX3JlYWQodW5jb3JlLCBHQUNfRUNPX0JJVFMpOwo+IC0JaW50 ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiAtCQkJICAgR0FDX0VDT19CSVRTLAo+IC0JCQkgICBl Y29iaXRzIHwgRUNPQklUU19QUEdUVF9DQUNIRTY0Qik7Cj4gKwlpbnRlbF91bmNvcmVfcm13KHVu Y29yZSwgR0FDX0VDT19CSVRTLCAwLCBFQ09CSVRTX1BQR1RUX0NBQ0hFNjRCKTsKPiAgCj4gIAll Y29jaGsgPSBpbnRlbF91bmNvcmVfcmVhZCh1bmNvcmUsIEdBTV9FQ09DSEspOwo+ICAJaWYgKElT X0hBU1dFTEwoaTkxNSkpIHsKPiBAQCAtMTcyNCwyMiArMTcyMSwyMCBAQCBzdGF0aWMgdm9pZCBn ZW43X3BwZ3R0X2VuYWJsZShzdHJ1Y3QgaW50ZWxfdW5jb3JlICp1bmNvcmUpCj4gIAo+ICBzdGF0 aWMgdm9pZCBnZW42X3BwZ3R0X2VuYWJsZShzdHJ1Y3QgaW50ZWxfdW5jb3JlICp1bmNvcmUpCj4g IHsKPiAtCXUzMiBlY29jaGssIGdhYl9jdGwsIGVjb2JpdHM7Cj4gKwlpbnRlbF91bmNvcmVfcm13 KHVuY29yZSwKPiArCQkJIEdBQ19FQ09fQklUUywKPiArCQkJIDAsCj4gKwkJCSBFQ09CSVRTX1NO Ql9CSVQgfCBFQ09CSVRTX1BQR1RUX0NBQ0hFNjRCKTsKPiAgCj4gLQllY29iaXRzID0gaW50ZWxf dW5jb3JlX3JlYWQodW5jb3JlLCBHQUNfRUNPX0JJVFMpOwo+IC0JaW50ZWxfdW5jb3JlX3dyaXRl KHVuY29yZSwKPiAtCQkJICAgR0FDX0VDT19CSVRTLAo+IC0JCQkgICBlY29iaXRzIHwgRUNPQklU U19TTkJfQklUIHwgRUNPQklUU19QUEdUVF9DQUNIRTY0Qik7Cj4gKwlpbnRlbF91bmNvcmVfcm13 KHVuY29yZSwKPiArCQkJIEdBQl9DVEwsCj4gKwkJCSAwLAo+ICsJCQkgR0FCX0NUTF9DT05UX0FG VEVSX1BBR0VGQVVMVCk7Cj4gIAo+IC0JZ2FiX2N0bCA9IGludGVsX3VuY29yZV9yZWFkKHVuY29y ZSwgR0FCX0NUTCk7Cj4gLQlpbnRlbF91bmNvcmVfd3JpdGUodW5jb3JlLAo+IC0JCQkgICBHQUJf Q1RMLAo+IC0JCQkgICBnYWJfY3RsIHwgR0FCX0NUTF9DT05UX0FGVEVSX1BBR0VGQVVMVCk7Cj4g LQo+IC0JZWNvY2hrID0gaW50ZWxfdW5jb3JlX3JlYWQodW5jb3JlLCBHQU1fRUNPQ0hLKTsKPiAt CWludGVsX3VuY29yZV93cml0ZSh1bmNvcmUsCj4gLQkJCSAgIEdBTV9FQ09DSEssCj4gLQkJCSAg IGVjb2NoayB8IEVDT0NIS19TTkJfQklUIHwgRUNPQ0hLX1BQR1RUX0NBQ0hFNjRCKTsKPiArCWlu dGVsX3VuY29yZV9ybXcodW5jb3JlLAo+ICsJCQkgR0FNX0VDT0NISywKPiArCQkJIDAsCj4gKwkJ CSBFQ09DSEtfU05CX0JJVCB8IEVDT0NIS19QUEdUVF9DQUNIRTY0Qik7Cj4gIAo+ICAJaWYgKEhB U19QUEdUVCh1bmNvcmVfdG9faTkxNSh1bmNvcmUpKSkgLyogbWF5IGJlIGRpc2FibGVkIGZvciBW VC1kICovCj4gIAkJaW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiBAQCAtMjIzNCwxMSArMjIy OSwxMCBAQCBzdGF0aWMgdm9pZCBndHRfd3JpdGVfd29ya2Fyb3VuZHMoc3RydWN0IGludGVsX3Vu Y29yZSAqdW5jb3JlKQo+ICAJICovCj4gIAlpZiAoSEFTX1BBR0VfU0laRVMoaTkxNSwgSTkxNV9H VFRfUEFHRV9TSVpFXzY0SykgJiYKPiAgCSAgICBJTlRFTF9HRU4oaTkxNSkgPD0gMTApCj4gLQkJ aW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiAtCQkJCSAgIEdFTjhfR0FNV19FQ09fREVWX1JX X0lBLAo+IC0JCQkJICAgaW50ZWxfdW5jb3JlX3JlYWQodW5jb3JlLAo+IC0JCQkJCQkgICAgIEdF TjhfR0FNV19FQ09fREVWX1JXX0lBKSB8Cj4gLQkJCQkgICBHQU1XX0VDT19FTkFCTEVfNjRLX0lQ U19GSUVMRCk7Cj4gKwkJaW50ZWxfdW5jb3JlX3Jtdyh1bmNvcmUsCj4gKwkJCQkgR0VOOF9HQU1X X0VDT19ERVZfUldfSUEsCj4gKwkJCQkgMCwKPiArCQkJCSBHQU1XX0VDT19FTkFCTEVfNjRLX0lQ U19GSUVMRCk7Cj4gIH0KPiAgCj4gIGludCBpOTE1X3BwZ3R0X2luaXRfaHcoc3RydWN0IGludGVs X3VuY29yZSAqdW5jb3JlKQo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZng=