From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Drop pointless WARN_ON
Date: Fri, 7 Jun 2019 16:42:06 +0300 [thread overview]
Message-ID: <20190607134206.GZ5942@intel.com> (raw)
In-Reply-To: <20190604193646.GB7353@intel.com>
On Tue, Jun 04, 2019 at 12:36:46PM -0700, Manasi Navare wrote:
> On Tue, Jun 04, 2019 at 05:02:14PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > intel_dp_link_down() is static and it's only called from the pre-ddi
> > DP functions, so having a WARN_ON(HAS_DDI) in there is quite pointless.
> > Remove it.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Looks good to me,
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Thanks for the review. Series pushed to dinq.
>
> Manasi
>
> > ---
> > drivers/gpu/drm/i915/intel_dp.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 64fefc9af7a6..764e54fef5ee 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -3994,9 +3994,6 @@ intel_dp_link_down(struct intel_encoder *encoder,
> > enum port port = encoder->port;
> > u32 DP = intel_dp->DP;
> >
> > - if (WARN_ON(HAS_DDI(dev_priv)))
> > - return;
> > -
> > if (WARN_ON((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0))
> > return;
> >
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-07 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:02 [PATCH 1/2] drm/i915: Move intel_dp->prepare_link_train assignment into ddi code Ville Syrjala
2019-06-04 14:02 ` [PATCH 2/2] drm/i915: Drop pointless WARN_ON Ville Syrjala
2019-06-04 19:36 ` Manasi Navare
2019-06-07 13:42 ` Ville Syrjälä [this message]
2019-06-04 17:28 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move intel_dp->prepare_link_train assignment into ddi code Patchwork
2019-06-04 19:35 ` [PATCH 1/2] " Manasi Navare
2019-06-05 15:25 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607134206.GZ5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).