From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RESEND PATCH V3] drm/drm_vblank: Change EINVAL by the correct errno Date: Thu, 13 Jun 2019 10:21:47 +0200 Message-ID: <20190613082147.GG23020@phenom.ffwll.local> References: <20190613021054.cdewdb3azy6zuoyw@smtp.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190613021054.cdewdb3azy6zuoyw@smtp.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rodrigo Siqueira Cc: Maxime Ripard , kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Sean Paul List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdW4gMTIsIDIwMTkgYXQgMTE6MTA6NTRQTSAtMDMwMCwgUm9kcmlnbyBTaXF1ZWly YSB3cm90ZToKPiBGb3IgaGlzdG9yaWNhbCByZWFzb24sIHRoZSBmdW5jdGlvbiBkcm1fd2FpdF92 YmxhbmtfaW9jdGwgYWx3YXlzIHJldHVybgo+IC1FSU5WQUwgaWYgc29tZXRoaW5nIGdldHMgd3Jv bmcuIFRoaXMgc2NlbmFyaW8gbGltaXRzIHRoZSBmbGV4aWJpbGl0eQo+IGZvciB0aGUgdXNlcnNw YWNlIG1ha2UgZGV0YWlsZWQgdmVyaWZpY2F0aW9uIG9mIHRoZSBwcm9ibGVtIGFuZCB0YWtlCj4g c29tZSBhY3Rpb24uIEluIHBhcnRpY3VsYXIsIHRoZSB2YWxpZGF0aW9uIG9mIOKAnGlmICghZGV2 LT5pcnFfZW5hYmxlZCnigJ0KPiBpbiB0aGUgZHJtX3dhaXRfdmJsYW5rX2lvY3RsIGlzIHJlc3Bv bnNpYmxlIGZvciBjaGVja2luZyBpZiB0aGUgZHJpdmVyCj4gc3VwcG9ydCB2Ymxhbmsgb3Igbm90 LiBJZiB0aGUgZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgVkJsYW5rLCB0aGUKPiBmdW5jdGlvbiBk cm1fd2FpdF92YmxhbmtfaW9jdGwgcmV0dXJucyBFSU5WQUwgd2hpY2ggZG9lcyBub3QgcmVwcmVz ZW50Cj4gdGhlIHJlYWwgaXNzdWU7IHRoaXMgcGF0Y2ggY2hhbmdlcyB0aGlzIGJlaGF2aW9yIGJ5 IHJldHVybiBFT1BOT1RTVVBQLgo+IEFkZGl0aW9uYWxseSwgc29tZSBvcGVyYXRpb25zIGFyZSB1 bnN1cHBvcnRlZCBieSB0aGlzIGZ1bmN0aW9uLCBhbmQKPiByZXR1cm5zIEVJTlZBTDsgdGhpcyBw YXRjaCBhbHNvIGNoYW5nZXMgdGhlIHJldHVybiB2YWx1ZSB0byBFT1BOT1RTVVBQCj4gaW4gdGhp cyBjYXNlLiBMYXN0bHksIHRoZSBmdW5jdGlvbiBkcm1fd2FpdF92YmxhbmtfaW9jdGwgaXMgaW52 b2tlZCBieQo+IGxpYmRybSwgd2hpY2ggaXMgdXNlZCBieSBtYW55IGNvbXBvc2l0b3JzOyBiZWNh dXNlIG9mIHRoaXMsIGl0IGlzCj4gaW1wb3J0YW50IHRvIGNoZWNrIGlmIHRoaXMgY2hhbmdlIGJy ZWFrcyBhbnkgY29tcG9zaXRvci4gSW4gdGhpcyBzZW5zZSwKPiB0aGUgZm9sbG93aW5nIHByb2pl Y3RzIHdlcmUgZXhhbWluZWQ6Cj4gCj4gKiBEcm0taHdjb21wb3Nlcgo+ICogS3dpbgo+ICogU3dh eQo+ICogV2xyb290cwo+ICogV2F5bGFuZC1jb3JlCj4gKiBXZXN0b24KPiAqIFhvcmcgKDY3IGRp ZmZlcmVudCBkcml2ZXJzKQo+IAo+IEZvciBlYWNoIHJlcG9zaXRvcnkgdGhlIHZlcmlmaWNhdGlv biBoYXBwZW5lZCBpbiB0aHJlZSBzdGVwczoKPiAKPiAqIFVwZGF0ZSB0aGUgbWFpbiBicmFuY2gK PiAqIExvb2sgZm9yIGFueSBvY2N1cnJlbmNlICJkcm1XYWl0VkJsYW5rIiB3aXRoIHRoZSBjb21t YW5kOgo+ICAgZ2l0IGdyZXAgLW4gImRybVdhaXRWQmxhbmsiCj4gKiBMb29rIGluIHRoZSBnaXQg aGlzdG9yeSBvZiB0aGUgcHJvamVjdCB3aXRoIHRoZSBjb21tYW5kOgo+ICAgZ2l0IGxvZyAtU2Ry bVdhaXRWQmxhbmsKPiAKPiBGaW5hbGx5LCBub25lIG9mIHRoZSBhYm92ZSBwcm9qZWN0cyB2YWxp ZGF0ZSB0aGUgdXNlIG9mIEVJTlZBTCB3aGljaAo+IG1ha2Ugc2FmZSwgYXQgbGVhc3QgZm9yIHRo ZXNlIHByb2plY3RzLCB0byBjaGFuZ2UgdGhlIHJldHVybiB2YWx1ZXMuCj4gCj4gQ2hhbmdlIHNp bmNlIFYyOgo+ICBEYW5pZWwgVmV0dGVyIGFuZCBDaHJpcyBXaWxzb24KPiAgLSBSZXBsYWNlIEVO T1RUWSBieSBFT1BOT1RTVVBQCj4gIC0gUmV0dXJuIEVJTlZBTCBpZiB0aGUgcGFyYW1ldGVycyBh cmUgd3JvbmcKPiAKPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFNpcXVlaXJhIDxyb2RyaWdvc2lx dWVpcmFtZWxvQGdtYWlsLmNvbT4KPiAtLS0KPiBVcGRhdGU6Cj4gICBOb3cgSUdUIGhhcyBhIHdh eSB0byB2YWxpZGF0ZSBpZiBhIGRyaXZlciBoYXMgdmJsYW5rIHN1cHBvcnQgb3Igbm90Lgo+ICAg U2VlOiBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvZHJtL2lndC1ncHUtdG9vbHMvY29t bWl0LzJkMjQ0YWVkNjkxNjU3NTNmM2FkYmJkNjQ2OGRiMDczZGMxYWNmOUEKPiAKPiAgZHJpdmVy cy9ncHUvZHJtL2RybV92YmxhbmsuYyB8IDQgKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX3ZibGFuay5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV92YmxhbmsuYwo+IGluZGV4IDBk NzA0YmRkYjFhNi4uZDc2YTc4M2E3ZDRiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fdmJsYW5rLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ZibGFuay5jCj4gQEAgLTE1 NzgsMTAgKzE1NzgsMTAgQEAgaW50IGRybV93YWl0X3ZibGFua19pb2N0bChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJdW5zaWduZWQgaW50IGZsYWdzLCBwaXBlLCBoaWdo X3BpcGU7Cj4gIAo+ICAJaWYgKCFkZXYtPmlycV9lbmFibGVkKQo+IC0JCXJldHVybiAtRUlOVkFM Owo+ICsJCXJldHVybiAtRU9QTk9UU1VQUDsKPiAgCj4gIAlpZiAodmJsd2FpdC0+cmVxdWVzdC50 eXBlICYgX0RSTV9WQkxBTktfU0lHTkFMKQo+IC0JCXJldHVybiAtRUlOVkFMOwo+ICsJCXJldHVy biAtRU9QTk9UU1VQUDsKCk5vdCBzdXJlIHdlIHdhbnQgRUlOVkFMIGhlcmUsIHRoYXQncyBraW5k YSBhICJwYXJhbWV0ZXJzIGFyZSB3cm9uZyIKdmVyc2lvbiB0b28uIFdpdGggdGhhdCBjaGFuZ2Vk OgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+ ICAKPiAgCWlmICh2Ymx3YWl0LT5yZXF1ZXN0LnR5cGUgJgo+ICAJICAgIH4oX0RSTV9WQkxBTktf VFlQRVNfTUFTSyB8IF9EUk1fVkJMQU5LX0ZMQUdTX01BU0sgfAo+IC0tIAo+IDIuMjEuMAoKCgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs