Re: [RFC 06/28] drm/i915: Convert i915_gem_init_swizzling to intel_gt

Tvrtko Ursulin
2019-06-14T09:06:43Z

On 13/06/2019 14:49, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-13 14:35:17)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Start using the newly introduced struct intel_gt to fuse together correct
>> logical init flow with uncore for more removal of implicit dev_priv in
>> mmio access.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Looks fine, I might move it again later next to the fence registers, or
> at least pull this and the detection into its own intel_gt_swizzling.c
>
> Hmm, now that I said that, does that seem like a reasonable thing to do
> right away, see i915_gem_fence_regs.c for the swizzle probe?

Is swizzling global for the memory controller or applicable only for
fenced regions?

Regards,

Tvrtko