Re: [PATCH 4/4] drm/i915: Drop the _INCOMPLETE for has_infoframe

Imre Deak
2019-06-18T13:28:28Z

On Tue, Jun 18, 2019 at 03:55:53PM +0300, Ville Syrjälä wrote:
> On Tue, Jun 18, 2019 at 03:34:46PM +0300, Imre Deak wrote:
> > On Wed, Jun 12, 2019 at 04:08:01PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > We have full infoframe readout now so we can replace the
> > > PIPE_CONF_CHECK_BOOL_INCOMPLETE(has_infoframe) with the normal
> > > PIPE_CONF_CHECK_BOOL(has_infoframe).
> > >
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > Looks like has_audio has the readout too in place.
>
> I suppose audio is using INCOMPLETE due to lack of ELD readout?

Ah ok, so the computed has_audio state depending on ELD won't be
correct.

>
> >
> > > ---
> > > drivers/gpu/drm/i915/intel_display.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > > index ec3b7e825613..72fb04863acd 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -12570,7 +12570,7 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
> > >
> > > PIPE_CONF_CHECK_BOOL(hdmi_scrambling);
> > > PIPE_CONF_CHECK_BOOL(hdmi_high_tmds_clock_ratio);
> > > - PIPE_CONF_CHECK_BOOL_INCOMPLETE(has_infoframe);
> > > + PIPE_CONF_CHECK_BOOL(has_infoframe);
> > >
> > > PIPE_CONF_CHECK_BOOL_INCOMPLETE(has_audio);
> > >
> > > --
> > > 2.21.0
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel