From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [RFC 06/31] drm/i915: Convert i915_gem_init_swizzling to intel_gt Date: Fri, 14 Jun 2019 08:25:12 -0700 Message-ID: <20190614152512.GC19512@intel.com> References: <20190614151731.17608-1-tvrtko.ursulin@linux.intel.com> <20190614151731.17608-7-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDE4089B12 for ; Fri, 14 Jun 2019 15:24:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190614151731.17608-7-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMTQsIDIwMTkgYXQgMDQ6MTc6MDZQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBTdGFydCB1c2luZyB0aGUgbmV3bHkgaW50cm9kdWNlZCBzdHJ1Y3QgaW50ZWxfZ3QgdG8g ZnVzZSB0b2dldGhlciBjb3JyZWN0Cj4gbG9naWNhbCBpbml0IGZsb3cgd2l0aCB1bmNvcmUgZm9y IG1vcmUgcmVtb3ZhbCBvZiBpbXBsaWNpdCBkZXZfcHJpdiBpbgo+IG1taW8gYWNjZXNzLgo+IAo+ IHYyOgo+ICAqIE1vdmUgY29kZSB0byBpOTE1X2dlbV9mZW5jZV9yZWcuIChDaHJpcykKPiAKPiBT aWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAgICAgICAgICB8ICA0ICst LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgICB8ICAxIC0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgICAgfCAyNSArLS0tLS0tLS0t LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2VfcmVnLmMgfCAzNyAr KysrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9m ZW5jZV9yZWcuaCB8ICAzICsrCj4gIDUgZmlsZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwg MjcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggOTcxNTVj NWViN2UxLi4xZGY3NmY3YzcxN2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAt MjkzNSw3ICsyOTM1LDcgQEAgc3RhdGljIGludCBpbnRlbF9ydW50aW1lX3N1c3BlbmQoc3RydWN0 IGRldmljZSAqa2RldikKPiAgCj4gIAkJaW50ZWxfdWNfcmVzdW1lKGRldl9wcml2KTsKPiAgCj4g LQkJaTkxNV9nZW1faW5pdF9zd2l6emxpbmcoZGV2X3ByaXYpOwo+ICsJCWludGVsX2d0X2luaXRf c3dpenpsaW5nKCZkZXZfcHJpdi0+Z3QpOwo+ICAJCWk5MTVfZ2VtX3Jlc3RvcmVfZmVuY2VzKGRl dl9wcml2KTsKPiAgCj4gIAkJZW5hYmxlX3JwbV93YWtlcmVmX2Fzc2VydHMoZGV2X3ByaXYpOwo+ IEBAIC0zMDM2LDcgKzMwMzYsNyBAQCBzdGF0aWMgaW50IGludGVsX3J1bnRpbWVfcmVzdW1lKHN0 cnVjdCBkZXZpY2UgKmtkZXYpCj4gIAkgKiBObyBwb2ludCBvZiByb2xsaW5nIGJhY2sgdGhpbmdz IGluIGNhc2Ugb2YgYW4gZXJyb3IsIGFzIHRoZSBiZXN0Cj4gIAkgKiB3ZSBjYW4gZG8gaXMgdG8g aG9wZSB0aGF0IHRoaW5ncyB3aWxsIHN0aWxsIHdvcmsgKGFuZCBkaXNhYmxlIFJQTSkuCj4gIAkg Ki8KPiAtCWk5MTVfZ2VtX2luaXRfc3dpenpsaW5nKGRldl9wcml2KTsKPiArCWludGVsX2d0X2lu aXRfc3dpenpsaW5nKCZkZXZfcHJpdi0+Z3QpOwo+ICAJaTkxNV9nZW1fcmVzdG9yZV9mZW5jZXMo ZGV2X3ByaXYpOwo+ICAKPiAgCS8qCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZTJj ODgxM2M5MzU1Li4xZWIyMDNmZGVlNjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBA QCAtMjU4Niw3ICsyNTg2LDYgQEAgYm9vbCBpOTE1X2dlbV91bnNldF93ZWRnZWQoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgdm9pZCBpOTE1X2dlbV9pbml0X21taW8oc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpOwo+ICBpbnQgX19tdXN0X2NoZWNrIGk5MTVfZ2Vt X2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgaW50IF9fbXVzdF9j aGVjayBpOTE1X2dlbV9pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7 Cj4gLXZvaWQgaTkxNV9nZW1faW5pdF9zd2l6emxpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KTsKPiAgdm9pZCBpOTE1X2dlbV9maW5pX2h3KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgaTkxNV9nZW1fZmluaShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpOwo+ICBpbnQgaTkxNV9nZW1fd2FpdF9mb3JfaWRsZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXgg N2ZkZjI1MmY5MzIyLi41YzBkYjkzNDMxNWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK PiBAQCAtMTIwNSwyOSArMTIwNSw2IEBAIHZvaWQgaTkxNV9nZW1fc2FuaXRpemUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gIAltdXRleF91bmxvY2soJmk5MTUtPmRybS5zdHJ1Y3Rf bXV0ZXgpOwo+ICB9Cj4gIAo+IC12b2lkIGk5MTVfZ2VtX2luaXRfc3dpenpsaW5nKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtewo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJp dikgPCA1IHx8Cj4gLQkgICAgZGV2X3ByaXYtPm1tLmJpdF82X3N3aXp6bGVfeCA9PSBJOTE1X0JJ VF82X1NXSVpaTEVfTk9ORSkKPiAtCQlyZXR1cm47Cj4gLQo+IC0JSTkxNV9XUklURShESVNQX0FS Ql9DVEwsIEk5MTVfUkVBRChESVNQX0FSQl9DVEwpIHwKPiAtCQkJCSBESVNQX1RJTEVfU1VSRkFD RV9TV0laWkxJTkcpOwo+IC0KPiAtCWlmIChJU19HRU4oZGV2X3ByaXYsIDUpKQo+IC0JCXJldHVy bjsKPiAtCj4gLQlJOTE1X1dSSVRFKFRJTEVDVEwsIEk5MTVfUkVBRChUSUxFQ1RMKSB8IFRJTEVD VExfU1daQ1RMKTsKPiAtCWlmIChJU19HRU4oZGV2X3ByaXYsIDYpKQo+IC0JCUk5MTVfV1JJVEUo QVJCX01PREUsIF9NQVNLRURfQklUX0VOQUJMRShBUkJfTU9ERV9TV0laWkxFX1NOQikpOwo+IC0J ZWxzZSBpZiAoSVNfR0VOKGRldl9wcml2LCA3KSkKPiAtCQlJOTE1X1dSSVRFKEFSQl9NT0RFLCBf TUFTS0VEX0JJVF9FTkFCTEUoQVJCX01PREVfU1dJWlpMRV9JVkIpKTsKPiAtCWVsc2UgaWYgKElT X0dFTihkZXZfcHJpdiwgOCkpCj4gLQkJSTkxNV9XUklURShHQU1UQVJCTU9ERSwgX01BU0tFRF9C SVRfRU5BQkxFKEFSQl9NT0RFX1NXSVpaTEVfQkRXKSk7Cj4gLQllbHNlCj4gLQkJQlVHKCk7Cj4g LX0KPiAtCj4gIHN0YXRpYyB2b2lkIGluaXRfdW51c2VkX3Jpbmcoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCB1MzIgYmFzZSkKPiAgewo+ICAJSTkxNV9XUklURShSSU5HX0NUTChi YXNlKSwgMCk7Cj4gQEAgLTEyNzQsNyArMTI1MSw3IEBAIGludCBpOTE1X2dlbV9pbml0X2h3KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCS8qIC4uLmFuZCBkZXRlcm1pbmUg d2hldGhlciB0aGV5IGFyZSBzdGlja2luZy4gKi8KPiAgCWludGVsX2d0X3ZlcmlmeV93b3JrYXJv dW5kcyhkZXZfcHJpdiwgImluaXQiKTsKPiAgCj4gLQlpOTE1X2dlbV9pbml0X3N3aXp6bGluZyhk ZXZfcHJpdik7Cj4gKwlpbnRlbF9ndF9pbml0X3N3aXp6bGluZygmZGV2X3ByaXYtPmd0KTsKPiAg Cj4gIAkvKgo+ICAJICogQXQgbGVhc3QgODMwIGNhbiBsZWF2ZSBzb21lIG9mIHRoZSB1bnVzZWQg cmluZ3MKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2Vf cmVnLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9mZW5jZV9yZWcuYwo+IGluZGV4 IDFjOTQ2NjY3NmNhZi4uZmMyNjg1OTlhMGMzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2ZlbmNlX3JlZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZmVuY2VfcmVnLmMKPiBAQCAtODM0LDMgKzgzNCw0MCBAQCB2b2lkIGk5MTVfZ2d0 dF9pbml0X2ZlbmNlcyhzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0KQo+ICAKPiAgCWk5MTVfZ2VtX3Jl c3RvcmVfZmVuY2VzKGk5MTUpOwo+ICB9Cj4gKwo+ICt2b2lkIGludGVsX2d0X2luaXRfc3dpenps aW5nKHN0cnVjdCBpbnRlbF9ndCAqZ3QpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1ID0gZ3QtPmk5MTU7Cj4gKwlzdHJ1Y3QgaW50ZWxfdW5jb3JlICp1bmNvcmUgPSBndC0+ dW5jb3JlOwo+ICsKPiArCWlmIChJTlRFTF9HRU4oaTkxNSkgPCA1IHx8Cj4gKwkgICAgaTkxNS0+ bW0uYml0XzZfc3dpenpsZV94ID09IEk5MTVfQklUXzZfU1dJWlpMRV9OT05FKQo+ICsJCXJldHVy bjsKPiArCj4gKwlpbnRlbF91bmNvcmVfd3JpdGUodW5jb3JlLAo+ICsJCQkgICBESVNQX0FSQl9D VEwsCj4gKwkJCSAgIGludGVsX3VuY29yZV9yZWFkKHVuY29yZSwgRElTUF9BUkJfQ1RMKSB8Cj4g KwkJCSAgIERJU1BfVElMRV9TVVJGQUNFX1NXSVpaTElORyk7Cgpjb3VsZCB3ZSBjaGFuZ2UgdGhp cyB0byBpbnRlbF91bmNvcmVfcm13ID8KCj4gKwo+ICsJaWYgKElTX0dFTihpOTE1LCA1KSkKPiAr CQlyZXR1cm47Cj4gKwo+ICsJaW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiArCQkJICAgVElM RUNUTCwKPiArCQkJICAgaW50ZWxfdW5jb3JlX3JlYWQodW5jb3JlLCBUSUxFQ1RMKSB8IFRJTEVD VExfU1daQ1RMKTsKCmFuZCBoZXJlIGFzIHdlbGw/Cgo+ICsKPiArCWlmIChJU19HRU4oaTkxNSwg NikpCj4gKwkJaW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiArCQkJCSAgIEFSQl9NT0RFLAo+ ICsJCQkJICAgX01BU0tFRF9CSVRfRU5BQkxFKEFSQl9NT0RFX1NXSVpaTEVfU05CKSk7Cj4gKwll bHNlIGlmIChJU19HRU4oaTkxNSwgNykpCj4gKwkJaW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwK PiArCQkJCSAgIEFSQl9NT0RFLAo+ICsJCQkJICAgX01BU0tFRF9CSVRfRU5BQkxFKEFSQl9NT0RF X1NXSVpaTEVfSVZCKSk7Cj4gKwllbHNlIGlmIChJU19HRU4oaTkxNSwgOCkpCj4gKwkJaW50ZWxf dW5jb3JlX3dyaXRlKHVuY29yZSwKPiArCQkJCSAgIEdBTVRBUkJNT0RFLAo+ICsJCQkJICAgX01B U0tFRF9CSVRfRU5BQkxFKEFSQl9NT0RFX1NXSVpaTEVfQkRXKSk7Cj4gKwllbHNlCj4gKwkJTUlT U0lOR19DQVNFKElOVEVMX0dFTihpOTE1KSk7Cj4gK30KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2VfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9mZW5jZV9yZWcuaAo+IGluZGV4IGQyZGE5ODgyODE3OS4uMzdlNGYxMDRmN2MwIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2ZlbmNlX3JlZy5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZmVuY2VfcmVnLmgKPiBAQCAtMzIs NiArMzIsNyBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdDsKPiAgc3RydWN0IGRybV9pOTE1 X3ByaXZhdGU7Cj4gIHN0cnVjdCBpOTE1X2dndHQ7Cj4gIHN0cnVjdCBpOTE1X3ZtYTsKPiArc3Ry dWN0IGludGVsX2d0Owo+ICBzdHJ1Y3Qgc2dfdGFibGU7Cj4gIAo+ICAjZGVmaW5lIEk5NjVfRkVO Q0VfUEFHRSA0MDk2VUwKPiBAQCAtNjYsNCArNjcsNiBAQCB2b2lkIGk5MTVfZ2VtX29iamVjdF9z YXZlX2JpdF8xN19zd2l6emxlKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAo+ ICB2b2lkIGk5MTVfZ2d0dF9pbml0X2ZlbmNlcyhzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0KTsKPiAg Cj4gK3ZvaWQgaW50ZWxfZ3RfaW5pdF9zd2l6emxpbmcoc3RydWN0IGludGVsX2d0ICpndCk7Cj4g Kwo+ICAjZW5kaWYKPiAtLSAKPiAyLjIwLjEKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4