From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [RFC 13/31] drm/i915: Convert i915_gem_init_hw to
 intel_gt
Date: Fri, 14 Jun 2019 08:50:47 -0700
Message-ID: <20190614155047.GG19512@intel.com>
References: <20190614151731.17608-1-tvrtko.ursulin@linux.intel.com>
 <20190614151731.17608-14-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 25F52896A3
 for <Intel-gfx@lists.freedesktop.org>; Fri, 14 Jun 2019 15:50:17 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190614151731.17608-14-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBKdW4gMTQsIDIwMTkgYXQgMDQ6MTc6MTNQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g
d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K
PiAKPiBNb3JlIHJlbW92YWwgb2YgaW1wbGljaXQgZGV2X3ByaXYgZnJvbSB1c2luZyBvbGQgbW1p
byBhY2Nlc3NvcnMuCj4gCj4gQWN0dWFsbHkgdGhlIHRvcCBsZXZlbCBmdW5jdGlvbiByZW1haW5z
IGJ1dCBpcyBzcGxpdCBpbnRvIGEgcGFydCB3aGljaAo+IHdyaXRlcyB0byBpOTE1IGFuZCBwYXJ0
IHdoaWNoIG9wZXJhdGVzIG9uIGludGVsX2d0IGluIG9yZGVyIHRvIGluaXRpYWxpemUKPiB0aGUg
aGFyZHdhcmUuCj4gCj4gR3VDIGFuZCBlbmdpbmVzIGFyZSB0aGUgb25seSBvZGQgb25lcyBvdXQg
cmVtYWluaW5nLgoKd2UgY2FuIHRha2UgY2FyZSBvZiB0aGVtIGxhdGVyLCBidXQgc29vbiA6KQoK
PiAKPiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu
Y29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4K
Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCA2NiArKysrKysrKysr
KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMo
KyksIDI2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IGU1
NGNkMzA1MzRkYy4uYjZmNDUwZTc4MmU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4g
QEAgLTEyMzQsMjggKzEyMzQsMzIgQEAgc3RhdGljIHZvaWQgaW5pdF91bnVzZWRfcmluZ3Moc3Ry
dWN0IGludGVsX2d0ICpndCkKPiAgCX0KPiAgfQo+ICAKPiAtaW50IGk5MTVfZ2VtX2luaXRfaHco
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgaW50IGluaXRfaHco
c3RydWN0IGludGVsX2d0ICpndCkKPiAgewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5
MTUgPSBndC0+aTkxNTsKPiArCXN0cnVjdCBpbnRlbF91bmNvcmUgKnVuY29yZSA9IGd0LT51bmNv
cmU7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWRldl9wcml2LT5ndC5sYXN0X2luaXRfdGltZSA9IGt0
aW1lX2dldCgpOwo+ICsJZ3QtPmxhc3RfaW5pdF90aW1lID0ga3RpbWVfZ2V0KCk7Cj4gIAo+ICAJ
LyogRG91YmxlIGxheWVyIHNlY3VyaXR5IGJsYW5rZXQsIHNlZSBpOTE1X2dlbV9pbml0KCkgKi8K
PiAtCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KCZkZXZfcHJpdi0+dW5jb3JlLCBGT1JDRVdB
S0VfQUxMKTsKPiArCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KHVuY29yZSwgRk9SQ0VXQUtF
X0FMTCk7Cj4gIAo+IC0JaWYgKEhBU19FRFJBTShkZXZfcHJpdikgJiYgSU5URUxfR0VOKGRldl9w
cml2KSA8IDkpCj4gLQkJSTkxNV9XUklURShIU1dfSURJQ1IsIEk5MTVfUkVBRChIU1dfSURJQ1Ip
IHwgSURJSEFTSE1TSygweGYpKTsKPiArCWlmIChIQVNfRURSQU0oaTkxNSkgJiYgSU5URUxfR0VO
KGk5MTUpIDwgOSkKPiArCQlpbnRlbF91bmNvcmVfcm13KHVuY29yZSwgSFNXX0lESUNSLCAwLCBJ
RElIQVNITVNLKDB4ZikpOwo+ICAKPiAtCWlmIChJU19IQVNXRUxMKGRldl9wcml2KSkKPiAtCQlJ
OTE1X1dSSVRFKE1JX1BSRURJQ0FURV9SRVNVTFRfMiwgSVNfSFNXX0dUMyhkZXZfcHJpdikgPwo+
IC0JCQkgICBMT1dFUl9TTElDRV9FTkFCTEVEIDogTE9XRVJfU0xJQ0VfRElTQUJMRUQpOwo+ICsJ
aWYgKElTX0hBU1dFTEwoaTkxNSkpCj4gKwkJaW50ZWxfdW5jb3JlX3dyaXRlKHVuY29yZSwKPiAr
CQkJCSAgIE1JX1BSRURJQ0FURV9SRVNVTFRfMiwKPiArCQkJCSAgIElTX0hTV19HVDMoaTkxNSkg
Pwo+ICsJCQkJICAgTE9XRVJfU0xJQ0VfRU5BQkxFRCA6IExPV0VSX1NMSUNFX0RJU0FCTEVEKTsK
PiAgCj4gIAkvKiBBcHBseSB0aGUgR1Qgd29ya2Fyb3VuZHMuLi4gKi8KPiAtCWludGVsX2d0X2Fw
cGx5X3dvcmthcm91bmRzKCZkZXZfcHJpdi0+Z3QpOwo+ICsJaW50ZWxfZ3RfYXBwbHlfd29ya2Fy
b3VuZHMoZ3QpOwo+ICAJLyogLi4uYW5kIGRldGVybWluZSB3aGV0aGVyIHRoZXkgYXJlIHN0aWNr
aW5nLiAqLwo+IC0JaW50ZWxfZ3RfdmVyaWZ5X3dvcmthcm91bmRzKCZkZXZfcHJpdi0+Z3QsICJp
bml0Iik7Cj4gKwlpbnRlbF9ndF92ZXJpZnlfd29ya2Fyb3VuZHMoZ3QsICJpbml0Iik7Cj4gIAo+
IC0JaW50ZWxfZ3RfaW5pdF9zd2l6emxpbmcoJmRldl9wcml2LT5ndCk7Cj4gKwlpbnRlbF9ndF9p
bml0X3N3aXp6bGluZyhndCk7Cj4gIAo+ICAJLyoKPiAgCSAqIEF0IGxlYXN0IDgzMCBjYW4gbGVh
dmUgc29tZSBvZiB0aGUgdW51c2VkIHJpbmdzCj4gQEAgLTEyNjMsNDggKzEyNjcsNTggQEAgaW50
IGk5MTVfZ2VtX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJ
ICogd2lsbCBwcmV2ZW50IGMzIGVudHJ5LiBNYWtlcyBzdXJlIGFsbCB1bnVzZWQgcmluZ3MKPiAg
CSAqIGFyZSB0b3RhbGx5IGlkbGUuCj4gIAkgKi8KPiAtCWluaXRfdW51c2VkX3JpbmdzKCZkZXZf
cHJpdi0+Z3QpOwo+IC0KPiAtCUJVR19PTighZGV2X3ByaXYtPmtlcm5lbF9jb250ZXh0KTsKPiAt
CXJldCA9IGk5MTVfdGVybWluYWxseV93ZWRnZWQoZGV2X3ByaXYpOwo+IC0JaWYgKHJldCkKPiAt
CQlnb3RvIG91dDsKPiArCWluaXRfdW51c2VkX3JpbmdzKGd0KTsKPiAgCj4gLQlyZXQgPSBpOTE1
X3BwZ3R0X2luaXRfaHcoJmRldl9wcml2LT5ndCk7Cj4gKwlyZXQgPSBpOTE1X3BwZ3R0X2luaXRf
aHcoZ3QpOwo+ICAJaWYgKHJldCkgewo+ICAJCURSTV9FUlJPUigiRW5hYmxpbmcgUFBHVFQgZmFp
bGVkICglZClcbiIsIHJldCk7Cj4gIAkJZ290byBvdXQ7Cj4gIAl9Cj4gIAo+IC0JcmV0ID0gaW50
ZWxfd29wY21faW5pdF9odygmZGV2X3ByaXYtPndvcGNtKTsKPiArCXJldCA9IGludGVsX3dvcGNt
X2luaXRfaHcoJmk5MTUtPndvcGNtKTsKPiAgCWlmIChyZXQpIHsKPiAgCQlEUk1fRVJST1IoIkVu
YWJsaW5nIFdPUENNIGZhaWxlZCAoJWQpXG4iLCByZXQpOwo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+
ICAKPiAgCS8qIFdlIGNhbid0IGVuYWJsZSBjb250ZXh0cyB1bnRpbCBhbGwgZmlybXdhcmUgaXMg
bG9hZGVkICovCj4gLQlyZXQgPSBpbnRlbF91Y19pbml0X2h3KGRldl9wcml2KTsKPiArCXJldCA9
IGludGVsX3VjX2luaXRfaHcoaTkxNSk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJRFJNX0VSUk9SKCJF
bmFibGluZyB1YyBmYWlsZWQgKCVkKVxuIiwgcmV0KTsKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAg
Cj4gLQlpbnRlbF9tb2NzX2luaXRfbDNjY190YWJsZSgmZGV2X3ByaXYtPmd0KTsKPiArCWludGVs
X21vY3NfaW5pdF9sM2NjX3RhYmxlKGd0KTsKPiAgCj4gIAkvKiBPbmx5IHdoZW4gdGhlIEhXIGlz
IHJlLWluaXRpYWxpc2VkLCBjYW4gd2UgcmVwbGF5IHRoZSByZXF1ZXN0cyAqLwo+IC0JcmV0ID0g
aW50ZWxfZW5naW5lc19yZXN1bWUoZGV2X3ByaXYpOwo+ICsJcmV0ID0gaW50ZWxfZW5naW5lc19y
ZXN1bWUoaTkxNSk7Cj4gIAlpZiAocmV0KQo+ICAJCWdvdG8gY2xlYW51cF91YzsKPiAgCj4gLQlp
bnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dCgmZGV2X3ByaXYtPnVuY29yZSwgRk9SQ0VXQUtFX0FM
TCk7Cj4gKwlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dCh1bmNvcmUsIEZPUkNFV0FLRV9BTEwp
Owo+ICAKPiAtCWludGVsX2VuZ2luZXNfc2V0X3NjaGVkdWxlcl9jYXBzKGRldl9wcml2KTsKPiAg
CXJldHVybiAwOwo+ICAKPiAgY2xlYW51cF91YzoKPiAtCWludGVsX3VjX2ZpbmlfaHcoZGV2X3By
aXYpOwo+ICsJaW50ZWxfdWNfZmluaV9odyhpOTE1KTsKPiAgb3V0Ogo+IC0JaW50ZWxfdW5jb3Jl
X2ZvcmNld2FrZV9wdXQoJmRldl9wcml2LT51bmNvcmUsIEZPUkNFV0FLRV9BTEwpOwo+ICsJaW50
ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQodW5jb3JlLCBGT1JDRVdBS0VfQUxMKTsKPiArCj4gKwly
ZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICtpbnQgaTkxNV9nZW1faW5pdF9odyhzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqaTkxNSkKPiArewo+ICsJaW50IHJldDsKPiArCj4gKwlCVUdfT04oIWk5MTUt
Pmtlcm5lbF9jb250ZXh0KTsKPiArCXJldCA9IGk5MTVfdGVybWluYWxseV93ZWRnZWQoaTkxNSk7
Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJcmV0ID0gaW5pdF9odygmaTkx
NS0+Z3QpOwo+ICsKPiArCWludGVsX2VuZ2luZXNfc2V0X3NjaGVkdWxlcl9jYXBzKGk5MTUpOwo+
ICAKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAtLSAKPiAyLjIwLjEKPiAKX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au
b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4