Re: [RFC 25/31] drm/i915: Compartmentalize i915_gem_init_ggtt

Tvrtko Ursulin
2019-06-14T16:38:49Z

On 14/06/2019 17:32, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-14 16:17:25)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Continuing on the theme of better logical organization of our code, make
>> the first step towards making the ggtt code better isolated from wider
>> struct drm_i915_private.
>>
>> v2:
>> * Bring the ickle onion unwind back. (Chris)
>> * Rename to i915_init_ggtt. (Chris)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> But not passing gt? Or is that still waiting on moving ggtt and
> aliasing_ppgtt?

Yes, init_aliasing_ppgtt stores to i915->mm.aliasing_ppgtt. But at least
this extracts out init_ggtt which operates on ggtt only.

Regards,

Tvrtko