Re: [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

james qian wang (Arm Technology China)
2019-06-17T06:26:08Z

On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:
> Read the docs, komeda is not an old enough driver for this :-)
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> index 0c6396dc323f..b9d699cc7bbf 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data)
> }
>
> static struct drm_driver komeda_kms_driver = {
> - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC |
> - DRIVER_HAVE_IRQ,
> + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .lastclose = drm_fb_helper_lastclose,
> .irq_handler = komeda_kms_irq_handler,

Hi Daniel:

Thank you for the patch.

And Ayan also sent two patches for this topic. like:

For drop drm_irq_install:
https://patchwork.freedesktop.org/series/61763/
For manually set drm->irq_enabled:
https://patchwork.freedesktop.org/series/61776/

For clear, seems we'd better squash all these three patches into one
single patch.

Hi Ayan:
Could you help the squash all these patches to a single one.

Thanks
James

> .gem_free_object_unlocked = drm_gem_cma_free_object,
> --
> 2.20.1