Re: [PATCH 32/59] drm/tve2000: Drop drm_gem_prime_export/import

Daniel Vetter
2019-06-15T09:14:50Z

On Sat, Jun 15, 2019 at 10:35 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> > They're the default.
> >
> > Aside: Would be really nice to switch the others over to
> > drm_gem_object_funcs.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> When you write "Would be really nice to switch the others over to
> drm_gem_object_funcs." are you referring to the other
> drm driver function called by this one driver, or are you
> referring to other drivers not using these functions?
>
> If the former and if there is some nice upstream commit
> I should be looking at for inspiration I can take a stab at
> fixing this driver.

There's a pile of callbacks in drm_driver around gem object handling
which we want to move over to drm_gem_object_funcs. Patch 2 in this
series here has a pretty big doc update. The hooks have exactly the
same function signature (at least after this series) and semantics,
just stored somewhere else. For the drivers using helpers this should
amount to just creating an export default function table for
drm_gem_object_funcs and using it everywhere.

Aside: In general the chaotic pile of hooks in struct drm_driver is
largely deprecated. There's a few things where we don't yet have more
focused vtables.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch