Re: [PATCH 07/59] drm/arm/komeda: Remove DRIVER_HAVE_IRQ

Daniel Vetter
2019-06-17T13:43:45Z

On Mon, Jun 17, 2019 at 06:26:08AM +0000, james qian wang (Arm Technology China) wrote:
> On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:
> > Read the docs, komeda is not an old enough driver for this :-)
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
> > Cc: Liviu Dudau <liviu.dudau@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > index 0c6396dc323f..b9d699cc7bbf 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > @@ -55,8 +55,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data)
> > }
> >
> > static struct drm_driver komeda_kms_driver = {
> > - .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC |
> > - DRIVER_HAVE_IRQ,
> > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> > .lastclose = drm_fb_helper_lastclose,
> > .irq_handler = komeda_kms_irq_handler,
>
> Hi Daniel:
>
> Thank you for the patch.
>
> And Ayan also sent two patches for this topic. like:
>
> For drop drm_irq_install:
> https://patchwork.freedesktop.org/series/61763/
> For manually set drm->irq_enabled:
> https://patchwork.freedesktop.org/series/61776/
>
> For clear, seems we'd better squash all these three patches into one
> single patch.

Not sure how these other patches are related to mine directly. This here
just removes a flag which does nothing, because komeda is not a legacy
driver. And ack for merging right away would be nice.

Thanks, Daniel

>
> Hi Ayan:
> Could you help the squash all these patches to a single one.
>
> Thanks
> James
>
> > .gem_free_object_unlocked = drm_gem_cma_free_object,
> > --
> > 2.20.1

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org