From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH 2/4] drm/i915: Constify
 intel_pipe_config_compare()
Date: Tue, 18 Jun 2019 15:25:27 +0300
Message-ID: <20190618122527.GC3733@ideak-desk.fi.intel.com>
References: <20190612130801.2085-1-ville.syrjala@linux.intel.com>
 <20190612130801.2085-2-ville.syrjala@linux.intel.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id BEF5B6E157
 for <intel-gfx@lists.freedesktop.org>; Tue, 18 Jun 2019 12:25:29 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190612130801.2085-2-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBKdW4gMTIsIDIwMTkgYXQgMDQ6MDc6NTlQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IE5vdyB0aGF0IGludGVsX3BpcGVfY29uZmlnX2NvbXBhcmUoKSBubyBsb25nZXIg
Y2xvYmJlcnMgdGhlIHBhc3NlZAo+IGluIHN0YXRlIHdlIGNhbiBtYWtlIGJvdGggY3J0YyBzdGF0
ZXMgY29uc3QuIEFuZCB3aGlsZSBhdCB3ZSBzaW1wbGlmeQo+IHRoZSBjYWxsaW5nIGNvbnZlbnRp
b24sIGFuZCBjbGVhbiB1cCBpbnRlbF9jb21wYXJlX2xpbmtfbV9uKCkgYSBiaXQuCj4gCj4gU2ln
bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv
bT4KClJldmlld2VkLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cgo+IC0tLQo+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0MyArKysrKysrKysrKy0t
LS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyNiBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXgg
NzNiM2U5MmI3ZWQ1Li5kY2MzMDFkZjYxNzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jCj4gQEAgLTEyMjkxLDE4ICsxMjI5MSwxNCBAQCBpbnRlbF9jb21wYXJlX21fbih1
bnNpZ25lZCBpbnQgbSwgdW5zaWduZWQgaW50IG4sCj4gIAo+ICBzdGF0aWMgYm9vbAo+ICBpbnRl
bF9jb21wYXJlX2xpbmtfbV9uKGNvbnN0IHN0cnVjdCBpbnRlbF9saW5rX21fbiAqbV9uLAo+IC0J
CSAgICAgICBzdHJ1Y3QgaW50ZWxfbGlua19tX24gKm0yX24yLAo+IC0JCSAgICAgICBib29sIGFk
anVzdCkKPiAtewo+IC0JaWYgKG1fbi0+dHUgPT0gbTJfbjItPnR1ICYmCj4gLQkgICAgaW50ZWxf
Y29tcGFyZV9tX24obV9uLT5nbWNoX20sIG1fbi0+Z21jaF9uLAo+IC0JCQkgICAgICBtMl9uMi0+
Z21jaF9tLCBtMl9uMi0+Z21jaF9uLCAhYWRqdXN0KSAmJgo+IC0JICAgIGludGVsX2NvbXBhcmVf
bV9uKG1fbi0+bGlua19tLCBtX24tPmxpbmtfbiwKPiAtCQkJICAgICAgbTJfbjItPmxpbmtfbSwg
bTJfbjItPmxpbmtfbiwgIWFkanVzdCkpIHsKPiAtCQlyZXR1cm4gdHJ1ZTsKPiAtCX0KPiAtCj4g
LQlyZXR1cm4gZmFsc2U7Cj4gKwkJICAgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9saW5rX21fbiAq
bTJfbjIsCj4gKwkJICAgICAgIGJvb2wgZXhhY3QpCj4gK3sKPiArCXJldHVybiBtX24tPnR1ID09
IG0yX24yLT50dSAmJgo+ICsJCWludGVsX2NvbXBhcmVfbV9uKG1fbi0+Z21jaF9tLCBtX24tPmdt
Y2hfbiwKPiArCQkJCSAgbTJfbjItPmdtY2hfbSwgbTJfbjItPmdtY2hfbiwgZXhhY3QpICYmCj4g
KwkJaW50ZWxfY29tcGFyZV9tX24obV9uLT5saW5rX20sIG1fbi0+bGlua19uLAo+ICsJCQkJICBt
Ml9uMi0+bGlua19tLCBtMl9uMi0+bGlua19uLCBleGFjdCk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBi
b29sCj4gQEAgLTEyMzcyLDExICsxMjM2OCwxMSBAQCBzdGF0aWMgYm9vbCBmYXN0Ym9vdF9lbmFi
bGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgfQo+ICAKPiAgc3RhdGlj
IGJvb2wKPiAtaW50ZWxfcGlwZV9jb25maWdfY29tcGFyZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYsCj4gLQkJCSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmN1cnJlbnRfY29u
ZmlnLAo+IC0JCQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAraW50
ZWxfcGlwZV9jb25maWdfY29tcGFyZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3Vy
cmVudF9jb25maWcsCj4gKwkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVf
Y29uZmlnLAo+ICAJCQkgIGJvb2wgYWRqdXN0KQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGN1cnJlbnRfY29uZmlnLT5iYXNlLmNydGMtPmRldik7
Cj4gIAlib29sIHJldCA9IHRydWU7Cj4gIAlib29sIGZpeHVwX2luaGVyaXRlZCA9IGFkanVzdCAm
Jgo+ICAJCShjdXJyZW50X2NvbmZpZy0+YmFzZS5tb2RlLnByaXZhdGVfZmxhZ3MgJiBJOTE1X01P
REVfRkxBR19JTkhFUklURUQpICYmCj4gQEAgLTEyNDQ3LDcgKzEyNDQzLDcgQEAgaW50ZWxfcGlw
ZV9jb25maWdfY29tcGFyZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICNk
ZWZpbmUgUElQRV9DT05GX0NIRUNLX01fTihuYW1lKSBkbyB7IFwKPiAgCWlmICghaW50ZWxfY29t
cGFyZV9saW5rX21fbigmY3VycmVudF9jb25maWctPm5hbWUsIFwKPiAgCQkJCSAgICAmcGlwZV9j
b25maWctPm5hbWUsXAo+IC0JCQkJICAgIGFkanVzdCkpIHsgXAo+ICsJCQkJICAgICFhZGp1c3Qp
KSB7IFwKPiAgCQlwaXBlX2NvbmZpZ19lcnIoYWRqdXN0LCBfX3N0cmluZ2lmeShuYW1lKSwgXAo+
ICAJCQkgICIoZXhwZWN0ZWQgdHUgJWkgZ21jaCAlaS8laSBsaW5rICVpLyVpLCAiIFwKPiAgCQkJ
ICAiZm91bmQgdHUgJWksIGdtY2ggJWkvJWkgbGluayAlaS8laSlcbiIsIFwKPiBAQCAtMTI0NzIs
OSArMTI0NjgsOSBAQCBpbnRlbF9waXBlX2NvbmZpZ19jb21wYXJlKHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiwKPiAgICovCj4gICNkZWZpbmUgUElQRV9DT05GX0NIRUNLX01fTl9B
TFQobmFtZSwgYWx0X25hbWUpIGRvIHsgXAo+ICAJaWYgKCFpbnRlbF9jb21wYXJlX2xpbmtfbV9u
KCZjdXJyZW50X2NvbmZpZy0+bmFtZSwgXAo+IC0JCQkJICAgICZwaXBlX2NvbmZpZy0+bmFtZSwg
YWRqdXN0KSAmJiBcCj4gKwkJCQkgICAgJnBpcGVfY29uZmlnLT5uYW1lLCAhYWRqdXN0KSAmJiBc
Cj4gIAkgICAgIWludGVsX2NvbXBhcmVfbGlua19tX24oJmN1cnJlbnRfY29uZmlnLT5hbHRfbmFt
ZSwgXAo+IC0JCQkJICAgICZwaXBlX2NvbmZpZy0+bmFtZSwgYWRqdXN0KSkgeyBcCj4gKwkJCQkg
ICAgJnBpcGVfY29uZmlnLT5uYW1lLCAhYWRqdXN0KSkgeyBcCj4gIAkJcGlwZV9jb25maWdfZXJy
KGFkanVzdCwgX19zdHJpbmdpZnkobmFtZSksIFwKPiAgCQkJICAiKGV4cGVjdGVkIHR1ICVpIGdt
Y2ggJWkvJWkgbGluayAlaS8laSwgIiBcCj4gIAkJCSAgIm9yIHR1ICVpIGdtY2ggJWkvJWkgbGlu
ayAlaS8laSwgIiBcCj4gQEAgLTEyOTg0LDggKzEyOTgwLDcgQEAgdmVyaWZ5X2NydGNfc3RhdGUo
c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJaW50ZWxfcGlwZV9jb25maWdfc2FuaXR5X2NoZWNr
KGRldl9wcml2LCBwaXBlX2NvbmZpZyk7Cj4gIAo+ICAJc3dfY29uZmlnID0gdG9faW50ZWxfY3J0
Y19zdGF0ZShuZXdfY3J0Y19zdGF0ZSk7Cj4gLQlpZiAoIWludGVsX3BpcGVfY29uZmlnX2NvbXBh
cmUoZGV2X3ByaXYsIHN3X2NvbmZpZywKPiAtCQkJCSAgICAgICBwaXBlX2NvbmZpZywgZmFsc2Up
KSB7Cj4gKwlpZiAoIWludGVsX3BpcGVfY29uZmlnX2NvbXBhcmUoc3dfY29uZmlnLCBwaXBlX2Nv
bmZpZywgZmFsc2UpKSB7Cj4gIAkJSTkxNV9TVEFURV9XQVJOKDEsICJwaXBlIHN0YXRlIGRvZXNu
J3QgbWF0Y2ghXG4iKTsKPiAgCQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHBpcGVfY29uZmlnLCBO
VUxMLCAiW2h3IHN0YXRlXSIpOwo+ICAJCWludGVsX2R1bXBfcGlwZV9jb25maWcoc3dfY29uZmln
LCBOVUxMLCAiW3N3IHN0YXRlXSIpOwo+IEBAIC0xMzQzMCwxNCArMTM0MjUsMTAgQEAgc3RhdGlj
IGludCBjYWxjX3dhdGVybWFya19kYXRhKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRl
KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGludGVsX2NydGNfY2hlY2tf
ZmFzdHNldChzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4gK3N0YXRp
YyB2b2lkIGludGVsX2NydGNfY2hlY2tfZmFzdHNldChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z
dGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4gIAkJCQkgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl
ICpuZXdfY3J0Y19zdGF0ZSkKPiAgewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2ID0KPiAtCQl0b19pOTE1KG5ld19jcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gLQo+
IC0JaWYgKCFpbnRlbF9waXBlX2NvbmZpZ19jb21wYXJlKGRldl9wcml2LCBvbGRfY3J0Y19zdGF0
ZSwKPiAtCQkJCSAgICAgICBuZXdfY3J0Y19zdGF0ZSwgdHJ1ZSkpCj4gKwlpZiAoIWludGVsX3Bp
cGVfY29uZmlnX2NvbXBhcmUob2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlLCB0cnVlKSkK
PiAgCQlyZXR1cm47Cj4gIAo+ICAJbmV3X2NydGNfc3RhdGUtPmJhc2UubW9kZV9jaGFuZ2VkID0g
ZmFsc2U7Cj4gLS0gCj4gMi4yMS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp
c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk
ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2ludGVsLWdmeA==