From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Nuke drm_driver irq vfuncs Date: Tue, 18 Jun 2019 18:26:49 +0300 Message-ID: <20190618152649.GP5942@intel.com> References: <20190618142108.9978-1-ville.syrjala@linux.intel.com> <20190618142108.9978-3-ville.syrjala@linux.intel.com> <156086964155.31375.16801855183444485115@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F21B89346 for ; Tue, 18 Jun 2019 15:26:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <156086964155.31375.16801855183444485115@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDM6NTQ6MDFQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOS0wNi0xOCAxNToyMTowNykKPiBbc25p cCBtZWNoYW5pY2FsIGNoYW5nZXNdCj4gCj4gPiBAQCAtNDgzOSw2NSArNDc5MiwxOCBAQCB2b2lk IGludGVsX2lycV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAg ICAgICAgZGV2LT5kcml2ZXItPmdldF92YmxhbmtfdGltZXN0YW1wID0gZHJtX2NhbGNfdmJsdGlt ZXN0YW1wX2Zyb21fc2Nhbm91dHBvczsKPiA+ICAgICAgICAgZGV2LT5kcml2ZXItPmdldF9zY2Fu b3V0X3Bvc2l0aW9uID0gaTkxNV9nZXRfY3J0Y19zY2Fub3V0cG9zOwo+ID4gIAo+ID4gLSAgICAg ICBpZiAoSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPiA+IC0gICAgICAgICAgICAgICBkZXYt PmRyaXZlci0+aXJxX2hhbmRsZXIgPSBjaGVycnl2aWV3X2lycV9oYW5kbGVyOwo+ID4gLSAgICAg ICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfcHJlaW5zdGFsbCA9IGNoZXJyeXZpZXdfaXJxX3Jl c2V0Owo+ID4gLSAgICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfcG9zdGluc3RhbGwgPSBj aGVycnl2aWV3X2lycV9wb3N0aW5zdGFsbDsKPiA+IC0gICAgICAgICAgICAgICBkZXYtPmRyaXZl ci0+aXJxX3VuaW5zdGFsbCA9IGNoZXJyeXZpZXdfaXJxX3Jlc2V0Owo+ID4gLSAgICAgICAgICAg ICAgIGRldl9wcml2LT5kaXNwbGF5LmhwZF9pcnFfc2V0dXAgPSBpOTE1X2hwZF9pcnFfc2V0dXA7 Cj4gPiAtICAgICAgIH0gZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikpIHsKPiA+IC0g ICAgICAgICAgICAgICBkZXYtPmRyaXZlci0+aXJxX2hhbmRsZXIgPSB2YWxsZXl2aWV3X2lycV9o YW5kbGVyOwo+ID4gLSAgICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfcHJlaW5zdGFsbCA9 IHZhbGxleXZpZXdfaXJxX3Jlc2V0Owo+ID4gLSAgICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5p cnFfcG9zdGluc3RhbGwgPSB2YWxsZXl2aWV3X2lycV9wb3N0aW5zdGFsbDsKPiA+IC0gICAgICAg ICAgICAgICBkZXYtPmRyaXZlci0+aXJxX3VuaW5zdGFsbCA9IHZhbGxleXZpZXdfaXJxX3Jlc2V0 Owo+ID4gLSAgICAgICAgICAgICAgIGRldl9wcml2LT5kaXNwbGF5LmhwZF9pcnFfc2V0dXAgPSBp OTE1X2hwZF9pcnFfc2V0dXA7Cj4gPiAtICAgICAgIH0gZWxzZSBpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSAxMSkgewo+ID4gLSAgICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfaGFuZGxl ciA9IGdlbjExX2lycV9oYW5kbGVyOwo+ID4gLSAgICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5p cnFfcHJlaW5zdGFsbCA9IGdlbjExX2lycV9yZXNldDsKPiA+IC0gICAgICAgICAgICAgICBkZXYt PmRyaXZlci0+aXJxX3Bvc3RpbnN0YWxsID0gZ2VuMTFfaXJxX3Bvc3RpbnN0YWxsOwo+ID4gLSAg ICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfdW5pbnN0YWxsID0gZ2VuMTFfaXJxX3Jlc2V0 Owo+ID4gLSAgICAgICAgICAgICAgIGRldl9wcml2LT5kaXNwbGF5LmhwZF9pcnFfc2V0dXAgPSBn ZW4xMV9ocGRfaXJxX3NldHVwOwo+ID4gLSAgICAgICB9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPj0gOCkgewo+ID4gLSAgICAgICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfaGFuZGxl ciA9IGdlbjhfaXJxX2hhbmRsZXI7Cj4gPiAtICAgICAgICAgICAgICAgZGV2LT5kcml2ZXItPmly cV9wcmVpbnN0YWxsID0gZ2VuOF9pcnFfcmVzZXQ7Cj4gPiAtICAgICAgICAgICAgICAgZGV2LT5k cml2ZXItPmlycV9wb3N0aW5zdGFsbCA9IGdlbjhfaXJxX3Bvc3RpbnN0YWxsOwo+ID4gLSAgICAg ICAgICAgICAgIGRldi0+ZHJpdmVyLT5pcnFfdW5pbnN0YWxsID0gZ2VuOF9pcnFfcmVzZXQ7Cj4g PiAtICAgICAgICAgICAgICAgaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ID4gKyAgICAgICBp ZiAoSEFTX0dNQ0goZGV2X3ByaXYpKSB7Cj4gPiArICAgICAgICAgICAgICAgaWYgKEk5MTVfSEFT X0hPVFBMVUcoZGV2X3ByaXYpKQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZGV2X3ByaXYt PmRpc3BsYXkuaHBkX2lycV9zZXR1cCA9IGk5MTVfaHBkX2lycV9zZXR1cDsKPiAKPiBJbmNsdWRl cyBjaHYvdmx2Lgo+IAo+ID4gKyAgICAgICB9IGVsc2Ugewo+ID4gKyAgICAgICAgICAgICAgIGlm IChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ZGV2X3ByaXYtPmRpc3BsYXkuaHBkX2lycV9zZXR1cCA9IGdlbjExX2hwZF9pcnFfc2V0dXA7Cj4g Cj4gT2suCj4gCj4gPiArICAgICAgICAgICAgICAgZWxzZSBpZiAoSVNfR0VOOV9MUChkZXZfcHJp dikpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBkZXZfcHJpdi0+ZGlzcGxheS5ocGRfaXJx X3NldHVwID0gYnh0X2hwZF9pcnFfc2V0dXA7Cj4gPiAgICAgICAgICAgICAgICAgZWxzZSBpZiAo SU5URUxfUENIX1RZUEUoZGV2X3ByaXYpID49IFBDSF9TUFQpCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICBkZXZfcHJpdi0+ZGlzcGxheS5ocGRfaXJxX3NldHVwID0gc3B0X2hwZF9pcnFfc2V0 dXA7Cj4gCj4gQXMgYmVmb3JlLgo+IAo+ID4gICAgICAgICAgICAgICAgIGVsc2UKPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgIGRldl9wcml2LT5kaXNwbGF5LmhwZF9pcnFfc2V0dXAgPSBpbGtf aHBkX2lycV9zZXR1cDsKPiAKPiBUaGUgcmVzdCBvZiAhR01DSC4KPiAKPiBDb2RlIGJlIG9uZSBs ZXZlbCBpZi1jaGFpbiB0aG91Z2guCgoiY291bGQgYmUgLi4uIj8gU3VyZS4gTm90IGVudGlyZWx5 IHN1cmUgSSdkIGJlIGFibGUgdG8gZm9sbG93IGl0IHRob3VnaC4KSSBndWVzcyBqdXN0IGZsYXR0 ZW5pbmcgaXQgYW5kIGNoZWNraW5nIGZvciBIQVNfUENIX1NQTElUKCkgZm9yIGlsaysKY291bGQg YmUgYSByZWFzb25hYmx5IG5vbi1jb25mdXNpbmcgd2F5IHRvIHdyaXRlIGl0LiBTaWxseSB2bHYv Y2h2CmFsd2F5cyBpbnRlcmZlcmluZyB3aXRoIHRoZSBtb3N0bHkgbmljZSBjaHJvbm9sb2dpY2Fs IG9yZGVyLgoKPiAKPiA+IEBAIC00OTE4LDYgKzQ4MjQsNzUgQEAgdm9pZCBpbnRlbF9pcnFfZmlu aShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiA+ICAgICAgICAgICAgICAgICBrZnJl ZShpOTE1LT5sM19wYXJpdHkucmVtYXBfaW5mb1tpXSk7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRp YyBpcnFfaGFuZGxlcl90IGludGVsX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiA+ICt7Cj4gPiArICAgICAgIGlmIChIQVNfR01DSChkZXZfcHJpdikpIHsK PiA+ICsgICAgICAgICAgICAgICBpZiAoSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gY2hlcnJ5dmlld19pcnFfaGFuZGxlcjsKPiA+ICsg ICAgICAgICAgICAgICBlbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSkKPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgIHJldHVybiB2YWxsZXl2aWV3X2lycV9oYW5kbGVyOwo+ID4gKyAg ICAgICAgICAgICAgIGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwgNCkpCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICByZXR1cm4gaTk2NV9pcnFfaGFuZGxlcjsKPiA+ICsgICAgICAgICAgICAg ICBlbHNlIGlmIChJU19HRU4oZGV2X3ByaXYsIDMpKQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIGk5MTVfaXJxX2hhbmRsZXI7Cj4gPiArICAgICAgICAgICAgICAgZWxzZQo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGk4eHhfaXJxX2hhbmRsZXI7Cj4gPiArICAg ICAgIH0gZWxzZSB7Cj4gPiArICAgICAgICAgICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gMTEpCj4gPiArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZ2VuMTFfaXJxX2hhbmRs ZXI7Cj4gPiArICAgICAgICAgICAgICAgZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA4 KQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGdlbjhfaXJxX2hhbmRsZXI7Cj4g PiArICAgICAgICAgICAgICAgZWxzZQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IGlyb25sYWtlX2lycV9oYW5kbGVyOwo+ID4gKyAgICAgICB9Cj4gPiArfQo+ID4gKwo+ID4gK3N0 YXRpYyB2b2lkIGludGVsX2lycV9yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gPiArewo+ID4gKyAgICAgICBpZiAoSEFTX0dNQ0goZGV2X3ByaXYpKSB7Cj4gPiArICAg ICAgICAgICAgICAgaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgY2hlcnJ5dmlld19pcnFfcmVzZXQoZGV2X3ByaXYpOwo+ID4gKyAgICAgICAg ICAgICAgIGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpKQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgdmFsbGV5dmlld19pcnFfcmVzZXQoZGV2X3ByaXYpOwo+ID4gKyAgICAgICAg ICAgICAgIGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwgNCkpCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICBpOTY1X2lycV9yZXNldChkZXZfcHJpdik7Cj4gPiArICAgICAgICAgICAgICAgZWxz ZSBpZiAoSVNfR0VOKGRldl9wcml2LCAzKSkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGk5 MTVfaXJxX3Jlc2V0KGRldl9wcml2KTsKPiA+ICsgICAgICAgICAgICAgICBlbHNlCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICBpOHh4X2lycV9yZXNldChkZXZfcHJpdik7Cj4gPiArICAgICAg IH0gZWxzZSB7Cj4gPiArICAgICAgICAgICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g MTEpCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBnZW4xMV9pcnFfcmVzZXQoZGV2X3ByaXYp Owo+ID4gKyAgICAgICAgICAgICAgIGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOCkK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGdlbjhfaXJxX3Jlc2V0KGRldl9wcml2KTsKPiA+ ICsgICAgICAgICAgICAgICBlbHNlCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpcm9ubGFr ZV9pcnFfcmVzZXQoZGV2X3ByaXYpOwo+ID4gKyAgICAgICB9Cj4gPiArfQo+ID4gKwo+ID4gK3N0 YXRpYyB2b2lkIGludGVsX2lycV9wb3N0aW5zdGFsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4gPiArewo+ID4gKyAgICAgICBpZiAoSEFTX0dNQ0goZGV2X3ByaXYpKSB7Cj4g PiArICAgICAgICAgICAgICAgaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgY2hlcnJ5dmlld19pcnFfcG9zdGluc3RhbGwoZGV2X3ByaXYpOwo+ ID4gKyAgICAgICAgICAgICAgIGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpKQo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgdmFsbGV5dmlld19pcnFfcG9zdGluc3RhbGwoZGV2X3By aXYpOwo+ID4gKyAgICAgICAgICAgICAgIGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwgNCkpCj4g PiArICAgICAgICAgICAgICAgICAgICAgICBpOTY1X2lycV9wb3N0aW5zdGFsbChkZXZfcHJpdik7 Cj4gPiArICAgICAgICAgICAgICAgZWxzZSBpZiAoSVNfR0VOKGRldl9wcml2LCAzKSkKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIGk5MTVfaXJxX3Bvc3RpbnN0YWxsKGRldl9wcml2KTsKPiA+ ICsgICAgICAgICAgICAgICBlbHNlCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpOHh4X2ly cV9wb3N0aW5zdGFsbChkZXZfcHJpdik7Cj4gPiArICAgICAgIH0gZWxzZSB7Cj4gPiArICAgICAg ICAgICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICBnZW4xMV9pcnFfcG9zdGluc3RhbGwoZGV2X3ByaXYpOwo+ID4gKyAgICAgICAg ICAgICAgIGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOCkKPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgIGdlbjhfaXJxX3Bvc3RpbnN0YWxsKGRldl9wcml2KTsKPiA+ICsgICAgICAg ICAgICAgICBlbHNlCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpcm9ubGFrZV9pcnFfcG9z dGluc3RhbGwoZGV2X3ByaXYpOwo+ID4gKyAgICAgICB9Cj4gPiArfQo+ID4gKwo+ID4gIC8qKgo+ ID4gICAqIGludGVsX2lycV9pbnN0YWxsIC0gZW5hYmxlcyB0aGUgaGFyZHdhcmUgaW50ZXJydXB0 Cj4gPiAgICogQGRldl9wcml2OiBpOTE1IGRldmljZSBpbnN0YW5jZQo+ID4gQEAgLTQ5MzEsNiAr NDkwNiw5IEBAIHZvaWQgaW50ZWxfaXJxX2Zpbmkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5 MTUpCj4gPiAgICovCj4gPiAgaW50IGludGVsX2lycV9pbnN0YWxsKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiA+ICB7Cj4gPiArICAgICAgIGludCBpcnEgPSBkZXZfcHJpdi0+ ZHJtLnBkZXYtPmlycTsKPiA+ICsgICAgICAgaW50IHJldDsKPiA+ICsKPiA+ICAgICAgICAgLyoK PiA+ICAgICAgICAgICogV2UgZW5hYmxlIHNvbWUgaW50ZXJydXB0IHNvdXJjZXMgaW4gb3VyIHBv c3RpbnN0YWxsIGhvb2tzLCBzbyBtYXJrCj4gPiAgICAgICAgICAqIGludGVycnVwdHMgYXMgZW5h YmxlZCBfYmVmb3JlXyBhY3R1YWxseSBlbmFibGluZyB0aGVtIHRvIGF2b2lkCj4gPiBAQCAtNDkz OCw3ICs0OTE2LDIwIEBAIGludCBpbnRlbF9pcnFfaW5zdGFsbChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gPiAgICAgICAgICAqLwo+ID4gICAgICAgICBkZXZfcHJpdi0+cnVu dGltZV9wbS5pcnFzX2VuYWJsZWQgPSB0cnVlOwo+ID4gIAo+ID4gLSAgICAgICByZXR1cm4gZHJt X2lycV9pbnN0YWxsKCZkZXZfcHJpdi0+ZHJtLCBkZXZfcHJpdi0+ZHJtLnBkZXYtPmlycSk7Cj4g PiArICAgICAgIGRldl9wcml2LT5kcm0uaXJxX2VuYWJsZWQgPSB0cnVlOwo+ID4gKwo+ID4gKyAg ICAgICBpbnRlbF9pcnFfcmVzZXQoZGV2X3ByaXYpOwo+ID4gKwo+ID4gKyAgICAgICByZXQgPSBy ZXF1ZXN0X2lycShpcnEsIGludGVsX2lycV9oYW5kbGVyKGRldl9wcml2KSwKPiAKPiBPaCBmYW5j eS4KCkkgd2FzIGRlYmF0aW5nIHRvIHZmdW5jIG9yIG5vdCB0byB2ZnVuYy4gU2VlbWVkIHNpbXBs ZSBlbm91Z2ggd2l0aG91dC4KVGhvdWdoIHRoZSByZXBldGl0aW9uIG9mIHRoZSBwbGF0Zm9ybSBj aGVja3MgaW4gaW50ZWxfaXJxXyooKSBpcyBhIGJpdAphbm5veWluZy4KCj4gCj4gUmV2aWV3ZWQt Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC1DaHJpcwoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZng=