From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 09/23] drm/i915: Factor out common parts from TypeC port handling functions Date: Tue, 18 Jun 2019 19:44:35 +0300 Message-ID: <20190618164435.GJ3733@ideak-desk.fi.intel.com> References: <20190604145826.16424-1-imre.deak@intel.com> <20190604145826.16424-10-imre.deak@intel.com> <20190618163313.GR5942@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EDCD6E1E8 for ; Tue, 18 Jun 2019 16:44:38 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190618163313.GR5942@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDc6MzM6MTNQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgSnVuIDA0LCAyMDE5IGF0IDA1OjU4OjEyUE0gKzAzMDAsIEltcmUg RGVhayB3cm90ZToKPiA+IEZhY3RvciBvdXQgaGVscGVycyByZWFkaW5nL3BhcnNpbmcgdGhlIFR5 cGVDIHNwZWNpZmljIHJlZ2lzdGVycywgbWFraW5nCj4gPiBjdXJyZW50IHVzZXJzIG9mIHRoZW0g Y2xlYXJlciBhbmQgbGV0dGluZyB1cyB1c2UgdGhlbSBsYXRlci4KPiA+IAo+ID4gV2hpbGUgYXQg aXQgYWxzbzoKPiA+IC0gU2ltcGxpZnkgaWNsX3RjX3BoeV9jb25uZWN0KCkgd2l0aCBhbiBlYXJs eSByZXR1cm4gaW4gbGVnYWN5IG1vZGUuCj4gPiAtIFNpbXBsaWZ5IHRoZSBsaXZlIHN0YXR1cyBj aGVjayB1c2luZyBvbmUgYml0bWFzayBmb3IgYWxsIEhQRCBiaXRzLgo+ID4gLSBSZW1vdmUgYSBt aWNyby1vcHRpbWlzYXRpb24gb2YgdGhlIHJlcGVhdGVkIHNhZmUtbW9kZSBjbGVhcmluZy4KPiA+ IC0gTWFrZSBzdXJlIHdlIGZpeCB0aGUgbGVnYWN5IHBvcnQgZmxhZyBpbiBhbGwgY2FzZXMuCj4g PiAKPiA+IEV4Y2VwdCBmb3IgdGhlIGxhc3QgdHdvLCBubyBmdW5jdGlvbmFsIGNoYW5nZXMuCj4g PiAKPiA+IENjOiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4K PiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiBDYzogUGF1 bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBJ bXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYyB8ICAgNSArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3RjLmMgIHwgMTY2ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF90Yy5oICB8ICAgMSArCj4gPiAgMyBmaWxlcyBjaGFuZ2Vk LCAxMDMgaW5zZXJ0aW9ucygrKSwgNjkgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RkaS5jCj4gPiBpbmRleCA4ZjIyM2Q0OGQ1NjIuLmQyMzY4MzliZWUxOSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gQEAgLTI5ODMsNyArMjk4Myw2IEBAIHN0 YXRpYyB2b2lkIGljbF9wcm9ncmFtX21nX2RwX21vZGUoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9y dCAqaW50ZWxfZGlnX3BvcnQpCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiA+ICAJ ZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3J0Owo+ID4gLQllbnVtIHRj X3BvcnQgdGNfcG9ydCA9IGludGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIHBvcnQpOwo+ID4gIAl1 MzIgbG4wLCBsbjEsIGxhbmVfaW5mbzsKPiA+ICAKPiA+ICAJaWYgKGludGVsX2RpZ19wb3J0LT50 Y19tb2RlID09IFRDX1BPUlRfVEJUX0FMVCkKPiA+IEBAIC0yOTk3LDkgKzI5OTYsNyBAQCBzdGF0 aWMgdm9pZCBpY2xfcHJvZ3JhbV9tZ19kcF9tb2RlKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQg KmludGVsX2RpZ19wb3J0KQo+ID4gIAkJbG4wICY9IH4oTUdfRFBfTU9ERV9DRkdfRFBfWDFfTU9E RSB8IE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREUpOwo+ID4gIAkJbG4xICY9IH4oTUdfRFBfTU9E RV9DRkdfRFBfWDFfTU9ERSB8IE1HX0RQX01PREVfQ0ZHX0RQX1gyX01PREUpOwo+ID4gIAo+ID4g LQkJbGFuZV9pbmZvID0gKEk5MTVfUkVBRChQT1JUX1RYX0RGTEVYRFBTUCkgJgo+ID4gLQkJCSAg ICAgRFBfTEFORV9BU1NJR05NRU5UX01BU0sodGNfcG9ydCkpID4+Cj4gPiAtCQkJICAgIERQX0xB TkVfQVNTSUdOTUVOVF9TSElGVCh0Y19wb3J0KTsKPiA+ICsJCWxhbmVfaW5mbyA9IGludGVsX3Rj X3BvcnRfZ2V0X2xhbmVfaW5mbyhpbnRlbF9kaWdfcG9ydCk7Cj4gPiAgCj4gPiAgCQlzd2l0Y2gg KGxhbmVfaW5mbykgewo+ID4gIAkJY2FzZSAweDE6Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfdGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3RjLmMK PiA+IGluZGV4IDA3NDg4MjM1YjY3YS4uM2ZkY2ZhMmJiYWVlIDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdGMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfdGMuYwo+ID4gQEAgLTQzLDEwICs0MywxOSBAQCBzdGF0aWMgY29uc3QgY2hhciAq dGNfcG9ydF9tb2RlX25hbWUoZW51bSB0Y19wb3J0X21vZGUgbW9kZSkKPiA+ICAJcmV0dXJuIG5h bWVzW21vZGVdOwo+ID4gIH0KPiA+ICAKPiA+IC1pbnQgaW50ZWxfdGNfcG9ydF9maWFfbWF4X2xh bmVfY291bnQoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQpCj4gPiArdTMyIGlu dGVsX3RjX3BvcnRfZ2V0X2xhbmVfaW5mbyhzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdf cG9ydCkKPiAKPiBnZXRfbGFuZV9tYXNrKCkgb3Igc29tZXRoaW5nPwoKT2suCgo+IAo+ID4gIHsK PiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkaWdfcG9y dC0+YmFzZS5iYXNlLmRldik7Cj4gPiAgCWVudW0gdGNfcG9ydCB0Y19wb3J0ID0gaW50ZWxfcG9y dF90b190YyhkZXZfcHJpdiwgZGlnX3BvcnQtPmJhc2UucG9ydCk7Cj4gPiArCXUzMiBsYW5lX2lu Zm8gPSBJOTE1X1JFQUQoUE9SVF9UWF9ERkxFWERQU1ApOwo+ID4gKwo+ID4gKwlyZXR1cm4gKGxh bmVfaW5mbyAmIERQX0xBTkVfQVNTSUdOTUVOVF9NQVNLKHRjX3BvcnQpKSA+Pgo+ID4gKwkgICAg ICAgRFBfTEFORV9BU1NJR05NRU5UX1NISUZUKHRjX3BvcnQpOwo+ID4gK30KPiA+ICsKPiA+ICtp bnQgaW50ZWxfdGNfcG9ydF9maWFfbWF4X2xhbmVfY291bnQoc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydCAqZGlnX3BvcnQpCj4gPiArewo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSB0b19pOTE1KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiA+ICAJaW50ZWxfd2Fr ZXJlZl90IHdha2VyZWY7Cj4gPiAgCXUzMiBsYW5lX2luZm87Cj4gPiAgCj4gPiBAQCAtNTUsOSAr NjQsNyBAQCBpbnQgaW50ZWxfdGNfcG9ydF9maWFfbWF4X2xhbmVfY291bnQoc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQpCj4gPiAgCj4gPiAgCWxhbmVfaW5mbyA9IDA7Cj4gPiAg CXdpdGhfaW50ZWxfZGlzcGxheV9wb3dlcihkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX0RJU1BMQVlf Q09SRSwgd2FrZXJlZikKPiA+IC0JCWxhbmVfaW5mbyA9IChJOTE1X1JFQUQoUE9SVF9UWF9ERkxF WERQU1ApICYKPiA+IC0JCQkgICAgIERQX0xBTkVfQVNTSUdOTUVOVF9NQVNLKHRjX3BvcnQpKSA+ Pgo+ID4gLQkJCQlEUF9MQU5FX0FTU0lHTk1FTlRfU0hJRlQodGNfcG9ydCk7Cj4gPiArCQlsYW5l X2luZm8gPSBpbnRlbF90Y19wb3J0X2dldF9sYW5lX2luZm8oZGlnX3BvcnQpOwo+ID4gIAo+ID4g IAlzd2l0Y2ggKGxhbmVfaW5mbykgewo+ID4gIAlkZWZhdWx0Ogo+ID4gQEAgLTc1LDYgKzgyLDY5 IEBAIGludCBpbnRlbF90Y19wb3J0X2ZpYV9tYXhfbGFuZV9jb3VudChzdHJ1Y3QgaW50ZWxfZGln aXRhbF9wb3J0ICpkaWdfcG9ydCkKPiA+ICAJfQo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgdm9p ZCB0Y19wb3J0X2ZpeHVwX2xlZ2FjeV9mbGFnKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRp Z19wb3J0LAo+ID4gKwkJCQkgICAgICB1MzIgbGl2ZV9zdGF0dXNfbWFzaykKPiA+ICt7Cj4gPiAr CXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtPmJh c2UuYmFzZS5kZXYpOwo+ID4gKwllbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGludGVsX3BvcnRfdG9f dGMoZGV2X3ByaXYsIGRpZ19wb3J0LT5iYXNlLnBvcnQpOwo+ID4gKwl1MzIgdmFsaWRfaHBkX21h c2sgPSBkaWdfcG9ydC0+dGNfbGVnYWN5X3BvcnQgPyBCSVQoVENfUE9SVF9MRUdBQ1kpIDoKPiA+ ICsJCQkJCQkJfkJJVChUQ19QT1JUX0xFR0FDWSk7Cj4gPiArCj4gPiArCWlmICghKGxpdmVfc3Rh dHVzX21hc2sgJiB+dmFsaWRfaHBkX21hc2spKQo+ID4gKwkJcmV0dXJuOwo+IAo+IEEgYml0IHRv byBtYW55IG5vdHMgZm9yIG1lIHRvIGZvbGxvdy4gSSBndWVzcyB3aGF0IGl0J3MgZG9pbmcgaXMK PiBjaGVja2luZyBpZiBhbnkgb2YgdGhlIG90aGVyIGJpdHMgYXJlIHNldCwgYW5kIGlmIHNvIGl0 IGFzc3VtZXMgdGhlCj4gbW9kZSB3YXMgbWlzZGVjbGFyZWQgaW4gdmJ0PyAKClllcy4KCj4gCj4g QWN0dWFsbHksIHdvbid0IHRoaXMgZW5kIHVwIHBpbmctcG9uZ2luZyBiYWNrIGFuZCBmb3J0aCBp ZiB0aGUKPiBodyByZWFsbHkgcmVwb3J0cyBib3RoIGxlZ2FjeSBhbmQgbm9uLWxlZ2FjeSBiaXRz IGFzIHNldD8KCklmIHlvdSBtZWFuIG11bHRpcGxlIEhQRCBiaXRzIGJlaW5nIHNldCBieSBIVywg d2Ugd29uJ3QgY2FsbCB0aGlzCmZ1bmN0aW9uIHRvIGZpeCB1cCB0aGUgZmxhZy4KCj4gCj4gPiAr Cj4gPiArCS8qIElmIGxpdmUgc3RhdHVzIG1pc21hdGNoZXMgdGhlIFZCVCBmbGFnLCB0cnVzdCB0 aGUgbGl2ZSBzdGF0dXMuICovCj4gPiArCURSTV9FUlJPUigiUG9ydCAlczogbGl2ZSBzdGF0dXMg JTA4eCBtaXNtYXRjaGVzIHRoZSBsZWdhY3kgcG9ydCBmbGFnLCBmaXggZmxhZ1xuIiwKPiA+ICsJ CSAgdGNfcG9ydF9uYW1lKGRldl9wcml2LCB0Y19wb3J0KSwgbGl2ZV9zdGF0dXNfbWFzayk7Cj4g PiArCj4gPiArCWRpZ19wb3J0LT50Y19sZWdhY3lfcG9ydCA9ICFkaWdfcG9ydC0+dGNfbGVnYWN5 X3BvcnQ7Cj4gPiArfQo+ID4gKwo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==