Re: [PATCH 5/5] drm/i915/ehl: Enable DDI-D

Souza, Jose
2019-06-21T20:52:18Z

On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote:
> EHL has four DDI's (DDI-A and DDI-D share combo PHY A).
>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index e72ace42327c..74cd180360f4 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -15128,6 +15128,7 @@ static void intel_setup_outputs(struct
> drm_i915_private *dev_priv)
> intel_ddi_init(dev_priv, PORT_A);
> intel_ddi_init(dev_priv, PORT_B);
> intel_ddi_init(dev_priv, PORT_C);
> + intel_ddi_init(dev_priv, PORT_D);

Here we should only initialize only the one that is going to be used A
or D at this point we already have that information and the mux set.

> icl_dsi_init(dev_priv);
> } else if (INTEL_GEN(dev_priv) >= 11) {
> intel_ddi_init(dev_priv, PORT_A);