Re: [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset

Souza, Jose
2019-06-21T20:19:19Z

On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote:
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index 7e6009cefb18..7e748bb3f324 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1793,8 +1793,10 @@ enum i915_power_well_id {
> */
> #define _ICL_COMBOPHY_A 0x162000
> #define _ICL_COMBOPHY_B 0x6C000
> +#define _ICL_COMBOPHY_C_EHL 0x160000
> #define _ICL_COMBOPHY(port) _PICK(port, _ICL_COMBOPHY_A, \
> - _ICL_COMBOPHY_B)
> + _ICL_COMBOPHY_B, \
> + _ICL_COMBOPHY_C_EHL)
>

Rename to _EHL_COMBOPHY_C.

With that: Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> /* CNL/ICL Port CL_DW registers */
> #define _ICL_PORT_CL_DW(dw, port) (_ICL_COMBOPHY(port) + \