Re: [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans()

Clinton Taylor
2019-06-21T23:23:52Z

Logical, since its not being used.

Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>

-Clint

On 6/20/19 7:01 PM, Matt Roper wrote:
> The port parameter hasn't been used since the last bspec phy programming
> update. Drop it to make some upcoming changes simpler.
>
> References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 7925a176f900..593806d44ad4 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -846,8 +846,8 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
> }
>
> static const struct cnl_ddi_buf_trans *
> -icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, enum port port,
> - int type, int rate, int *n_entries)
> +icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
> + int *n_entries)
> {
> if (type == INTEL_OUTPUT_HDMI) {
> *n_entries = ARRAY_SIZE(icl_combo_phy_ddi_translations_hdmi);
> @@ -872,7 +872,7 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
>
> if (INTEL_GEN(dev_priv) >= 11) {
> if (intel_port_is_combophy(dev_priv, port))
> - icl_get_combo_buf_trans(dev_priv, port, INTEL_OUTPUT_HDMI,
> + icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
> 0, &n_entries);
> else
> n_entries = ARRAY_SIZE(icl_mg_phy_ddi_translations);
> @@ -2231,7 +2231,7 @@ u8 intel_ddi_dp_voltage_max(struct intel_encoder *encoder)
>
> if (INTEL_GEN(dev_priv) >= 11) {
> if (intel_port_is_combophy(dev_priv, port))
> - icl_get_combo_buf_trans(dev_priv, port, encoder->type,
> + icl_get_combo_buf_trans(dev_priv, encoder->type,
> intel_dp->link_rate, &n_entries);
> else
> n_entries = ARRAY_SIZE(icl_mg_phy_ddi_translations);
> @@ -2420,8 +2420,8 @@ static void icl_ddi_combo_vswing_program(struct drm_i915_private *dev_priv,
> u32 n_entries, val;
> int ln;
>
> - ddi_translations = icl_get_combo_buf_trans(dev_priv, port, type,
> - rate, &n_entries);
> + ddi_translations = icl_get_combo_buf_trans(dev_priv, type, rate,
> + &n_entries);
> if (!ddi_translations)
> return;
>