From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 18/23] drm/i915/icl: Split getting the DPLLs to port type specific functions Date: Tue, 25 Jun 2019 16:55:56 +0300 Message-ID: <20190625135556.GG5942@intel.com> References: <20190620140600.11357-1-imre.deak@intel.com> <20190620140600.11357-19-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2879B6E10C for ; Tue, 25 Jun 2019 13:56:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190620140600.11357-19-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMjAsIDIwMTkgYXQgMDU6MDU6NTVQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEZvciBjbGFyaXR5IGZhY3RvciBvdXQgdGhlIGNvbWJvIFBIWSBhbmQgVHlwZUMgUEhZIHNw ZWNpZmljIGNvZGUgZnJvbQo+IGljbF9nZXRfZHBsbHMoKSBpbnRvIHRoZWlyIG93biBmdW5jdGlv bnMuCj4gCj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5r aG9yc3RAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5k ZWFrQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kcGxsX21nci5jIHwgMTAwICsrKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgNjYgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBsbF9tZ3IuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBsbF9tZ3IuYwo+IGluZGV4IDE0YmJhYjQ1ODM2 ZC4uODVjMzhlZWQ5M2E4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfZHBsbF9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZHBsbF9tZ3IuYwo+IEBAIC0yODU2LDUxICsyODU2LDY2IEBAIHN0YXRpYyBib29sIGlj bF9jYWxjX21nX3BsbF9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwK PiAgCXJldHVybiB0cnVlOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9vbCBpY2xfZ2V0X2RwbGxzKHN0 cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+IC0JCQkgIHN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjLAo+IC0JCQkgIHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ICtzdGF0aWMg Ym9vbCBpY2xfZ2V0X2NvbWJvX3BoeV9kcGxsKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0 YXRlLAo+ICsJCQkJICAgc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gKwkJCQkgICBzdHJ1Y3Qg aW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiArewo+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNydGNfc3RhdGUgPQo+ICsJCWludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RhdGUs IGNydGMpOwo+ICsJc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGw7Cj4gKwo+ICsJaWYgKCFp Y2xfY2FsY19kcGxsX3N0YXRlKGNydGNfc3RhdGUsIGVuY29kZXIsCj4gKwkJCQkgJmNydGNfc3Rh dGUtPmRwbGxfaHdfc3RhdGUpKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiQ291bGQgbm90IGNhbGN1 bGF0ZSBjb21ibyBQSFkgUExMIHN0YXRlLlxuIik7Cj4gKwo+ICsJCXJldHVybiBmYWxzZTsKPiAr CX0KPiArCj4gKwlwbGwgPSBpbnRlbF9maW5kX3NoYXJlZF9kcGxsKHN0YXRlLCBjcnRjLCAmY3J0 Y19zdGF0ZS0+ZHBsbF9od19zdGF0ZSwKPiArCQkJCSAgICAgRFBMTF9JRF9JQ0xfRFBMTDAsCj4g KwkJCQkgICAgIERQTExfSURfSUNMX0RQTEwxKTsKPiArCWlmICghcGxsKSB7Cj4gKwkJRFJNX0RF QlVHX0tNUygiTm8gY29tYm8gUEhZIFBMTCBmb3VuZCBmb3IgcG9ydCAlY1xuIiwKPiArCQkJICAg ICAgcG9ydF9uYW1lKGVuY29kZXItPnBvcnQpKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4g Kwo+ICsJaW50ZWxfcmVmZXJlbmNlX3NoYXJlZF9kcGxsKHN0YXRlLCBjcnRjLAo+ICsJCQkJICAg IHBsbCwgJmNydGNfc3RhdGUtPmRwbGxfaHdfc3RhdGUpOwo+ICsKPiArCWNydGNfc3RhdGUtPnNo YXJlZF9kcGxsID0gcGxsOwo+ICsKPiArCXJldHVybiB0cnVlOwo+ICt9Cj4gKwo+ICtzdGF0aWMg Ym9vbCBpY2xfZ2V0X3RjX3BoeV9kcGxscyhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0 ZSwKPiArCQkJCSBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiArCQkJCSBzdHJ1Y3QgaW50ZWxf ZW5jb2RlciAqZW5jb2RlcikKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gdG9faTkxNShzdGF0ZS0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUgPQo+ICAJCWludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3Rh dGUsIGNydGMpOwo+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQ7 Cj4gKwllbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGludGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIGVu Y29kZXItPnBvcnQpOwo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQ7Cj4g IAlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbDsKPiAtCWVudW0gcG9ydCBwb3J0ID0gZW5j b2Rlci0+cG9ydDsKPiAgCWVudW0gaW50ZWxfZHBsbF9pZCBtaW4sIG1heDsKPiAgCWJvb2wgcmV0 Owo+ICAKPiAtCWlmIChpbnRlbF9wb3J0X2lzX2NvbWJvcGh5KGRldl9wcml2LCBwb3J0KSkgewo+ IC0JCW1pbiA9IERQTExfSURfSUNMX0RQTEwwOwo+IC0JCW1heCA9IERQTExfSURfSUNMX0RQTEwx Owo+ICsJaWYgKGVuY29kZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0RQX01TVCkKPiArCQlkaWdf cG9ydCA9IGVuY190b19tc3QoJmVuY29kZXItPmJhc2UpLT5wcmltYXJ5Owo+ICsJZWxzZQo+ICsJ CWRpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiArCj4gKwlpZiAo ZGlnX3BvcnQtPnRjX21vZGUgPT0gVENfUE9SVF9UQlRfQUxUKSB7Cj4gKwkJbWluID0gRFBMTF9J RF9JQ0xfVEJUUExMOwo+ICsJCW1heCA9IG1pbjsKPiAgCQlyZXQgPSBpY2xfY2FsY19kcGxsX3N0 YXRlKGNydGNfc3RhdGUsIGVuY29kZXIsCj4gIAkJCQkJICAmY3J0Y19zdGF0ZS0+ZHBsbF9od19z dGF0ZSk7Cj4gLQl9IGVsc2UgaWYgKGludGVsX3BvcnRfaXNfdGMoZGV2X3ByaXYsIHBvcnQpKSB7 Cj4gLQkJaWYgKGVuY29kZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0RQX01TVCkgewo+IC0JCQlz dHJ1Y3QgaW50ZWxfZHBfbXN0X2VuY29kZXIgKm1zdF9lbmNvZGVyOwo+IC0KPiAtCQkJbXN0X2Vu Y29kZXIgPSBlbmNfdG9fbXN0KCZlbmNvZGVyLT5iYXNlKTsKPiAtCQkJaW50ZWxfZGlnX3BvcnQg PSBtc3RfZW5jb2Rlci0+cHJpbWFyeTsKPiAtCQl9IGVsc2Ugewo+IC0JCQlpbnRlbF9kaWdfcG9y dCA9IGVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4gLQkJfQo+IC0KPiAtCQlpZiAo aW50ZWxfZGlnX3BvcnQtPnRjX21vZGUgPT0gVENfUE9SVF9UQlRfQUxUKSB7Cj4gLQkJCW1pbiA9 IERQTExfSURfSUNMX1RCVFBMTDsKPiAtCQkJbWF4ID0gbWluOwo+IC0JCQlyZXQgPSBpY2xfY2Fs Y19kcGxsX3N0YXRlKGNydGNfc3RhdGUsIGVuY29kZXIsCj4gLQkJCQkJCSAgJmNydGNfc3RhdGUt PmRwbGxfaHdfc3RhdGUpOwo+IC0JCX0gZWxzZSB7Cj4gLQkJCWVudW0gdGNfcG9ydCB0Y19wb3J0 Owo+IC0KPiAtCQkJdGNfcG9ydCA9IGludGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIHBvcnQpOwo+ IC0JCQltaW4gPSBpY2xfdGNfcG9ydF90b19wbGxfaWQodGNfcG9ydCk7Cj4gLQkJCW1heCA9IG1p bjsKPiAtCQkJcmV0ID0gaWNsX2NhbGNfbWdfcGxsX3N0YXRlKGNydGNfc3RhdGUsCj4gLQkJCQkJ CSAgICAmY3J0Y19zdGF0ZS0+ZHBsbF9od19zdGF0ZSk7Cj4gLQkJfQo+ICAJfSBlbHNlIHsKPiAt CQlNSVNTSU5HX0NBU0UocG9ydCk7Cj4gLQkJcmV0dXJuIGZhbHNlOwo+ICsJCW1pbiA9IGljbF90 Y19wb3J0X3RvX3BsbF9pZCh0Y19wb3J0KTsKPiArCQltYXggPSBtaW47Cj4gKwkJcmV0ID0gaWNs X2NhbGNfbWdfcGxsX3N0YXRlKGNydGNfc3RhdGUsCj4gKwkJCQkJICAgICZjcnRjX3N0YXRlLT5k cGxsX2h3X3N0YXRlKTsKPiAgCX0KPiAgCj4gIAlpZiAoIXJldCkgewo+IEBAIC0yOTI1LDYgKzI5 NDAsMjMgQEAgc3RhdGljIGJvb2wgaWNsX2dldF9kcGxscyhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0 YXRlICpzdGF0ZSwKPiAgCXJldHVybiB0cnVlOwo+ICB9Cj4gIAo+ICtzdGF0aWMgYm9vbCBpY2xf Z2V0X2RwbGxzKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICsJCQkgIHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjLAo+ICsJCQkgIHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVy KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHN0 YXRlLT5iYXNlLmRldik7Cj4gKwllbnVtIHBvcnQgcG9ydCA9IGVuY29kZXItPnBvcnQ7Cj4gKwo+ ICsJaWYgKGludGVsX3BvcnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKQo+ICsJCXJldHVy biBpY2xfZ2V0X2NvbWJvX3BoeV9kcGxsKHN0YXRlLCBjcnRjLCBlbmNvZGVyKTsKPiArCWVsc2Ug aWYgKGludGVsX3BvcnRfaXNfdGMoZGV2X3ByaXYsIHBvcnQpKQo+ICsJCXJldHVybiBpY2xfZ2V0 X3RjX3BoeV9kcGxscyhzdGF0ZSwgY3J0YywgZW5jb2Rlcik7Cj4gKwo+ICsJTUlTU0lOR19DQVNF KHBvcnQpOwo+ICsKPiArCXJldHVybiBmYWxzZTsKPiArfQo+ICsKPiAgc3RhdGljIGJvb2wgbWdf cGxsX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJ CQlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCwKPiAgCQkJCXN0cnVjdCBpbnRlbF9kcGxs X2h3X3N0YXRlICpod19zdGF0ZSkKPiAtLSAKPiAyLjE3LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4