✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix TypeC port mode switching (rev3)

Patchwork
2019-06-20T17:23:56Z

== Series Details ==

Series: drm/i915: Fix TypeC port mode switching (rev3)
URL : https://patchwork.freedesktop.org/series/61590/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e23fdc6d149d drm/i915/icl: Add support to read out the TBT PLL HW state
cbfff715e9c9 drm/i915: Tune down WARNs about TBT AUX power well enabling
266a1ac2b970 drm/i915: Move the TypeC port handling code to a separate file
-:367: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#367:
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 552 lines checked
99a847a30a78 drm/i915: Sanitize the terminology used for TypeC port modes
79c53d6dcec7 drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt mode
9d6beb1b4ea8 drm/i915: Fix the TBT AUX power well enabling
c080cbb38c42 drm/i915: Use the correct AUX power domain in TypeC TBT-alt mode
733db64b1529 drm/i915: Unify the TypeC port notation in debug/error messages
88cfb872780a drm/i915: Factor out common parts from TypeC port handling functions
b79ebfe5fc44 drm/i915: Wait for TypeC PHY complete flag to clear in safe mode
8b32c53cd102 drm/i915: Handle the TCCOLD power-down event
7197f853f9e7 drm/i915: Sanitize the TypeC connect/detect sequences
9a0ddbbe66db drm/i915: Fix the TypeC port mode sanitization during loading/resume
add997a1441c drm/i915: Keep the TypeC port mode fixed for detect/AUX transfers
4e1bb7d75889 drm/i915: Sanitize the TypeC FIA lane configuration decoding
ae4b99a193a4 drm/i915: Sanitize the shared DPLL reserve/release interface
7faaeddd815e drm/i915: Sanitize the shared DPLL find/reference interface
cef5a2ac6fea drm/i915/icl: Split getting the DPLLs to port type specific functions
214c46150901 drm/i915/icl: Reserve all required PLLs for TypeC ports
02babe71ee3e drm/i915: Keep the TypeC port mode fixed when the port is active
-:516: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name
#516: FILE: drivers/gpu/drm/i915/intel_drv.h:118:
+ void (*update_prepare)(struct intel_atomic_state *,

-:516: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name
#516: FILE: drivers/gpu/drm/i915/intel_drv.h:118:
+ void (*update_prepare)(struct intel_atomic_state *,

-:516: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_crtc *' should also have an identifier name
#516: FILE: drivers/gpu/drm/i915/intel_drv.h:118:
+ void (*update_prepare)(struct intel_atomic_state *,

-:526: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_atomic_state *' should also have an identifier name
#526: FILE: drivers/gpu/drm/i915/intel_drv.h:130:
+ void (*update_complete)(struct intel_atomic_state *,

-:526: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_encoder *' should also have an identifier name
#526: FILE: drivers/gpu/drm/i915/intel_drv.h:130:
+ void (*update_complete)(struct intel_atomic_state *,

-:526: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_crtc *' should also have an identifier name
#526: FILE: drivers/gpu/drm/i915/intel_drv.h:130:
+ void (*update_complete)(struct intel_atomic_state *,

total: 0 errors, 6 warnings, 0 checks, 440 lines checked
94e8339903b9 drm/i915: Add state verification for the TypeC port mode
a47ad8551d26 drm/i915: Remove unneeded disconnect in TypeC legacy port mode
2078b7058a62 drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modes