From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 21/23] drm/i915: Add state verification for the TypeC port mode Date: Tue, 25 Jun 2019 17:12:52 +0300 Message-ID: <20190625141252.GJ5942@intel.com> References: <20190620140600.11357-1-imre.deak@intel.com> <20190620140600.11357-22-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB0246E115 for ; Tue, 25 Jun 2019 14:12:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190620140600.11357-22-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMjAsIDIwMTkgYXQgMDU6MDU6NThQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEFkZCBzdGF0ZSB2ZXJpZmljYXRpb24gZm9yIHRoZSBUeXBlQyBwb3J0IG1vZGUgd3J0LiB0 aGUgcG9ydCdzIEFVWCBwb3dlcgo+IHdlbGwgZW5hYmxpbmcvZGlzYWJsaW5nLiBBbHNvIGNoZWNr IHRoZSBjb3JyZWN0bmVzcyBvZiBjaGFuZ2luZyB0aGUgcG9ydAo+IG1vZGU6Cj4gLSBXaGVuIGVu YWJsaW5nL2Rpc2FibGluZyB0aGUgQVVYIHBvd2VyIHdlbGwgZm9yIGEgVHlwZUMgcG9ydCB3ZSBt dXN0IGhvbGQKPiAgIGFscmVhZHkgdGhlIFR5cGVDIHBvcnQgbG9jay4KPiAtIFdoZW4gY2hhbmdp bmcgdGhlIFR5cGVDIHBvcnQgbW9kZSB0aGUgcG9ydCdzIEFVWCBwb3dlciBkb21haW4gbXVzdCBi ZQo+ICAgZGlzYWJsZWQuCj4gCj4gQ2M6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291 emFAaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0tLQo+ ICAuLi4vZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5X3Bvd2VyLmMgICAgfCA5OSArKysr KysrKysrKysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMu YyAgICAgICB8ICAyICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF90Yy5o ICAgICAgIHwgMTAgKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxMDIgaW5zZXJ0aW9ucygrKSwgOSBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kaXNwbGF5X3Bvd2VyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu dGVsX2Rpc3BsYXlfcG93ZXIuYwo+IGluZGV4IGZkMTNjZDY4ZGVhZS4uZjQ2MTNlMTBjM2IzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheV9w b3dlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5 X3Bvd2VyLmMKPiBAQCAtMTcsNiArMTcsNyBAQAo+ICAjaW5jbHVkZSAiaW50ZWxfZHJ2LmgiCj4g ICNpbmNsdWRlICJpbnRlbF9ob3RwbHVnLmgiCj4gICNpbmNsdWRlICJpbnRlbF9zaWRlYmFuZC5o Igo+ICsjaW5jbHVkZSAiaW50ZWxfdGMuaCIKPiAgCj4gIGJvb2wgaW50ZWxfZGlzcGxheV9wb3dl cl93ZWxsX2lzX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ CQkJCSBlbnVtIGk5MTVfcG93ZXJfd2VsbF9pZCBwb3dlcl93ZWxsX2lkKTsKPiBAQCAtNDQ3LDI2 ICs0NDgsMTEwIEBAIGljbF9jb21ib19waHlfYXV4X3Bvd2VyX3dlbGxfZGlzYWJsZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICNkZWZpbmUgSUNMX1RCVF9BVVhfUFdfVE9f Q0gocHdfaWR4KQlcCj4gIAkoKHB3X2lkeCkgLSBJQ0xfUFdfQ1RMX0lEWF9BVVhfVEJUMSArIEFV WF9DSF9DKQo+ICAKPiArc3RhdGljIGVudW0gYXV4X2NoIGljbF90Y19waHlfYXV4X2NoKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJCSAgICAgc3RydWN0IGk5MTVfcG93 ZXJfd2VsbCAqcG93ZXJfd2VsbCkKPiArewo+ICsJaW50IHB3X2lkeCA9IHBvd2VyX3dlbGwtPmRl c2MtPmhzdy5pZHg7Cj4gKwo+ICsJcmV0dXJuIHBvd2VyX3dlbGwtPmRlc2MtPmhzdy5pc190Y190 YnQgPyBJQ0xfVEJUX0FVWF9QV19UT19DSChwd19pZHgpIDoKPiArCQkJCQkJIElDTF9BVVhfUFdf VE9fQ0gocHdfaWR4KTsKPiArfQo+ICsKPiArI2lmIElTX0VOQUJMRUQoQ09ORklHX0RSTV9JOTE1 X0RFQlVHX1JVTlRJTUVfUE0pCj4gKwo+ICtzdGF0aWMgdTY0IGFzeW5jX3B1dF9kb21haW5zX21h c2soc3RydWN0IGk5MTVfcG93ZXJfZG9tYWlucyAqcG93ZXJfZG9tYWlucyk7Cj4gKwo+ICtzdGF0 aWMgaW50IHBvd2VyX3dlbGxfYXN5bmNfcmVmX2NvdW50KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiArCQkJCSAgICAgIHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGwgKnBvd2VyX3dl bGwpCj4gK3sKPiArCWVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21haW4gZG9tYWluOwo+ICsJ dTY0IGFzeW5jX2RvbWFpbnMgPSBhc3luY19wdXRfZG9tYWluc19tYXNrKCZkZXZfcHJpdi0+cG93 ZXJfZG9tYWlucyk7Cj4gKwlpbnQgcmVmcyA9IDA7Cj4gKwo+ICsJZm9yX2VhY2hfcG93ZXJfZG9t YWluKGRvbWFpbiwgcG93ZXJfd2VsbC0+ZGVzYy0+ZG9tYWlucykKPiArCQlyZWZzICs9ICEhKGFz eW5jX2RvbWFpbnMgJiBCSVRfVUxMKGRvbWFpbikpOwo+ICsKPiArCVdBUk5fT04ocmVmcyA+IHBv d2VyX3dlbGwtPmNvdW50KTsKCmh3ZWlnaHQ2NCgpIG5vdCBzdWZmaWNpZW50IGhlcmU/Cgo+ICsK PiArCXJldHVybiByZWZzOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBpY2xfdGNfcG9ydF9hc3Nl cnRfcmVmX2hlbGQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJCXN0 cnVjdCBpOTE1X3Bvd2VyX3dlbGwgKnBvd2VyX3dlbGwpCj4gK3sKPiArCWVudW0gYXV4X2NoIGF1 eF9jaCA9IGljbF90Y19waHlfYXV4X2NoKGRldl9wcml2LCBwb3dlcl93ZWxsKTsKPiArCXN0cnVj dCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gTlVMTDsKPiArCXN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyOwo+ICsKPiArCS8qIEJ5cGFzcyB0aGUgY2hlY2sgaWYgYWxsIHJlZmVy ZW5jZXMgYXJlIHJlbGVhc2VkIGFzeW5jaHJvbm91c2x5ICovCj4gKwlpZiAocG93ZXJfd2VsbF9h c3luY19yZWZfY291bnQoZGV2X3ByaXYsIHBvd2VyX3dlbGwpID09Cj4gKwkgICAgcG93ZXJfd2Vs bC0+Y291bnQpCj4gKwkJcmV0dXJuOwo+ICsKPiArCWF1eF9jaCA9IGljbF90Y19waHlfYXV4X2No KGRldl9wcml2LCBwb3dlcl93ZWxsKTsKPiArCj4gKwlmb3JfZWFjaF9pbnRlbF9lbmNvZGVyKCZk ZXZfcHJpdi0+ZHJtLCBlbmNvZGVyKSB7Cj4gKwkJaWYgKCFpbnRlbF9wb3J0X2lzX3RjKGRldl9w cml2LCBlbmNvZGVyLT5wb3J0KSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCS8qIFdlJ2xsIGNo ZWNrIHRoZSBNU1QgcHJpbWFyeSBwb3J0ICovCj4gKwkJaWYgKGVuY29kZXItPnR5cGUgPT0gSU5U RUxfT1VUUFVUX0RQX01TVCkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCWRpZ19wb3J0ID0gZW5j X3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiArCQlpZiAoV0FSTl9PTighZGlnX3BvcnQp KQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJaWYgKGRpZ19wb3J0LT5hdXhfY2ggIT0gYXV4X2No KSB7Cj4gKwkJCWRpZ19wb3J0ID0gTlVMTDsKPiArCQkJY29udGludWU7Cj4gKwkJfQo+ICsKPiAr CQlicmVhazsKPiArCX0KPiArCj4gKwlpZiAoV0FSTl9PTighZGlnX3BvcnQpKQo+ICsJCXJldHVy bjsKPiArCj4gKwlXQVJOX09OKCFpbnRlbF90Y19wb3J0X3JlZl9oZWxkKGRpZ19wb3J0KSk7Cj4g K30KPiArCj4gKyNlbHNlCj4gKwo+ICtzdGF0aWMgdm9pZCBpY2xfdGNfcG9ydF9hc3NlcnRfcmVm X2hlbGQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJCXN0cnVjdCBp OTE1X3Bvd2VyX3dlbGwgKnBvd2VyX3dlbGwpCj4gK3sKPiArfQo+ICsKPiArI2VuZGlmCj4gKwo+ ICBzdGF0aWMgdm9pZAo+ICBpY2xfdGNfcGh5X2F1eF9wb3dlcl93ZWxsX2VuYWJsZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgc3RydWN0IGk5MTVfcG93ZXJfd2Vs bCAqcG93ZXJfd2VsbCkKPiAgewo+IC0JaW50IHB3X2lkeCA9IHBvd2VyX3dlbGwtPmRlc2MtPmhz dy5pZHg7Cj4gLQlib29sIGlzX3RidCA9IHBvd2VyX3dlbGwtPmRlc2MtPmhzdy5pc190Y190YnQ7 Cj4gLQllbnVtIGF1eF9jaCBhdXhfY2g7Cj4gKwllbnVtIGF1eF9jaCBhdXhfY2ggPSBpY2xfdGNf cGh5X2F1eF9jaChkZXZfcHJpdiwgcG93ZXJfd2VsbCk7Cj4gIAl1MzIgdmFsOwo+ICAKPiAtCWF1 eF9jaCA9IGlzX3RidCA/IElDTF9UQlRfQVVYX1BXX1RPX0NIKHB3X2lkeCkgOgo+IC0JCQkgIElD TF9BVVhfUFdfVE9fQ0gocHdfaWR4KTsKPiArCWljbF90Y19wb3J0X2Fzc2VydF9yZWZfaGVsZChk ZXZfcHJpdiwgcG93ZXJfd2VsbCk7Cj4gKwo+ICAJdmFsID0gSTkxNV9SRUFEKERQX0FVWF9DSF9D VEwoYXV4X2NoKSk7Cj4gIAl2YWwgJj0gfkRQX0FVWF9DSF9DVExfVEJUX0lPOwo+IC0JaWYgKGlz X3RidCkKPiArCWlmIChwb3dlcl93ZWxsLT5kZXNjLT5oc3cuaXNfdGNfdGJ0KQo+ICAJCXZhbCB8 PSBEUF9BVVhfQ0hfQ1RMX1RCVF9JTzsKPiAgCUk5MTVfV1JJVEUoRFBfQVVYX0NIX0NUTChhdXhf Y2gpLCB2YWwpOwo+ICAKPiAgCWhzd19wb3dlcl93ZWxsX2VuYWJsZShkZXZfcHJpdiwgcG93ZXJf d2VsbCk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkCj4gK2ljbF90Y19waHlfYXV4X3Bvd2VyX3dl bGxfZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgIHN0 cnVjdCBpOTE1X3Bvd2VyX3dlbGwgKnBvd2VyX3dlbGwpCj4gK3sKPiArCWljbF90Y19wb3J0X2Fz c2VydF9yZWZfaGVsZChkZXZfcHJpdiwgcG93ZXJfd2VsbCk7Cj4gKwo+ICsJaHN3X3Bvd2VyX3dl bGxfZGlzYWJsZShkZXZfcHJpdiwgcG93ZXJfd2VsbCk7Cj4gK30KPiArCj4gIC8qCj4gICAqIFdl IHNob3VsZCBvbmx5IHVzZSB0aGUgcG93ZXIgd2VsbCBpZiB3ZSBleHBsaWNpdGx5IGFza2VkIHRo ZSBoYXJkd2FyZSB0bwo+ICAgKiBlbmFibGUgaXQsIHNvIGNoZWNrIGlmIGl0J3MgZW5hYmxlZCBh bmQgYWxzbyBjaGVjayBpZiB3ZSd2ZSByZXF1ZXN0ZWQgaXQgdG8KPiBAQCAtMzExOSw3ICszMjA0 LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpOTE1X3Bvd2VyX3dlbGxfb3BzIGljbF9jb21ib19w aHlfYXV4X3Bvd2VyX3dlbGxfb3BzID0gewo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGk5MTVfcG93 ZXJfd2VsbF9vcHMgaWNsX3RjX3BoeV9hdXhfcG93ZXJfd2VsbF9vcHMgPSB7Cj4gIAkuc3luY19o dyA9IGhzd19wb3dlcl93ZWxsX3N5bmNfaHcsCj4gIAkuZW5hYmxlID0gaWNsX3RjX3BoeV9hdXhf cG93ZXJfd2VsbF9lbmFibGUsCj4gLQkuZGlzYWJsZSA9IGhzd19wb3dlcl93ZWxsX2Rpc2FibGUs Cj4gKwkuZGlzYWJsZSA9IGljbF90Y19waHlfYXV4X3Bvd2VyX3dlbGxfZGlzYWJsZSwKPiAgCS5p c19lbmFibGVkID0gaHN3X3Bvd2VyX3dlbGxfZW5hYmxlZCwKPiAgfTsKPiAgCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuYwo+IGluZGV4IGM4OTA0OTExZTg0MS4uNmM0M2Jl Y2Y5N2Y3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf dGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuYwo+IEBA IC0zMDMsNiArMzAzLDggQEAgc3RhdGljIHZvaWQgaW50ZWxfdGNfcG9ydF9yZXNldF9tb2RlKHN0 cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0LAo+ICAJZW51bSB0Y19wb3J0X21vZGUg b2xkX3RjX21vZGUgPSBkaWdfcG9ydC0+dGNfbW9kZTsKPiAgCj4gIAlpbnRlbF9kaXNwbGF5X3Bv d2VyX2ZsdXNoX3dvcmsoZGV2X3ByaXYpOwo+ICsJV0FSTl9PTihpbnRlbF9kaXNwbGF5X3Bvd2Vy X2lzX2VuYWJsZWQoZGV2X3ByaXYsCj4gKwkJCQkJICAgICAgIGludGVsX2F1eF9wb3dlcl9kb21h aW4oZGlnX3BvcnQpKSk7Cj4gIAo+ICAJaWNsX3RjX3BoeV9kaXNjb25uZWN0KGRpZ19wb3J0KTsK PiAgCWljbF90Y19waHlfY29ubmVjdChkaWdfcG9ydCwgcmVxdWlyZWRfbGFuZXMpOwo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmgKPiBpbmRleCAzMWFmN2JlOTYwNzAuLjhh ZGMxMDdjZGJjYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu dGVsX3RjLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmgK PiBAQCAtNyw4ICs3LDggQEAKPiAgI2RlZmluZSBfX0lOVEVMX1RDX0hfXwo+ICAKPiAgI2luY2x1 ZGUgPGxpbnV4L3R5cGVzLmg+Cj4gLQo+IC1zdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0Owo+ICsj aW5jbHVkZSA8bGludXgvbXV0ZXguaD4KPiArI2luY2x1ZGUgImludGVsX2Rydi5oIgo+ICAKPiAg dm9pZCBpY2xfdGNfcGh5X2Rpc2Nvbm5lY3Qoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGln X3BvcnQpOwo+ICAKPiBAQCAtMjMsNiArMjMsMTIgQEAgdm9pZCBpbnRlbF90Y19wb3J0X2dldF9s aW5rKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0LAo+ICAJCQkgICAgaW50IHJl cXVpcmVkX2xhbmVzKTsKPiAgdm9pZCBpbnRlbF90Y19wb3J0X3B1dF9saW5rKHN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0KTsKPiAgCj4gK3N0YXRpYyBpbmxpbmUgaW50IGludGVs X3RjX3BvcnRfcmVmX2hlbGQoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQpCj4g K3sKPiArCXJldHVybiBtdXRleF9pc19sb2NrZWQoJmRpZ19wb3J0LT50Y19sb2NrKSB8fAo+ICsJ ICAgICAgIGRpZ19wb3J0LT50Y19saW5rX3JlZmNvdW50OwoKVGhpcyB3aWxsIGFsbG93IHRjX2xv Y2sgdG8gbm90IGJlIGhlbGQgaWYgdGhlIHJlZmNvdW50IGlzIGVsZXZhdGVkLiBXYXMKdGhhdCB0 aGUgaW50ZW50aW9uPyBUaGUgY29tbWl0IG1lc3NhZ2Ugc2F5cyB0aGUgbG9jayBzaG91bGQgYWx3 YXlzIGJlCmhlbGQuCgpTaG91bGQgd2UgZG8gYSBsb2NrZGVwIGFzc2VydCBoZXJlIGlmIGxvY2tk ZXAgaXMgZW5hYmxlZD8KCj4gK30KPiArCj4gIHZvaWQgaW50ZWxfdGNfcG9ydF9pbml0KHN0cnVj dCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0LCBib29sIGlzX2xlZ2FjeSk7Cj4gIAo+ICAj ZW5kaWYgLyogX19JTlRFTF9UQ19IX18gKi8KPiAtLSAKPiAyLjE3LjEKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5n IGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4