Re: [PATCH i-g-t 5/5] tests/kms_selftest: Integrate kernel selftest test-drm_modeset

Daniel Vetter
2019-06-20T13:20:18Z

On Tue, Oct 16, 2018 at 03:23:41PM -0700, Deepak Rawat wrote:
> Call kernel selftest module test-drm_modeset for testing KMS.
>
> v2:
> - Add test alphabetically.
> - Add test to meson build.
>
> v3: Rename to kms_selftest.
>
> Signed-off-by: Deepak Rawat <drawat@vmware.com>

Just realized that this never landed ... any reasons? Would be nice to get
this handled.

Petri/Arek?

Cheers, Daniel

> ---
> tests/Makefile.sources | 1 +
> tests/igt_command_line.sh | 2 +-
> tests/kms_selftest.c | 10 ++++++++++
> tests/meson.build | 1 +
> 4 files changed, 13 insertions(+), 1 deletion(-)
> create mode 100644 tests/kms_selftest.c
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 001f1a2b..cdf5a7e1 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -202,6 +202,7 @@ TESTS_progs = \
> kms_pwrite_crc \
> kms_rmfb \
> kms_rotation_crc \
> + kms_selftest \
> kms_setmode \
> kms_sysfs_edid_timing \
> kms_tv_load_detect \
> diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
> index 8285ba62..a4ec3f95 100755
> --- a/tests/igt_command_line.sh
> +++ b/tests/igt_command_line.sh
> @@ -90,7 +90,7 @@ check_test ()
> # Subtest enumeration of kernel selftest launchers depends
> # on the running kernel. If selftests are not enabled,
> # they will output nothing and exit with 0.
> - if [ "$testname" != "drv_selftest" -a "$testname" != "drm_mm" ]; then
> + if [ "$testname" != "drv_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" ]; then
> fail $test
> fi
> fi
> diff --git a/tests/kms_selftest.c b/tests/kms_selftest.c
> new file mode 100644
> index 00000000..f61ddd99
> --- /dev/null
> +++ b/tests/kms_selftest.c
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#include "igt.h"
> +#include "igt_kmod.h"
> +
> +IGT_TEST_DESCRIPTION("Basic sanity check of KMS selftests.");
> +
> +igt_main
> +{
> + igt_kselftests("test-drm_modeset", NULL, NULL, NULL);
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index 697ff515..d74eb109 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -177,6 +177,7 @@ test_progs = [
> 'kms_pwrite_crc',
> 'kms_rmfb',
> 'kms_rotation_crc',
> + 'kms_selftest',
> 'kms_setmode',
> 'kms_sysfs_edid_timing',
> 'kms_tv_load_detect',
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation