From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: make drm_panel.h self-contained Date: Thu, 27 Jun 2019 14:31:22 +0200 Message-ID: <20190627123122.GC21242@ulmo> References: <20190627110103.7539-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1383579109==" Return-path: In-Reply-To: <20190627110103.7539-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Boris Brezillon , intel-gfx@lists.freedesktop.org, Thierry Reding , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1383579109== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wxDdMuZNg1r63Hyj" Content-Disposition: inline --wxDdMuZNg1r63Hyj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 27, 2019 at 02:01:03PM +0300, Jani Nikula wrote: > Fix build warning if drm_panel.h is built with CONFIG_OF=3Dn or > CONFIG_DRM_PANEL=3Dn and included without the prerequisite err.h: >=20 > ./include/drm/drm_panel.h: In function =E2=80=98of_drm_find_panel=E2=80= =99: > ./include/drm/drm_panel.h:203:9: error: implicit declaration of function = =E2=80=98ERR_PTR=E2=80=99 [-Werror=3Dimplicit-function-declaration] > return ERR_PTR(-ENODEV); > ^~~~~~~ > ./include/drm/drm_panel.h:203:9: error: returning =E2=80=98int=E2=80=99 f= rom a function with return type =E2=80=98struct drm_panel *=E2=80=99 makes = pointer from integer without a cast [-Werror=3Dint-conversion] > return ERR_PTR(-ENODEV); > ^~~~~~~~~~~~~~~~ >=20 > Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_P= TR() instead of NULL") > Cc: Boris Brezillon > Cc: Thierry Reding > Signed-off-by: Jani Nikula >=20 > --- >=20 > I don't know if there's a combo where this actually fails, so I'm not > adding cc: stable. It's just something I hit when playing with other > code. > --- > include/drm/drm_panel.h | 1 + > 1 file changed, 1 insertion(+) Acked-by: Thierry Reding --wxDdMuZNg1r63Hyj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl0UtxYACgkQ3SOs138+ s6H5iBAAwUCyHu2PzWK1XZYphwP0keEicqHmUiJG1ofO8Yk70N9ZL2JQaoG3ckr2 GgVrPExJvFJCvgLhbIYHc2uzqCYEkKGJV45mo79wf16C8jg9BLCacRUpHSvYFiUo S+09uDDqQYvW2N2KGokjC2ln8W5g+2tVLMYuSEIyrHk1c2+gdvZfG/y2h7F7q2Jc aprcq91AJMi4YbZCSh0z26TrHsk6FXhIETiWqLJzv5gg6t5vhuszv506zBb2+ptG T69xr0Saw8lTWNhi/hDdjdKXNq00tg/8z2Y8PRS6AVolPLWZW7c9981DJtt5Wkxo GQcRzrYNUjwbGMEvxdKvhEdY5cxyZcijzd+iTvI8DGpCAJAGUiZjYeBFOi55TeAj 173yxt+zICRgiCRpJyl0mAsOmTJhZR23nXqQ2z9dbJs7sHTTREhTPxsGs6c++JoJ vuQVlAy1Buru7jx18jGx+JQBRycqXHbuHMS9Jiq22iRarlkalw4iGJEatksr3mDV Guj+mj/madvI7hE+WVmZHohtCj6mAatJjnliptVxf1gzACG6MwagAx5K5VUckDgh fFpvQ0Fc6WyjUYXcGH7fZWmr1vjmeIIwtDnTW+1uaYGxqloM9lpxam/eyRfpYE8C g/xKnDXCfQ9co0vh9Go1Ks8nV8zXp0jhfnaSmFlLfcIO3d95xw0= =eZKc -----END PGP SIGNATURE----- --wxDdMuZNg1r63Hyj-- --===============1383579109== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1383579109==--