Re: [PATCH v2 01/37] drm/i915: buddy allocator

Chris Wilson
2019-06-28T09:35:42Z

Quoting Matthew Auld (2019-06-27 21:55:57)
> +static void __i915_buddy_free(struct i915_buddy_mm *mm,
> + struct i915_buddy_block *block)
> +{
> + list_del_init(&block->link); /* We have ownership now */

That is an important observation. Even more important is that as you
didn't own it, you shouldn't touch the previous linkage, and just assume
control. The owner relinquished all control of the block upon freeing.
-Chris