Re: [PATCH 12/28] drm/i915/tgl: Add TRANSCODER_A_VDSC power domain

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 12/28] drm/i915/tgl: Add TRANSCODER_A_VDSC power domain
Date: Mon, 1 Jul 2019 20:36:30 +0300	[thread overview]
Message-ID: <20190701173629.GL5942@intel.com> (raw)
In-Reply-To: <20190701173259.GK5942@intel.com>

On Mon, Jul 01, 2019 at 08:32:59PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 28, 2019 at 09:31:04AM -0700, Lucas De Marchi wrote:
> > On Fri, Jun 28, 2019 at 12:55:17PM +0300, Ville Syrjälä wrote:
> > >On Tue, Jun 25, 2019 at 10:54:21AM -0700, Lucas De Marchi wrote:
> > >> From: José Roberto de Souza <jose.souza@intel.com>
> > >>
> > >> On TGL the special EDP transcoder is gone and it should be handled by
> > >> transcoder A. Add POWER_DOMAIN_TRANSCODER_A_VDSC to make this
> > >> distinction clear and update vdsc code path.
> > >>
> > >> Cc: Imre Deak <imre.deak@intel.com>
> > >> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > >> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > >> ---
> > >>  drivers/gpu/drm/i915/display/intel_display_power.c |  2 ++
> > >>  drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
> > >>  drivers/gpu/drm/i915/display/intel_vdsc.c          | 11 ++++++++---
> > >>  3 files changed, 11 insertions(+), 3 deletions(-)
> > >>
> > >> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> > >> index 0c7d4a363deb..15582841fefc 100644
> > >> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> > >> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> > >> @@ -58,6 +58,8 @@ intel_display_power_domain_str(struct drm_i915_private *i915,
> > >>  		return "TRANSCODER_EDP";
> > >>  	case POWER_DOMAIN_TRANSCODER_EDP_VDSC:
> > >>  		return "TRANSCODER_EDP_VDSC";
> > >> +	case POWER_DOMAIN_TRANSCODER_A_VDSC:
> > >> +		return "TRANSCODER_A_VDSC";
> > >>  	case POWER_DOMAIN_TRANSCODER_DSI_A:
> > >>  		return "TRANSCODER_DSI_A";
> > >>  	case POWER_DOMAIN_TRANSCODER_DSI_C:
> > >> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> > >> index 79262a5bceb4..7761b493608a 100644
> > >> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> > >> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> > >> @@ -29,6 +29,7 @@ enum intel_display_power_domain {
> > >>  	POWER_DOMAIN_TRANSCODER_D,
> > >>  	POWER_DOMAIN_TRANSCODER_EDP,
> > >>  	POWER_DOMAIN_TRANSCODER_EDP_VDSC,
> > >> +	POWER_DOMAIN_TRANSCODER_A_VDSC,
> > >
> > >Two power domains for essentially the same thing seems a bit wasteful.
> > 
> > just reuse the name then?
> > 
> > and on gen12+ check for TRANSCODER_A like below?
> 
> That was my initial idea yes. In theory it would be nice to have fully
> abstracted power domains but that would lead to a lot of bits getting
> used. I suspect we might have to switch to using the kernel bitmask
> stuff in that case. Not sure how many bits we have free ATM.

I've also pondered about shaving off a few bits by special casing the
HSW panel fitter stuff in a similar fashion.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx