Re: [PATCH v1 0/11] drm: header maintenance

Sam Ravnborg
2019-07-19T21:26:51Z

On Thu, Jul 18, 2019 at 06:14:56PM +0200, Sam Ravnborg wrote:
> First patch from Jani fixes so drm_print.h is self-contained.
> Next two patches are trivial removal of uapi dependencies.
>
> ati_pcigart is fixed to drop use of drm_os_linux.h
>
> drm_vblank is likewise fixed to drop use of drm_os_linux.h
> This was a non-trivial conversion, *review requested!*
>
> The remaining patches are preparation for and removal of
> uapi/drm/drmh from drm_file.h.
> There were a few files where we had to push include
> of drm/drm.h out to to have a clean build.
>
> CK Hu - please let me apply the mediatek patch to
> drm-misc-next, as it is required for the final patch.
> Or push it to drm-misc-next yourself.
>
> Sam
>
> Jani Nikula (1):
> drm/panel: make drm_panel.h self-contained
>
> Sam Ravnborg (10):
> drm: drop uapi dependency from drm_print.h
> drm: drop uapi dependency from drm_vblank.h
> drm/ati_pcigart: drop dependency on drm_os_linux.h
> drm/vblank: drop use of DRM_WAIT_ON()
> drm: direct include of drm.h in drm_gem.c
> drm: direct include of drm.h in drm_gem_shmem_helper.c
> drm: direct include of drm.h in drm_prime.c
> drm: direct include of drm.h in drm_syncobj.c
> drm/mediatek: direct include of drm.h in mtk_drm_gem.c
> drm: drop uapi dependency from drm_file.h

Added relevant acks and pushed following patches to drm-misc-next:
drm/panel: make drm_panel.h self-contained
drm: drop uapi dependency from drm_vblank.h
drm/ati_pcigart: drop dependency on drm_os_linux.h
drm: direct include of drm.h in drm_gem.c
drm: direct include of drm.h in drm_gem_shmem_helper.c
drm: direct include of drm.h in drm_prime.c
drm: direct include of drm.h in drm_syncobj.c
drm/mediatek: direct include of drm.h in mtk_drm_gem.c

Following patches was dropped:
drm: drop uapi dependency from drm_print.h
- There was not a clear consensus what to do here, and the patch
broke one way to use the DRM_(PRINT) macros.
- I did not have the time/enegy to start a logging debate.
There is too much that could be done and it is not the right
time for me to look into the possibilities.

drm: drop uapi dependency from drm_file.h
- There were relevant push back from loosing the information
that a uapi type was used to represent 'magic'

Following patch is worked on:
drm/vblank: drop use of DRM_WAIT_ON()
- Got excellent feedback from Michel Dänzer and Daniel Vetter.
- An updated version will be posted when I have tested it
at my local setup

Sam