Re: [PATCH 09/17] drm/i915: Push the ring creation flags to the backend

Chris Wilson
2019-09-06T18:18:59Z

Quoting Tvrtko Ursulin (2019-09-02 14:59:16)
>
> On 05/08/2019 18:08, Andi Shyti wrote:
> > Hi Chris,
> >
> > On Tue, Jul 30, 2019 at 02:30:27PM +0100, Chris Wilson wrote:
> >> Push the ring creation flags from the outer GEM context to the inner
> >> intel_cotnext to avoid an unsightly back-reference from inside the
> >> backend.
> >>
> >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > looks nice!
> >
> > Reviewed-by: Andi Shyti <andi.shyti@intel.com>
>
> I wish my complaints on this patch weren't just ignored.

You wanted a union for a one-off value, and I disagreed as imo it
overformalised the parameter passing and made it look like persistent
state.
-Chris