From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Paalanen Subject: Re: [PATCH v11 1/6] drm: Add Content protection type property Date: Thu, 1 Aug 2019 13:05:02 +0300 Message-ID: <20190801130502.1a4d4a4e@ferris.localdomain> References: <20190712070026.13088-2-ramalingam.c@intel.com> <20190714110008.19647-1-ramalingam.c@intel.com> <20190729172040.48257318@eldfell.localdomain> <20190729093316.GB14727@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1799798704==" Return-path: In-Reply-To: <20190729093316.GB14727@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ramalingam C Cc: intel-gfx , dri-devel List-Id: intel-gfx@lists.freedesktop.org --===============1799798704== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/JxIIB2U1todT+QBGfp4cJ/4"; protocol="application/pgp-signature" --Sig_/JxIIB2U1todT+QBGfp4cJ/4 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 29 Jul 2019 15:03:16 +0530 Ramalingam C wrote: > On 2019-07-29 at 17:20:40 +0300, Pekka Paalanen wrote: > > On Sun, 14 Jul 2019 16:30:08 +0530 > > Ramalingam C wrote: > > =20 > > > This patch adds a DRM ENUM property to the selected connectors. > > > This property is used for mentioning the protected content's type > > > from userspace to kernel HDCP authentication. > > >=20 > > > Type of the stream is decided by the protected content providers. > > > Type 0 content can be rendered on any HDCP protected display wires. > > > But Type 1 content can be rendered only on HDCP2.2 protected paths. > > >=20 > > > So when a userspace sets this property to Type 1 and starts the HDCP > > > enable, kernel will honour it only if HDCP2.2 authentication is throu= gh > > > for type 1. Else HDCP enable will be failed. > > >=20 > > > Need ACK for this new conenctor property from userspace consumer. > > >=20 > > > v2: > > > cp_content_type is replaced with content_protection_type [daniel] > > > check at atomic_set_property is removed [Maarten] > > > v3: > > > %s/content_protection_type/hdcp_content_type [Pekka] > > > v4: > > > property is created for the first requested connector and then reus= ed. > > > [Danvet] > > > v5: > > > kernel doc nits addressed [Daniel] > > > Rebased as part of patch reordering. > > > v6: > > > Kernel docs are modified [pekka] > > > v7: > > > More details in Kernel docs. [pekka] > > > v8: > > > Few more clarification into kernel doc of content type [pekka] > > > v9: > > > Small fixes in coding style. > > >=20 > > > Signed-off-by: Ramalingam C > > > Reviewed-by: Daniel Vetter > > > --- > > > drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ > > > drivers/gpu/drm/drm_connector.c | 51 +++++++++++++++++++++= ++ > > > drivers/gpu/drm/drm_hdcp.c | 36 +++++++++++++++- > > > drivers/gpu/drm/i915/display/intel_hdcp.c | 4 +- > > > include/drm/drm_connector.h | 7 ++++ > > > include/drm/drm_hdcp.h | 2 +- > > > include/drm/drm_mode_config.h | 6 +++ > > > include/uapi/drm/drm_mode.h | 4 ++ > > > 8 files changed, 111 insertions(+), 3 deletions(-) =20 > >=20 > >=20 > > Snip - sorry, gmail simply refuses to deliver my mail without trimming > > it hard. > > =20 > > > =20 > > > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > > > index 5ab331e5dc23..5c954394093f 100644 > > > --- a/include/uapi/drm/drm_mode.h > > > +++ b/include/uapi/drm/drm_mode.h > > > @@ -218,6 +218,10 @@ extern "C" { > > > #define DRM_MODE_CONTENT_PROTECTION_DESIRED 1 > > > #define DRM_MODE_CONTENT_PROTECTION_ENABLED 2 > > > =20 > > > +/* Content Type classification for HDCP2.2 vs others */ > > > +#define DRM_MODE_HDCP_CONTENT_TYPE0 0 > > > +#define DRM_MODE_HDCP_CONTENT_TYPE1 1 =20 > >=20 > > Hi, > >=20 > > I still believe that these definitions do not belong in the uapi > > header. Userspace must use the string names instead. > >=20 > > Otherwise the patch looks fine, though my Weston review is still > > on-going. =20 >=20 > I assume that still we need to wait for the weston review completion. >=20 > Hence I request you to respond here once you are comfortable with this ne= w uAPI. Hi, yes. I have completed the Weston DRM-backend review in https://gitlab.freedesktop.org/wayland/weston/merge_requests/48 and the UAPI for HDCP 2.2 looks good. That Weston MR has some other not-UAPI-related bits I need to read through still, but they have no impact on the UAPI. The userspace is accepted in Weston. I am also happy with the documentation in these kernel patches. Therefore, with DRM_MODE_HDCP_CONTENT_TYPE0 and DRM_MODE_HDCP_CONTENT_TYPE1 removed from the kernel UAPI headers, for the kernel documentation and userspace consumer in Weston I give for these HDCP 2.2 Phase II kernel patches: Acked-by: Pekka Paalanen Let me know, preferably as a comment in the Weston MR, when the kernel patches have landed in the appropriate git tree to unblock merging in Weston, please. Thanks, pq --Sig_/JxIIB2U1todT+QBGfp4cJ/4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAl1CuU4ACgkQI1/ltBGq qqdWNA/+OYOdi8o/1IMbjUghhqTsWlvMDzawzUVfi7dxi1PiiU9zI/C99mBPc/Yc kWAi7lSbt5lqR2DP69ylwZHTkWwSDP4ELaE7Gj8jZq0AJylWvoEa9Ivb2RG7ufi8 /cNIDiVJN64ulPb4X40xTt3CCcQI8U7SWRoDSOaVhR5IOpTWECIoJzOD3vZY07yk 6SIYF7fECThXaxTjxVQUSwDcINvQAeLFFqcMo1DhaK4KYM+prmScznmvuK/sNh+4 /KH6LVzQIC6DtYO0zA8ERn5bWua8UR3rFVWd19bLFHXaU3xtrQNmtUcyzF8CyQei gIPxZunqcSLpD3brQqTj0BIAcvlL+NWeP5giODDkEyhstNC/Ibu6FCalM9MxzUiS oYEG1C1KmbL1vy+CSFMTYu+xghMH6rOhwQCZSnOQRKbcnxhcQutIZUJ0PIazqKEl MrE4h/jjfNAN8vnsM3+G5y/ogVPm1gQyFn2p/kvGDEx19+RIdwl6P3uGj09qJoC6 NnjiqZWQyEQF7wJAD82JAd1JGp9vQHVgOODjUwdKnv8dBfxk3QNckASrnGF+0nob zBpON8dhaDItNT7988gWGpPhaRDuyawwW2y7qYekdDDvm/QViNSYXyLy9//Srerb kY8PqinAoDaKqmIJgbb7Ggpl8/6CPko1Tcc1aaJKMWEsuKOsofQ= =v3YP -----END PGP SIGNATURE----- --Sig_/JxIIB2U1todT+QBGfp4cJ/4-- --===============1799798704== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1799798704==--