From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] Revert "drm/vgem: fix cache synchronization on arm/arm64" Date: Fri, 2 Aug 2019 10:18:10 -0400 Message-ID: <20190802141810.GW104440@art_vandelay> References: <20190801124458.24949-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 098196EE72 for ; Fri, 2 Aug 2019 14:18:13 +0000 (UTC) Received: by mail-yw1-xc44.google.com with SMTP id l79so27282539ywe.11 for ; Fri, 02 Aug 2019 07:18:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190801124458.24949-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Rob Clark , Daniel Vetter , intel-gfx@lists.freedesktop.org, Sean Paul , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBdWcgMDEsIDIwMTkgYXQgMDE6NDQ6NThQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IGNvbW1pdCA3ZTllNWVhZDU1YmUgKCJkcm0vdmdlbTogZml4IGNhY2hlIHN5bmNocm9u aXphdGlvbiBvbiBhcm0vYXJtNjQiKQo+IGJyb2tlIGFsbCBvZiB0aGUgIWxsYyBpOTE1LXZnZW0g Y29oZXJlbmN5IHRlc3RzIGluIENJLCBhbmQgbGVmdCB0aGUgSFcKPiB2ZXJ5LCB2ZXJ5IHVuaGFw cHkgKHdoaWNoIGlzIGV2ZW4gbW9yZSBzY2FyeSkuCj4gCj4gRml4ZXM6IDdlOWU1ZWFkNTViZSAo ImRybS92Z2VtOiBmaXggY2FjaGUgc3luY2hyb25pemF0aW9uIG9uIGFybS9hcm02NCIpCj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpBY2tl ZC1ieTogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+Cgo+IENjOiBEYW5pZWwgVmV0dGVyIDxk YW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BjaHJvbWl1 bS5vcmc+Cj4gQ2M6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jIHwgMTMwICsrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCA4MyBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYu YyBiL2RyaXZlcnMvZ3B1L2RybS92Z2VtL3ZnZW1fZHJ2LmMKPiBpbmRleCBiOTg2ODlmYjBkNWQu LjViZDYwZGVkM2Q4MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Ry di5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYwo+IEBAIC01NCwxNiAr NTQsMTAgQEAgc3RhdGljIHN0cnVjdCB2Z2VtX2RldmljZSB7Cj4gIAlzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwbGF0Zm9ybTsKPiAgfSAqdmdlbV9kZXZpY2U7Cj4gIAo+IC1zdGF0aWMgdm9pZCBz eW5jX2FuZF91bnBpbihzdHJ1Y3QgZHJtX3ZnZW1fZ2VtX29iamVjdCAqYm8pOwo+IC1zdGF0aWMg c3RydWN0IHBhZ2UgKipwaW5fYW5kX3N5bmMoc3RydWN0IGRybV92Z2VtX2dlbV9vYmplY3QgKmJv KTsKPiAtCj4gIHN0YXRpYyB2b2lkIHZnZW1fZ2VtX2ZyZWVfb2JqZWN0KHN0cnVjdCBkcm1fZ2Vt X29iamVjdCAqb2JqKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX3ZnZW1fZ2VtX29iamVjdCAqdmdlbV9v YmogPSB0b192Z2VtX2JvKG9iaik7Cj4gIAo+IC0JaWYgKCFvYmotPmltcG9ydF9hdHRhY2gpCj4g LQkJc3luY19hbmRfdW5waW4odmdlbV9vYmopOwo+IC0KPiAgCWt2ZnJlZSh2Z2VtX29iai0+cGFn ZXMpOwo+ICAJbXV0ZXhfZGVzdHJveSgmdmdlbV9vYmotPnBhZ2VzX2xvY2spOwo+ICAKPiBAQCAt OTEsMTUgKzg1LDQwIEBAIHN0YXRpYyB2bV9mYXVsdF90IHZnZW1fZ2VtX2ZhdWx0KHN0cnVjdCB2 bV9mYXVsdCAqdm1mKQo+ICAJCXJldHVybiBWTV9GQVVMVF9TSUdCVVM7Cj4gIAo+ICAJbXV0ZXhf bG9jaygmb2JqLT5wYWdlc19sb2NrKTsKPiAtCWlmICghb2JqLT5wYWdlcykKPiAtCQlwaW5fYW5k X3N5bmMob2JqKTsKPiAgCWlmIChvYmotPnBhZ2VzKSB7Cj4gIAkJZ2V0X3BhZ2Uob2JqLT5wYWdl c1twYWdlX29mZnNldF0pOwo+ICAJCXZtZi0+cGFnZSA9IG9iai0+cGFnZXNbcGFnZV9vZmZzZXRd Owo+ICAJCXJldCA9IDA7Cj4gIAl9Cj4gIAltdXRleF91bmxvY2soJm9iai0+cGFnZXNfbG9jayk7 Cj4gKwlpZiAocmV0KSB7Cj4gKwkJc3RydWN0IHBhZ2UgKnBhZ2U7Cj4gKwo+ICsJCXBhZ2UgPSBz aG1lbV9yZWFkX21hcHBpbmdfcGFnZSgKPiArCQkJCQlmaWxlX2lub2RlKG9iai0+YmFzZS5maWxw KS0+aV9tYXBwaW5nLAo+ICsJCQkJCXBhZ2Vfb2Zmc2V0KTsKPiArCQlpZiAoIUlTX0VSUihwYWdl KSkgewo+ICsJCQl2bWYtPnBhZ2UgPSBwYWdlOwo+ICsJCQlyZXQgPSAwOwo+ICsJCX0gZWxzZSBz d2l0Y2ggKFBUUl9FUlIocGFnZSkpIHsKPiArCQkJY2FzZSAtRU5PU1BDOgo+ICsJCQljYXNlIC1F Tk9NRU06Cj4gKwkJCQlyZXQgPSBWTV9GQVVMVF9PT007Cj4gKwkJCQlicmVhazsKPiArCQkJY2Fz ZSAtRUJVU1k6Cj4gKwkJCQlyZXQgPSBWTV9GQVVMVF9SRVRSWTsKPiArCQkJCWJyZWFrOwo+ICsJ CQljYXNlIC1FRkFVTFQ6Cj4gKwkJCWNhc2UgLUVJTlZBTDoKPiArCQkJCXJldCA9IFZNX0ZBVUxU X1NJR0JVUzsKPiArCQkJCWJyZWFrOwo+ICsJCQlkZWZhdWx0Ogo+ICsJCQkJV0FSTl9PTihQVFJf RVJSKHBhZ2UpKTsKPiArCQkJCXJldCA9IFZNX0ZBVUxUX1NJR0JVUzsKPiArCQkJCWJyZWFrOwo+ ICsJCX0KPiAgCj4gKwl9Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IEBAIC0yNjUsOTMgKzI4 NCwzMiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGZpbGVfb3BlcmF0aW9ucyB2Z2VtX2RyaXZlcl9m b3BzID0gewo+ICAJLnJlbGVhc2UJPSBkcm1fcmVsZWFzZSwKPiAgfTsKPiAgCj4gLS8qIENhbGxl ZCB1bmRlciBwYWdlc19sb2NrLCBleGNlcHQgaW4gZnJlZSBwYXRoICh3aGVyZSBpdCBjYW4ndCBy YWNlKTogKi8KPiAtc3RhdGljIHZvaWQgc3luY19hbmRfdW5waW4oc3RydWN0IGRybV92Z2VtX2dl bV9vYmplY3QgKmJvKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gYm8tPmJhc2Uu ZGV2Owo+IC0KPiAtCWlmIChiby0+dGFibGUpIHsKPiAtCQlkbWFfc3luY19zZ19mb3JfY3B1KGRl di0+ZGV2LCBiby0+dGFibGUtPnNnbCwKPiAtCQkJCWJvLT50YWJsZS0+bmVudHMsIERNQV9CSURJ UkVDVElPTkFMKTsKPiAtCQlzZ19mcmVlX3RhYmxlKGJvLT50YWJsZSk7Cj4gLQkJa2ZyZWUoYm8t PnRhYmxlKTsKPiAtCQliby0+dGFibGUgPSBOVUxMOwo+IC0JfQo+IC0KPiAtCWlmIChiby0+cGFn ZXMpIHsKPiAtCQlkcm1fZ2VtX3B1dF9wYWdlcygmYm8tPmJhc2UsIGJvLT5wYWdlcywgdHJ1ZSwg dHJ1ZSk7Cj4gLQkJYm8tPnBhZ2VzID0gTlVMTDsKPiAtCX0KPiAtfQo+IC0KPiAtc3RhdGljIHN0 cnVjdCBwYWdlICoqcGluX2FuZF9zeW5jKHN0cnVjdCBkcm1fdmdlbV9nZW1fb2JqZWN0ICpibykK PiAtewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGJvLT5iYXNlLmRldjsKPiAtCWludCBu cGFnZXMgPSBiby0+YmFzZS5zaXplID4+IFBBR0VfU0hJRlQ7Cj4gLQlzdHJ1Y3QgcGFnZSAqKnBh Z2VzOwo+IC0Jc3RydWN0IHNnX3RhYmxlICpzZ3Q7Cj4gLQo+IC0JV0FSTl9PTighbXV0ZXhfaXNf bG9ja2VkKCZiby0+cGFnZXNfbG9jaykpOwo+IC0KPiAtCXBhZ2VzID0gZHJtX2dlbV9nZXRfcGFn ZXMoJmJvLT5iYXNlKTsKPiAtCWlmIChJU19FUlIocGFnZXMpKSB7Cj4gLQkJYm8tPnBhZ2VzX3Bp bl9jb3VudC0tOwo+IC0JCW11dGV4X3VubG9jaygmYm8tPnBhZ2VzX2xvY2spOwo+IC0JCXJldHVy biBwYWdlczsKPiAtCX0KPiAtCj4gLQlzZ3QgPSBkcm1fcHJpbWVfcGFnZXNfdG9fc2cocGFnZXMs IG5wYWdlcyk7Cj4gLQlpZiAoSVNfRVJSKHNndCkpIHsKPiAtCQlkZXZfZXJyKGRldi0+ZGV2LAo+ IC0JCQkiZmFpbGVkIHRvIGFsbG9jYXRlIHNndDogJWxkXG4iLAo+IC0JCQlQVFJfRVJSKGJvLT50 YWJsZSkpOwo+IC0JCWRybV9nZW1fcHV0X3BhZ2VzKCZiby0+YmFzZSwgcGFnZXMsIGZhbHNlLCBm YWxzZSk7Cj4gLQkJbXV0ZXhfdW5sb2NrKCZiby0+cGFnZXNfbG9jayk7Cj4gLQkJcmV0dXJuIEVS Ul9DQVNUKGJvLT50YWJsZSk7Cj4gLQl9Cj4gLQo+IC0JLyoKPiAtCSAqIEZsdXNoIHRoZSBvYmpl Y3QgZnJvbSB0aGUgQ1BVIGNhY2hlIHNvIHRoYXQgaW1wb3J0ZXJzCj4gLQkgKiBjYW4gcmVseSBv biBjb2hlcmVudCBpbmRpcmVjdCBhY2Nlc3MgdmlhIHRoZSBleHBvcnRlZAo+IC0JICogZG1hLWFk ZHJlc3MuCj4gLQkgKi8KPiAtCWRtYV9zeW5jX3NnX2Zvcl9kZXZpY2UoZGV2LT5kZXYsIHNndC0+ c2dsLAo+IC0JCQlzZ3QtPm5lbnRzLCBETUFfQklESVJFQ1RJT05BTCk7Cj4gLQo+IC0JYm8tPnBh Z2VzID0gcGFnZXM7Cj4gLQliby0+dGFibGUgPSBzZ3Q7Cj4gLQo+IC0JcmV0dXJuIHBhZ2VzOwo+ IC19Cj4gLQo+ICBzdGF0aWMgc3RydWN0IHBhZ2UgKip2Z2VtX3Bpbl9wYWdlcyhzdHJ1Y3QgZHJt X3ZnZW1fZ2VtX29iamVjdCAqYm8pCj4gIHsKPiAtCXN0cnVjdCBwYWdlICoqcGFnZXM7Cj4gLQo+ ICAJbXV0ZXhfbG9jaygmYm8tPnBhZ2VzX2xvY2spOwo+IC0JaWYgKGJvLT5wYWdlc19waW5fY291 bnQrKyA9PSAwICYmICFiby0+cGFnZXMpIHsKPiAtCQlwYWdlcyA9IHBpbl9hbmRfc3luYyhibyk7 Cj4gLQl9IGVsc2Ugewo+IC0JCVdBUk5fT04oIWJvLT5wYWdlcyk7Cj4gLQkJcGFnZXMgPSBiby0+ cGFnZXM7Cj4gKwlpZiAoYm8tPnBhZ2VzX3Bpbl9jb3VudCsrID09IDApIHsKPiArCQlzdHJ1Y3Qg cGFnZSAqKnBhZ2VzOwo+ICsKPiArCQlwYWdlcyA9IGRybV9nZW1fZ2V0X3BhZ2VzKCZiby0+YmFz ZSk7Cj4gKwkJaWYgKElTX0VSUihwYWdlcykpIHsKPiArCQkJYm8tPnBhZ2VzX3Bpbl9jb3VudC0t Owo+ICsJCQltdXRleF91bmxvY2soJmJvLT5wYWdlc19sb2NrKTsKPiArCQkJcmV0dXJuIHBhZ2Vz Owo+ICsJCX0KPiArCj4gKwkJYm8tPnBhZ2VzID0gcGFnZXM7Cj4gIAl9Cj4gIAltdXRleF91bmxv Y2soJmJvLT5wYWdlc19sb2NrKTsKPiAgCj4gLQlyZXR1cm4gcGFnZXM7Cj4gKwlyZXR1cm4gYm8t PnBhZ2VzOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCB2Z2VtX3VucGluX3BhZ2VzKHN0cnVjdCBk cm1fdmdlbV9nZW1fb2JqZWN0ICpibykKPiAgewo+IC0JLyoKPiAtCSAqIFdlIHNob3VsZG4ndCBo aXQgdGhpcyBmb3IgaW1wb3J0ZWQgYm8ncy4uIGluIHRoZSBpbXBvcnQKPiAtCSAqIGNhc2Ugd2Ug ZG9uJ3Qgb3duIHRoZSBzY2F0dGVyLXRhYmxlCj4gLQkgKi8KPiAtCVdBUk5fT04oYm8tPmJhc2Uu aW1wb3J0X2F0dGFjaCk7Cj4gLQo+ICAJbXV0ZXhfbG9jaygmYm8tPnBhZ2VzX2xvY2spOwo+ICAJ aWYgKC0tYm8tPnBhZ2VzX3Bpbl9jb3VudCA9PSAwKSB7Cj4gLQkJV0FSTl9PTighYm8tPnRhYmxl KTsKPiAtCQlzeW5jX2FuZF91bnBpbihibyk7Cj4gKwkJZHJtX2dlbV9wdXRfcGFnZXMoJmJvLT5i YXNlLCBiby0+cGFnZXMsIHRydWUsIHRydWUpOwo+ICsJCWJvLT5wYWdlcyA9IE5VTEw7Cj4gIAl9 Cj4gIAltdXRleF91bmxvY2soJmJvLT5wYWdlc19sb2NrKTsKPiAgfQo+IEBAIC0zNTksMTIgKzMx NywxOCBAQCBzdGF0aWMgdm9pZCB2Z2VtX3VucGluX3BhZ2VzKHN0cnVjdCBkcm1fdmdlbV9nZW1f b2JqZWN0ICpibykKPiAgc3RhdGljIGludCB2Z2VtX3ByaW1lX3BpbihzdHJ1Y3QgZHJtX2dlbV9v YmplY3QgKm9iaikKPiAgewo+ICAJc3RydWN0IGRybV92Z2VtX2dlbV9vYmplY3QgKmJvID0gdG9f dmdlbV9ibyhvYmopOwo+ICsJbG9uZyBuX3BhZ2VzID0gb2JqLT5zaXplID4+IFBBR0VfU0hJRlQ7 Cj4gIAlzdHJ1Y3QgcGFnZSAqKnBhZ2VzOwo+ICAKPiAgCXBhZ2VzID0gdmdlbV9waW5fcGFnZXMo Ym8pOwo+ICAJaWYgKElTX0VSUihwYWdlcykpCj4gIAkJcmV0dXJuIFBUUl9FUlIocGFnZXMpOwo+ ICAKPiArCS8qIEZsdXNoIHRoZSBvYmplY3QgZnJvbSB0aGUgQ1BVIGNhY2hlIHNvIHRoYXQgaW1w b3J0ZXJzIGNhbiByZWx5Cj4gKwkgKiBvbiBjb2hlcmVudCBpbmRpcmVjdCBhY2Nlc3MgdmlhIHRo ZSBleHBvcnRlZCBkbWEtYWRkcmVzcy4KPiArCSAqLwo+ICsJZHJtX2NsZmx1c2hfcGFnZXMocGFn ZXMsIG5fcGFnZXMpOwo+ICsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC0tIAo+IDIuMjMuMC5y YzAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBP UwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=