Re: [Intel-gfx] [PATCH v3 16/37] drm/i915/lmem: support CPU relocations

Chris Wilson
2019-08-10T10:50:01Z

Quoting Matthew Auld (2019-08-09 23:26:22)
> @@ -1017,10 +1020,14 @@ static void reloc_cache_reset(struct reloc_cache *cache)
> } else {
> struct i915_ggtt *ggtt = cache_to_ggtt(cache);
>
> - intel_gt_flush_ggtt_writes(ggtt->vm.gt);
> + if (!cache->is_lmem)
> + intel_gt_flush_ggtt_writes(ggtt->vm.gt);

I love an optimist. At the least you might need the wmb(). But we have
yet to see how many mistakes they've carried over into the new
implementation ;)
-Chris