Re: [PATCH v2 26/40] HACK: drm/i915/tgl: Gen12 render context size

Chris Wilson
2019-08-22T13:48:07Z

Quoting Mika Kuoppala (2019-08-22 14:42:58)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Quoting Lucas De Marchi (2019-08-17 10:38:48)
> >> From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> >>
> >> Re-use Gen11 context size for now.
> >>
> >> [ Lucas: add HACK since this is a temporary patch that needs to be
> >> confirmed: we need to check BSpec 46255 and recompute ]
> >
> > We can drop the HACK and just refer to this as a temporary patch. We
> > have selftests and runtime verification to catch if we under allocate,
> > so if our testing is clean, it's good enough for the time being.
>
> I think I had a script somewhere which can calculate the
> context size from bspec (Cut paste). No promises tho.
>
> Howabout making a selftest to figure out the context state size?

For fun, we expect the context size to be variable dependent on
workload. I thought a single selftest would do the trick, but had to
settle for runtime checking just in case we hit a corner case we didn't
account for.
-Chris