From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 02/19] drm/atomic-helper: Make crtc helper funcs optional
Date: Thu, 5 Sep 2019 14:00:17 +0300 [thread overview]
Message-ID: <20190905110017.GG7482@intel.com> (raw)
In-Reply-To: <c6a71b0cc71d4be43e2e650a95ec2e7259e7e61c.camel@intel.com>
On Thu, Sep 05, 2019 at 06:38:30AM +0000, Lisovskiy, Stanislav wrote:
> On Mon, 2019-07-08 at 15:53 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Allow drivers to call drm_atomic_helper_check_modeset() without
> > having the crtc helper funcs specified. i915 doesn't need those
> > anymore.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_atomic_helper.c
> > b/drivers/gpu/drm/drm_atomic_helper.c
> > index aa16ea17ff9b..fb2ce692ae5b 100644
> > --- a/drivers/gpu/drm/drm_atomic_helper.c
> > +++ b/drivers/gpu/drm/drm_atomic_helper.c
> > @@ -481,7 +481,7 @@ mode_fixup(struct drm_atomic_state *state)
> > continue;
> >
> > funcs = crtc->helper_private;
> > - if (!funcs->mode_fixup)
> > + if (!funcs || !funcs->mode_fixup)
> > continue;
> >
> > ret = funcs->mode_fixup(crtc, &new_crtc_state->mode,
>
> But it still won't allow to call anything from here, if no funcs or no
> mode_fixup is specified. Anyway seems to be a good idea to check both
> funcs or funcs->mode_fixup being NULL, just don't get the commit
> message a bit :)
NULL->mode_fixup will oops.
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-05 11:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 12:53 [PATCH 00/19] drm/i915: Plane cdclk requirements and fp16 for gen4+ Ville Syrjala
2019-07-08 12:53 ` [PATCH 01/19] drm: Add drm_modeset_lock_assert_held() Ville Syrjala
2019-07-08 12:53 ` [PATCH 02/19] drm/atomic-helper: Make crtc helper funcs optional Ville Syrjala
2019-09-05 6:38 ` Lisovskiy, Stanislav
2019-09-05 11:00 ` Ville Syrjälä [this message]
2019-09-18 13:42 ` Lisovskiy, Stanislav
2019-09-19 18:47 ` Ville Syrjälä
2019-07-08 12:53 ` [PATCH 03/19] drm/i915: Remove pointless planes_changed=true assignment Ville Syrjala
2019-09-05 6:40 ` Lisovskiy, Stanislav
2019-07-08 12:53 ` [PATCH 04/19] drm/i915: Replace is_planar_yuv_format() with drm_format_info_is_yuv_semiplanar() Ville Syrjala
2019-07-08 12:53 ` [PATCH 05/19] drm/i915: Allow downscale factor of <3.0 on glk+ for all formats Ville Syrjala
2019-09-11 9:53 ` Maarten Lankhorst
2019-09-11 10:39 ` [Intel-gfx] " Ville Syrjälä
2019-07-08 12:53 ` [PATCH 06/19] drm/i915: Extract intel_modeset_calc_cdclk() Ville Syrjala
2019-07-08 12:53 ` [PATCH 07/19] drm/i915: s/pipe_config/crtc_state/ in intel_crtc_atomic_check() Ville Syrjala
2019-07-08 12:53 ` [PATCH 08/19] drm/i915: Stop using drm_atomic_helper_check_planes() Ville Syrjala
2019-09-05 6:44 ` Lisovskiy, Stanislav
2019-09-19 11:15 ` Maarten Lankhorst
2019-07-08 12:53 ` [PATCH 09/19] drm/i915: Add debugs to distingiush a cd2x update from a full cdclk pll update Ville Syrjala
2019-07-08 12:53 ` [PATCH 10/19] drm/i915: Make .modeset_calc_cdclk() mandatory Ville Syrjala
2019-09-19 11:01 ` [Intel-gfx] " Maarten Lankhorst
2019-07-08 12:53 ` [PATCH 11/19] drm/i915: Rework global state locking Ville Syrjala
2019-07-08 12:53 ` [PATCH 12/19] drm/i915: Move check_digital_port_conflicts() earier Ville Syrjala
2019-07-08 12:53 ` [PATCH 13/19] drm/i915: Allow planes to declare their minimum acceptable cdclk Ville Syrjala
2019-07-08 12:53 ` [PATCH 14/19] drm/i915: Eliminate skl_check_pipe_max_pixel_rate() Ville Syrjala
2019-07-08 12:53 ` [PATCH 15/19] drm/i915: Simplify skl_max_scale() Ville Syrjala
2019-09-16 20:01 ` Juha-Pekka Heikkilä
2019-07-08 12:53 ` [PATCH 16/19] drm/i915: Add support for half float framebuffers for skl+ Ville Syrjala
2019-07-08 12:53 ` [PATCH 17/19] drm/i915: Add support for half float framebuffers for gen4+ primary planes Ville Syrjala
2019-07-08 12:53 ` [PATCH 18/19] drm/i915: Add support for half float framebuffers for ivb+ sprites Ville Syrjala
2019-07-08 12:53 ` [PATCH 19/19] drm/i915: Add support for half float framebuffers on snb sprites Ville Syrjala
2019-07-08 13:13 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Plane cdclk requirements and fp16 for gen4+ Patchwork
2019-07-08 13:21 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-07-08 13:33 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-08 19:41 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905110017.GG7482@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).