From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v3 4/9] drm/i915/tgl: Add dkl phy programming sequences Date: Tue, 24 Sep 2019 16:00:06 +0300 Message-ID: <20190924130006.GA25906@ideak-desk.fi.intel.com> References: <20190923195513.207536-1-jose.souza@intel.com> <20190923195513.207536-5-jose.souza@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D555A89274 for ; Tue, 24 Sep 2019 13:01:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: Intel Graphics List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBTZXAgMjMsIDIwMTkgYXQgMDM6MDI6NTRQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE9uIE1vbiwgU2VwIDIzLCAyMDE5IGF0IDEyOjU1IFBNIEpvc8OpIFJvYmVydG8g ZGUgU291emEKPiA8am9zZS5zb3V6YUBpbnRlbC5jb20+IHdyb3RlOgo+ID4gWy4uLl0KPiAKPiA+ ICsgICAgICAgICAgICAgICBsbjEgJj0gfihES0xfRFBfTU9ERV9DRkdfRFBfWDFfTU9ERSB8IERL TF9EUF9NT0RFX0NGR19EUF9YMl9NT0RFKTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBsYW5l X21hc2sgPSBpbnRlbF90Y19wb3J0X2dldF9sYW5lX21hc2soaW50ZWxfZGlnX3BvcnQpOyAvKiBE UFg0VFhMQVRDICovCj4gPiArICAgICAgICAgICAgICAgcGluX21hc2sgPSBpbnRlbF90Y19wb3J0 X2dldF9waW5fYXNzaWdubWVudF9tYXNrKGludGVsX2RpZ19wb3J0KTsgLyogRFBQQVRDICovCj4g PiArCj4gPiArICAgICAgICAgICAgICAgc3dpdGNoIChwaW5fbWFzaykgewo+IAo+IEZyb20gYSBx dWljayBsb29rIHRvIHRoZSB0YWJsZSwgd2UgZG9uJ3QgY2hhbmdlIGJhc2VkIG9uIHBpbl9tYXNr LCBidXQKPiByYXRoZXIgYmFzZWQgb24gbGFuZV9tYXNrLCBqdXN0IGxpa2UgZm9yIE1HLgoKVGhl cmUgYXJlIGRpZmZlcmVuY2VzLCBmb3IgaW5zdGFuY2UgcGluX21hc2s9MHg0LDB4Ni9sYW5lX21h c2s9MHgzIHZzLgpwaW5fbWFzaz0weDIvbGFuZV9tYXNrPTB4My4KCj4gQnR3LCBsYW5lX21hc2sg aXMgdW51c2VkIGluIHRoaXMgZnVuY3Rpb24gbm93IGFuZCB3ZSBkb24ndCBnZXQgYQo+IHdhcm5p bmcganVzdCBiZWNhdXNlIGl0J3MgbWlzdXNlZCBpbiBhCj4gTUlTU0lOR19DQVNFKCkgYmVsb3cu Cj4gCj4gVGhlIHZhbHVlcyBkbyBjaGFuZ2UgYmFzZWQgb24gd2lkdGgsIGJ1dCBJJ20gbm90IHN1 cmUgd2h5IE1HIGRvZXNuJ3QKPiBuZWVkIHRvIHRha2UgdGhhdCBpbnRvIGFjY291bnQuCgpZZXMs IGxvb2tzIGxpa2UgY3J0Y19zdGF0ZS0+bGFuZV9jb3VudCBzaG91bGQgYmUgY29uc2lkZXJlZC4g Tm90IHN1cmUKd2h5IHRoZSBNRyB2ZXJzaW9uIGRvZXNuJ3QgZG8gdGhhdCBlaXRoZXIsIEkgYXNz dW1lIGl0IHdhcyBhbiBhZGRpdGlvbgp0byBCU3BlYyBvbmx5IGFmdGVyIHRoZSBmdW5jdGlvbiB3 YXMgYWRkZWQuIFRoZSBzYW1lIGFwcGxpZXMgdG8KcGluX21hc2suCgo+ICtJbXJlIERlYWsKPiAK PiBMdWNhcyBEZSBNYXJjaGkKPiAKPiA+ICsgICAgICAgICAgICAgICBjYXNlIDB4MDoKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIGlmIChudW1fbGFuZXMgPT0gMSkgewo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBsbjEgfD0gREtMX0RQX01PREVfQ0ZHX0RQX1gxX01PREU7 Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2Ugewo+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBsbjAgfD0gREtMX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxuMSB8PSBES0xfRFBfTU9ERV9DRkdfRFBf WDJfTU9ERTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIH0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgIGJyZWFrOwo+ID4gKyAgICAgICAgICAgICAgIGNhc2UgMHgxOgo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgaWYgKG51bV9sYW5lcyA9PSA0KSB7Cj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGxuMCB8PSBES0xfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG4xIHw9IERLTF9EUF9NT0RFX0NGR19E UF9YMl9NT0RFOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgfQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgYnJlYWs7Cj4gPiArICAgICAgICAgICAgICAgY2FzZSAweDI6Cj4gPiArICAg ICAgICAgICAgICAgICAgICAgICBpZiAobnVtX2xhbmVzID09IDIpIHsKPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbG4wIHw9IERLTF9EUF9NT0RFX0NGR19EUF9YMl9NT0RFOwo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsbjEgfD0gREtMX0RQX01PREVfQ0ZH X0RQX1gyX01PREU7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICB9Cj4gPiArICAgICAgICAg ICAgICAgICAgICAgICBicmVhazsKPiA+ICsgICAgICAgICAgICAgICBjYXNlIDB4MzoKPiA+ICsg ICAgICAgICAgICAgICBjYXNlIDB4NToKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmIChu dW1fbGFuZXMgPT0gMSkgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsbjAg fD0gREtMX0RQX01PREVfQ0ZHX0RQX1gxX01PREU7Cj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxuMSB8PSBES0xfRFBfTU9ERV9DRkdfRFBfWDFfTU9ERTsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGxuMCB8PSBES0xfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbG4xIHw9IERLTF9EUF9NT0RFX0NGR19EUF9YMl9NT0RFOwo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgfQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7Cj4gPiArICAgICAgICAgICAgICAgY2FzZSAweDQ6Cj4gPiArICAgICAgICAgICAgICAgY2Fz ZSAweDY6Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAobnVtX2xhbmVzID09IDEpIHsK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG4wIHw9IERLTF9EUF9NT0RFX0NG R19EUF9YMV9NT0RFOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsbjEgfD0g REtMX0RQX01PREVfQ0ZHX0RQX1gxX01PREU7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICB9 IGVsc2Ugewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsbjAgfD0gREtMX0RQ X01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGxuMSB8PSBES0xfRFBfTU9ERV9DRkdfRFBfWDJfTU9ERTsKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIH0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ID4gKyAgICAgICAg ICAgICAgIGRlZmF1bHQ6Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBNSVNTSU5HX0NBU0Uo bGFuZV9tYXNrKTsKPiA+ICsgICAgICAgICAgICAgICB9Cj4gPiArICAgICAgICAgICAgICAgYnJl YWs7Cj4gPiArCj4gPiArICAgICAgIGNhc2UgVENfUE9SVF9MRUdBQ1k6Cj4gPiArICAgICAgICAg ICAgICAgbG4wIHw9IERLTF9EUF9NT0RFX0NGR19EUF9YMV9NT0RFIHwgREtMX0RQX01PREVfQ0ZH X0RQX1gyX01PREU7Cj4gPiArICAgICAgICAgICAgICAgbG4xIHw9IERLTF9EUF9NT0RFX0NGR19E UF9YMV9NT0RFIHwgREtMX0RQX01PREVfQ0ZHX0RQX1gyX01PREU7Cj4gPiArICAgICAgICAgICAg ICAgYnJlYWs7Cj4gPiArCj4gPiArICAgICAgIGRlZmF1bHQ6Cj4gPiArICAgICAgICAgICAgICAg TUlTU0lOR19DQVNFKGludGVsX2RpZ19wb3J0LT50Y19tb2RlKTsKPiA+ICsgICAgICAgICAgICAg ICByZXR1cm47Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICsgICAgICAgSTkxNV9XUklURShISVBf SU5ERVhfUkVHKHRjX3BvcnQpLCBISVBfSU5ERVhfVkFMKHRjX3BvcnQsIDB4MCkpOwo+ID4gKyAg ICAgICBJOTE1X1dSSVRFKERLTF9EUF9NT0RFKHRjX3BvcnQpLCBsbjApOwo+ID4gKyAgICAgICBJ OTE1X1dSSVRFKEhJUF9JTkRFWF9SRUcodGNfcG9ydCksIEhJUF9JTkRFWF9WQUwodGNfcG9ydCwg MHgxKSk7Cj4gPiArICAgICAgIEk5MTVfV1JJVEUoREtMX0RQX01PREUodGNfcG9ydCksIGxuMSk7 Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyB2b2lkIGludGVsX2RwX3Npbmtfc2V0X2ZlY19yZWFk eShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl KQo+ID4gIHsKPiA+IEBAIC0zMjE4LDcgKzM0MzEsNyBAQCBzdGF0aWMgdm9pZCB0Z2xfZGRpX3By ZV9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlnX3BvcnQtPmRkaV9pb19wb3dlcl9kb21h aW4pOwo+ID4KPiA+ICAgICAgICAgLyogNi4gKi8KPiA+IC0gICAgICAgaWNsX3Byb2dyYW1fbWdf ZHBfbW9kZShkaWdfcG9ydCk7Cj4gPiArICAgICAgIHRnbF9wcm9ncmFtX2RrbF9kcF9tb2RlKGRp Z19wb3J0KTsKPiA+Cj4gPiAgICAgICAgIC8qCj4gPiAgICAgICAgICAqIDcuYSAtIFN0ZXBzIGlu IHRoaXMgZnVuY3Rpb24gc2hvdWxkIG9ubHkgYmUgZXhlY3V0ZWQgb3bCtGVyIE1TVAo+ID4gQEAg LTMyMzEsMTAgKzM0NDQsMTAgQEAgc3RhdGljIHZvaWQgdGdsX2RkaV9wcmVfZW5hYmxlX2RwKHN0 cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gICAgICAgICBpbnRlbF9kZGlfY29uZmln X3RyYW5zY29kZXJfZnVuYyhjcnRjX3N0YXRlKTsKPiA+Cj4gPiAgICAgICAgIC8qIDcuZCAqLwo+ ID4gLSAgICAgICBpY2xfcGh5X3NldF9jbG9ja19nYXRpbmcoZGlnX3BvcnQsIGZhbHNlKTsKPiA+ ICsgICAgICAgdGdsX3BoeV9zZXRfY2xvY2tfZ2F0aW5nKGRpZ19wb3J0LCBmYWxzZSk7Cj4gPgo+ ID4gICAgICAgICAvKiA3LmUgKi8KPiA+IC0gICAgICAgaWNsX2RkaV92c3dpbmdfc2VxdWVuY2Uo ZW5jb2RlciwgY3J0Y19zdGF0ZS0+cG9ydF9jbG9jaywgbGV2ZWwsCj4gPiArICAgICAgIHRnbF9k ZGlfdnN3aW5nX3NlcXVlbmNlKGVuY29kZXIsIGNydGNfc3RhdGUtPnBvcnRfY2xvY2ssIGxldmVs LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbmNvZGVyLT50eXBlKTsKPiA+ Cj4gPiAgICAgICAgIC8qIDcuZiAqLwo+ID4gQEAgLTMyNjYsNiArMzQ3OSwxNSBAQCBzdGF0aWMg dm9pZCB0Z2xfZGRpX3ByZV9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIs Cj4gPiAgICAgICAgIC8qIDcuayAqLwo+ID4gICAgICAgICBpbnRlbF9kcF9zdG9wX2xpbmtfdHJh aW4oaW50ZWxfZHApOwo+ID4KPiA+ICsgICAgICAgLyoKPiA+ICsgICAgICAgICogVE9ETzogZW5h YmxlIGNsb2NrIGdhdGluZwo+ID4gKyAgICAgICAgKgo+ID4gKyAgICAgICAgKiBJdCBpcyBub3Qg d3JpdHRlbiBpbiBEUCBlbmFibGluZyBzZXF1ZW5jZSBidXQgIlBIWSBDbG9ja2dhdGluZwo+ID4g KyAgICAgICAgKiBwcm9ncmFtbWluZyIgc3RhdGVzIHRoYXQgY2xvY2sgZ2F0aW5nIHNob3VsZCBi ZSBlbmFibGVkIGFmdGVyIHRoZQo+ID4gKyAgICAgICAgKiBsaW5rIHRyYWluaW5nIGJ1dCBkb2lu ZyBzbyBjYXVzZXMgYWxsIHRoZSBmb2xsb3dpbmcgdHJhaW5pbmdzIHRvIGZhaWwKPiA+ICsgICAg ICAgICogc28gbm90IGVuYWJsaW5nIGl0IGZvciBub3cuCj4gPiArICAgICAgICAqLwo+ID4gKwo+ ID4gICAgICAgICAvKiA3LmwgKi8KPiA+ICAgICAgICAgaW50ZWxfZGRpX2VuYWJsZV9mZWMoZW5j b2RlciwgY3J0Y19zdGF0ZSk7Cj4gPiAgICAgICAgIGludGVsX2RzY19lbmFibGUoZW5jb2Rlciwg Y3J0Y19zdGF0ZSk7Cj4gPiBAQCAtMzM3MSw5ICszNTkzLDE1IEBAIHN0YXRpYyB2b2lkIGludGVs X2RkaV9wcmVfZW5hYmxlX2hkbWkoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiAg ICAgICAgIGludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBkaWdfcG9ydC0+ZGRpX2lv X3Bvd2VyX2RvbWFpbik7Cj4gPgo+ID4gICAgICAgICBpY2xfcHJvZ3JhbV9tZ19kcF9tb2RlKGRp Z19wb3J0KTsKPiA+IC0gICAgICAgaWNsX3BoeV9zZXRfY2xvY2tfZ2F0aW5nKGRpZ19wb3J0LCBm YWxzZSk7Cj4gPiArICAgICAgIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEyKQo+ID4gKyAg ICAgICAgICAgICAgIHRnbF9waHlfc2V0X2Nsb2NrX2dhdGluZyhkaWdfcG9ydCwgZmFsc2UpOwo+ ID4gKyAgICAgICBlbHNlCj4gPiArICAgICAgICAgICAgICAgaWNsX3BoeV9zZXRfY2xvY2tfZ2F0 aW5nKGRpZ19wb3J0LCBmYWxzZSk7Cj4gPgo+ID4gLSAgICAgICBpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSAxMSkKPiA+ICsgICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTIpCj4g PiArICAgICAgICAgICAgICAgdGdsX2RkaV92c3dpbmdfc2VxdWVuY2UoZW5jb2RlciwgY3J0Y19z dGF0ZS0+cG9ydF9jbG9jaywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBsZXZlbCwgSU5URUxfT1VUUFVUX0hETUkpOwo+ID4gKyAgICAgICBlbHNlIGlmIChJTlRF TF9HRU4oZGV2X3ByaXYpID09IDExKQo+ID4gICAgICAgICAgICAgICAgIGljbF9kZGlfdnN3aW5n X3NlcXVlbmNlKGVuY29kZXIsIGNydGNfc3RhdGUtPnBvcnRfY2xvY2ssCj4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGV2ZWwsIElOVEVMX09VVFBVVF9IRE1JKTsK PiA+ICAgICAgICAgZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpCj4gPiBAQCAtMzM4 Myw3ICszNjExLDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wcmVfZW5hYmxlX2hkbWkoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiAgICAgICAgIGVsc2UKPiA+ICAgICAgICAg ICAgICAgICBpbnRlbF9wcmVwYXJlX2hkbWlfZGRpX2J1ZmZlcnMoZW5jb2RlciwgbGV2ZWwpOwo+ ID4KPiA+IC0gICAgICAgaWNsX3BoeV9zZXRfY2xvY2tfZ2F0aW5nKGRpZ19wb3J0LCB0cnVlKTsK PiA+ICsgICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTIpCj4gPiArICAgICAgICAg ICAgICAgdGdsX3BoeV9zZXRfY2xvY2tfZ2F0aW5nKGRpZ19wb3J0LCB0cnVlKTsKPiA+ICsgICAg ICAgZWxzZQo+ID4gKyAgICAgICAgICAgICAgIGljbF9waHlfc2V0X2Nsb2NrX2dhdGluZyhkaWdf cG9ydCwgdHJ1ZSk7Cj4gPgo+ID4gICAgICAgICBpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikpCj4g PiAgICAgICAgICAgICAgICAgc2tsX2RkaV9zZXRfaWJvb3N0KGVuY29kZXIsIGxldmVsLCBJTlRF TF9PVVRQVVRfSERNSSk7Cj4gPiAtLQo+ID4gMi4yMy4wCj4gPgo+ID4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gCj4gCj4gLS0g Cj4gTHVjYXMgRGUgTWFyY2hpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeA==