From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 07/23] drm/i915: Remove begin/finish_crtc_commit. Date: Wed, 25 Sep 2019 15:14:53 -0700 Message-ID: <20190925221452.GC22579@intel.com> References: <20190920114235.22411-1-maarten.lankhorst@linux.intel.com> <20190920114235.22411-7-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE9A86F644 for ; Wed, 25 Sep 2019 22:13:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190920114235.22411-7-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWFhcnRlbiwKCkNvdWxkIHlvdSBob2xkIG9mZiBvbiBtZXJnaW5nIHRoaXMgcGF0Y2ggYW5k IGJpZyBqb2luZXIgZW5hYmxpbmcgcGF0Y2ggZWxzZQpteSAycDJwIHNlcmllcyB3aGljaCBpcyBh bG1vc3QgcmVhZHkgdG8gbWVyZ2UgZXhjZXB0IGZvciB0aGUgZmluYWwgci1iIGZyb20geW91Cm9u IHRoZSBIVyBzdGF0ZSBwYXRjaCB3aWxsIG5lZWQgdG8gcmViYXNlZCBhbmQgdGhhdCB3aWxsIGRl bGF5IHRoZSBsYW5kaW5nIG9mIHRoZQpzZXJpZXMuCgpNYW5hc2kKCgpPbiBGcmksIFNlcCAyMCwg MjAxOSBhdCAwMTo0MjoxOVBNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiBUaGlz IGNhbiBhbGwgYmUgZG9uZSBmcm9tIHRoZSBpbnRlbF91cGRhdGVfY3J0YyBmdW5jdGlvbi4gU3Bs aXQgb3V0IHRoZQo+IHBpcGUgdXBkYXRlIGludG8gYSBzZXBhcmF0ZSBmdW5jdGlvbiwganVzdCBs aWtlIGlzIGRvbmUgZm9yIHRoZSBwbGFuZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgfCAxMjQgKysrKysrKyst LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTIgaW5zZXJ0aW9ucygrKSwgNzIgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5 LmMKPiBpbmRleCA1MjBjNjYwNzFlNjcuLmZkOGIzOTg3MzNiOCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEzNiw4ICsxMzYsNiBA QCBzdGF0aWMgdm9pZCB2bHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4g IAkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpOwo+ICBz dGF0aWMgdm9pZCBjaHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJ CSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpOwo+IC1zdGF0 aWMgdm9pZCBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdChzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRl ICosIHN0cnVjdCBpbnRlbF9jcnRjICopOwo+IC1zdGF0aWMgdm9pZCBpbnRlbF9maW5pc2hfY3J0 Y19jb21taXQoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqLCBzdHJ1Y3QgaW50ZWxfY3J0YyAq KTsKPiAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19pbml0X3NjYWxlcnMoc3RydWN0IGludGVsX2Ny dGMgKmNydGMsCj4gIAkJCQkgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUp Owo+ICBzdGF0aWMgdm9pZCBza3lsYWtlX3BmaXRfZW5hYmxlKGNvbnN0IHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPiBAQCAtMTM2NzMsMTMgKzEzNjcxLDU0IEBAIHUzMiBp bnRlbF9jcnRjX2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAg CXJldHVybiBjcnRjLT5iYXNlLmZ1bmNzLT5nZXRfdmJsYW5rX2NvdW50ZXIoJmNydGMtPmJhc2Up Owo+ICB9Cj4gIAo+ICt2b2lkIGludGVsX2NydGNfYXJtX2ZpZm9fdW5kZXJydW4oc3RydWN0IGlu dGVsX2NydGMgKmNydGMsCj4gKwkJCQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1 KGNydGMtPmJhc2UuZGV2KTsKPiArCj4gKwlpZiAoIUlTX0dFTihkZXZfcHJpdiwgMikpCj4gKwkJ aW50ZWxfc2V0X2NwdV9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgY3J0Yy0+cGlw ZSwgdHJ1ZSk7Cj4gKwo+ICsJaWYgKGNydGNfc3RhdGUtPmhhc19wY2hfZW5jb2Rlcikgewo+ICsJ CWVudW0gcGlwZSBwY2hfdHJhbnNjb2RlciA9Cj4gKwkJCWludGVsX2NydGNfcGNoX3RyYW5zY29k ZXIoY3J0Yyk7Cj4gKwo+ICsJCWludGVsX3NldF9wY2hfZmlmb191bmRlcnJ1bl9yZXBvcnRpbmco ZGV2X3ByaXYsIHBjaF90cmFuc2NvZGVyLCB0cnVlKTsKPiArCX0KPiArfQo+ICsKPiArc3RhdGlj IHZvaWQgY29tbWl0X3BpcGVfY29uZmlnKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRl LAo+ICsJCQkgICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLAo+ ICsJCQkgICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlKQo+ICt7 Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHN0YXRlLT5i YXNlLmRldik7Cj4gKwlib29sIG1vZGVzZXQgPSBuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRl KTsKPiArCj4gKwlpZiAoIW1vZGVzZXQpIHsKPiArCQlpZiAobmV3X2NydGNfc3RhdGUtPnVhcGku Y29sb3JfbWdtdF9jaGFuZ2VkIHx8Cj4gKwkJICAgIG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlw ZSkKPiArCQkJaW50ZWxfY29sb3JfY29tbWl0KG5ld19jcnRjX3N0YXRlKTsKPiArCj4gKwkJaWYg KG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlwZSkKPiArCQkJaW50ZWxfdXBkYXRlX3BpcGVfY29u ZmlnKG9sZF9jcnRjX3N0YXRlLCBuZXdfY3J0Y19zdGF0ZSk7Cj4gKwkJZWxzZSBpZiAoSU5URUxf R0VOKGRldl9wcml2KSA+PSA5KQo+ICsJCQlza2xfZGV0YWNoX3NjYWxlcnMobmV3X2NydGNfc3Rh dGUpOwo+ICsKPiArCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5IHx8IElTX0JST0FEV0VM TChkZXZfcHJpdikpCj4gKwkJCWJkd19zZXRfcGlwZW1pc2MobmV3X2NydGNfc3RhdGUpOwo+ICsJ fQo+ICsKPiArCWlmIChkZXZfcHJpdi0+ZGlzcGxheS5hdG9taWNfdXBkYXRlX3dhdGVybWFya3Mp Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuYXRvbWljX3VwZGF0ZV93YXRlcm1hcmtzKHN0YXRlLAo+ ICsJCQkJCQkJICAgbmV3X2NydGNfc3RhdGUpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBpbnRl bF91cGRhdGVfY3J0YyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCQkJICAgICAgc3RydWN0 IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAkJCSAgICAgIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiAgCQkJICAgICAgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKm5ld19jcnRjX3N0YXRlKQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gc3Rh dGUtPmJhc2UuZGV2Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShzdGF0ZS0+YmFzZS5kZXYpOwo+ICAJYm9vbCBtb2Rlc2V0ID0gbmVlZHNfbW9kZXNldChuZXdf Y3J0Y19zdGF0ZSk7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKm5ld19wbGFuZV9zdGF0 ZSA9Cj4gIAkJaW50ZWxfYXRvbWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RhdGUsCj4gQEAgLTEz NzAzLDE0ICsxMzc0MiwyMSBAQCBzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0YyhzdHJ1Y3Qg aW50ZWxfY3J0YyAqY3J0YywKPiAgCWVsc2UgaWYgKG5ld19wbGFuZV9zdGF0ZSkKPiAgCQlpbnRl bF9mYmNfZW5hYmxlKGNydGMsIG5ld19jcnRjX3N0YXRlLCBuZXdfcGxhbmVfc3RhdGUpOwo+ICAK PiAtCWludGVsX2JlZ2luX2NydGNfY29tbWl0KHN0YXRlLCBjcnRjKTsKPiArCS8qIFBlcmZvcm0g dmJsYW5rIGV2YXNpb24gYXJvdW5kIGNvbW1pdCBvcGVyYXRpb24gKi8KPiArCWludGVsX3BpcGVf dXBkYXRlX3N0YXJ0KG5ld19jcnRjX3N0YXRlKTsKPiArCj4gKwljb21taXRfcGlwZV9jb25maWco c3RhdGUsIG9sZF9jcnRjX3N0YXRlLCBuZXdfY3J0Y19zdGF0ZSk7Cj4gIAo+ICAJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPj0gOSkKPiAgCQlza2xfdXBkYXRlX3BsYW5lc19vbl9jcnRjKHN0YXRl LCBjcnRjKTsKPiAgCWVsc2UKPiAgCQlpOXh4X3VwZGF0ZV9wbGFuZXNfb25fY3J0YyhzdGF0ZSwg Y3J0Yyk7Cj4gIAo+IC0JaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0YXRlLCBjcnRjKTsKPiAr CWludGVsX3BpcGVfdXBkYXRlX2VuZChuZXdfY3J0Y19zdGF0ZSk7Cj4gKwo+ICsJaWYgKG5ld19j cnRjX3N0YXRlLT51cGRhdGVfcGlwZSAmJiAhbW9kZXNldCAmJgo+ICsJICAgIG9sZF9jcnRjX3N0 YXRlLT5ody5tb2RlLnByaXZhdGVfZmxhZ3MgJiBJOTE1X01PREVfRkxBR19JTkhFUklURUQpCj4g KwkJaW50ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihjcnRjLCBuZXdfY3J0Y19zdGF0ZSk7Cj4g IH0KPiAgCj4gIHN0YXRpYyB2b2lkIGludGVsX29sZF9jcnRjX3N0YXRlX2Rpc2FibGVzKHN0cnVj dCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+IEBAIC0xNDUwNyw3MiArMTQ1NTMsNiBAQCBz a2xfbWF4X3NjYWxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ ICAJcmV0dXJuIG1heF9zY2FsZTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaW50ZWxfYmVnaW5f Y3J0Y19jb21taXQoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gLQkJCQkgICAg c3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gLXsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+IC0Jc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlID0KPiAtCQlpbnRlbF9hdG9taWNfZ2V0X29sZF9jcnRj X3N0YXRlKHN0YXRlLCBjcnRjKTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0 Y19zdGF0ZSA9Cj4gLQkJaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0 Yyk7Cj4gLQlib29sIG1vZGVzZXQgPSBuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKTsKPiAt Cj4gLQkvKiBQZXJmb3JtIHZibGFuayBldmFzaW9uIGFyb3VuZCBjb21taXQgb3BlcmF0aW9uICov Cj4gLQlpbnRlbF9waXBlX3VwZGF0ZV9zdGFydChuZXdfY3J0Y19zdGF0ZSk7Cj4gLQo+IC0JaWYg KG1vZGVzZXQpCj4gLQkJZ290byBvdXQ7Cj4gLQo+IC0JaWYgKG5ld19jcnRjX3N0YXRlLT51YXBp LmNvbG9yX21nbXRfY2hhbmdlZCB8fAo+IC0JICAgIG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGlw ZSkKPiAtCQlpbnRlbF9jb2xvcl9jb21taXQobmV3X2NydGNfc3RhdGUpOwo+IC0KPiAtCWlmIChu ZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3BpcGUpCj4gLQkJaW50ZWxfdXBkYXRlX3BpcGVfY29uZmln KG9sZF9jcnRjX3N0YXRlLCBuZXdfY3J0Y19zdGF0ZSk7Cj4gLQllbHNlIGlmIChJTlRFTF9HRU4o ZGV2X3ByaXYpID49IDkpCj4gLQkJc2tsX2RldGFjaF9zY2FsZXJzKG5ld19jcnRjX3N0YXRlKTsK PiAtCj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5IHx8IElTX0JST0FEV0VMTChkZXZf cHJpdikpCj4gLQkJYmR3X3NldF9waXBlbWlzYyhuZXdfY3J0Y19zdGF0ZSk7Cj4gLQo+IC1vdXQ6 Cj4gLQlpZiAoZGV2X3ByaXYtPmRpc3BsYXkuYXRvbWljX3VwZGF0ZV93YXRlcm1hcmtzKQo+IC0J CWRldl9wcml2LT5kaXNwbGF5LmF0b21pY191cGRhdGVfd2F0ZXJtYXJrcyhzdGF0ZSwKPiAtCQkJ CQkJCSAgIG5ld19jcnRjX3N0YXRlKTsKPiAtfQo+IC0KPiAtdm9pZCBpbnRlbF9jcnRjX2FybV9m aWZvX3VuZGVycnVuKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+IC0JCQkJICBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAtewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gLQo+IC0JaWYgKCFJU19H RU4oZGV2X3ByaXYsIDIpKQo+IC0JCWludGVsX3NldF9jcHVfZmlmb191bmRlcnJ1bl9yZXBvcnRp bmcoZGV2X3ByaXYsIGNydGMtPnBpcGUsIHRydWUpOwo+IC0KPiAtCWlmIChjcnRjX3N0YXRlLT5o YXNfcGNoX2VuY29kZXIpIHsKPiAtCQllbnVtIHBpcGUgcGNoX3RyYW5zY29kZXIgPQo+IC0JCQlp bnRlbF9jcnRjX3BjaF90cmFuc2NvZGVyKGNydGMpOwo+IC0KPiAtCQlpbnRlbF9zZXRfcGNoX2Zp Zm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBwY2hfdHJhbnNjb2RlciwgdHJ1ZSk7Cj4g LQl9Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIGludGVsX2ZpbmlzaF9jcnRjX2NvbW1pdChzdHJ1 Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAtCQkJCSAgICAgc3RydWN0IGludGVsX2Ny dGMgKmNydGMpCj4gLXsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0 ZSA9Cj4gLQkJaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4g LQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUgPQo+IC0JCWludGVsX2F0 b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+IC0KPiAtCWludGVsX3BpcGVf dXBkYXRlX2VuZChuZXdfY3J0Y19zdGF0ZSk7Cj4gLQo+IC0JaWYgKG5ld19jcnRjX3N0YXRlLT51 cGRhdGVfcGlwZSAmJgo+IC0JICAgICFuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSAmJgo+ IC0JICAgIG9sZF9jcnRjX3N0YXRlLT5ody5tb2RlLnByaXZhdGVfZmxhZ3MgJiBJOTE1X01PREVf RkxBR19JTkhFUklURUQpCj4gLQkJaW50ZWxfY3J0Y19hcm1fZmlmb191bmRlcnJ1bihjcnRjLCBu ZXdfY3J0Y19zdGF0ZSk7Cj4gLX0KPiAtCj4gIC8qKgo+ICAgKiBpbnRlbF9wbGFuZV9kZXN0cm95 IC0gZGVzdHJveSBhIHBsYW5lCj4gICAqIEBwbGFuZTogcGxhbmUgdG8gZGVzdHJveQo+IC0tIAo+ IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=