Re: [PATCH v9 3/7] drm/i915/tgl: Enable DC3CO state in "DC Off" power well

Jani Nikula
2019-09-27T13:41:03Z

On Fri, 27 Sep 2019, Imre Deak <imre.deak@intel.com> wrote:
> On Fri, Sep 27, 2019 at 02:07:43PM +0300, Imre Deak wrote:
>> On Thu, Sep 26, 2019 at 08:26:17PM +0530, Anshuman Gupta wrote:
>> > +void tgl_set_target_dc_state(struct drm_i915_private *dev_priv, u32 state)
>
> We need a documentation for exported functions.

And really you should make an effort to *NOT* expose platform specific
functions from your C modules. Yes, we have some, but the direction
should be the opposite of adding more.

I'll be more strict about this going forward. We need to improve the
interfaces we have.

>> > @@ -256,6 +257,7 @@ void intel_display_power_suspend_late(struct drm_i915_private *i915);
>> > void intel_display_power_resume_early(struct drm_i915_private *i915);
>> > void intel_display_power_suspend(struct drm_i915_private *i915);
>> > void intel_display_power_resume(struct drm_i915_private *i915);
>> > +void tgl_set_target_dc_state(struct drm_i915_private *dev_priv, u32 state);

This sticks out like a sore thumb.

And you're not even using the function outside of intel_display_power.h!

BR,
Jani.

>> >
>> > const char *
>> > intel_display_power_domain_str(enum intel_display_power_domain domain);

--
Jani Nikula, Intel Open Source Graphics Center