From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: split out intel_vga_client.[ch]
Date: Tue, 1 Oct 2019 17:37:57 +0300 [thread overview]
Message-ID: <20191001143757.GO1208@intel.com> (raw)
In-Reply-To: <87zhikbkv0.fsf@intel.com>
On Tue, Oct 01, 2019 at 05:28:51PM +0300, Jani Nikula wrote:
> On Tue, 01 Oct 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote:
> >> Quoting Jani Nikula (2019-10-01 14:43:53)
> >> > Split out code related to vga client and vga switcheroo
> >> > register/unregister and state handling from i915_drv.c and
> >> > intel_display.c.
> >> >
> >> > It's a bit difficult to draw the line how much to move to the new file
> >> > from i915_drv.c, but it seemed to me keeping i915_suspend_switcheroo()
> >> > and i915_resume_switcheroo() in place was cleanest.
> >> >
> >> > No functional changes.
> >> >
> >> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> >
> >> > ---
> >> >
> >> > It's also a bit fuzzy if this is a sensible split anyway. Could also
> >> > name it intel_vga and move these from intel_display.c there?
> >>
> >> My initial thought that the switcheroo interface would remain in core,
> >
> > Yeah the switcheroo stuff should perhaps stays with the rest of the pm hooks.
>
> Okay, so keep all of switcheroo in i915_drv.c, and move all the vgaarb
> stuff (incl the ones I mentioned from intel_display.c) to
> intel_vga.[ch]?
I can get behind that plan.
>
> >
> >> that it is more of a global power state that we currently just use for
> >> the legacy vga switching.
> >>
> >> The patch looks fine, on a pure mechanical pov,
> >> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>
> >> For the sake of argument, could you float the split in the other
> >> direction?
>
> Please elaborate. Move switcheroo higher in the call chain?
>
> BR,
> Jani.
>
>
> >>
> >> And maybe Ville has a good opinion on how it is meant to work :)
> >> -Chris
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-01 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 13:43 [PATCH] drm/i915/display: split out intel_vga_client.[ch] Jani Nikula
2019-10-01 14:10 ` Ville Syrjälä
2019-10-01 14:12 ` Chris Wilson
2019-10-01 14:22 ` Ville Syrjälä
2019-10-01 14:28 ` Jani Nikula
2019-10-01 14:31 ` Chris Wilson
2019-10-01 14:37 ` Ville Syrjälä [this message]
2019-10-01 15:26 ` Jani Nikula
2019-10-01 16:02 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-10-01 16:39 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-02 0:52 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001143757.GO1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).