From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
Date: Wed, 2 Oct 2019 18:03:35 +0300 [thread overview]
Message-ID: <20191002150335.GX1208@intel.com> (raw)
In-Reply-To: <20191002131800.21054-1-jani.nikula@intel.com>
On Wed, Oct 02, 2019 at 04:17:57PM +0300, Jani Nikula wrote:
> Rename the function per Ville's suggestion. No functional changes.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/display/intel_vga.c | 2 +-
> drivers/gpu/drm/i915/display/intel_vga.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index bb642a1a0dd4..0616284c6da6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -267,7 +267,7 @@ static void hsw_power_well_post_enable(struct drm_i915_private *dev_priv,
> u8 irq_pipe_mask, bool has_vga)
> {
> if (has_vga)
> - intel_vga_msr_write(dev_priv);
> + intel_vga_reset_io_mem(dev_priv);
>
> if (irq_pipe_mask)
> gen8_irq_power_well_post_enable(dev_priv, irq_pipe_mask);
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
> index 732568eaa988..2ff7293986d4 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.c
> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
> @@ -72,7 +72,7 @@ void intel_vga_redisable(struct drm_i915_private *i915)
> intel_display_power_put(i915, POWER_DOMAIN_VGA, wakeref);
> }
>
> -void intel_vga_msr_write(struct drm_i915_private *i915)
> +void intel_vga_reset_io_mem(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = i915->drm.pdev;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.h b/drivers/gpu/drm/i915/display/intel_vga.h
> index 3517872e62ac..ba5b55b917f0 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.h
> +++ b/drivers/gpu/drm/i915/display/intel_vga.h
> @@ -8,7 +8,7 @@
>
> struct drm_i915_private;
>
> -void intel_vga_msr_write(struct drm_i915_private *i915);
> +void intel_vga_reset_io_mem(struct drm_i915_private *i915);
> void intel_vga_disable(struct drm_i915_private *i915);
> void intel_vga_redisable(struct drm_i915_private *i915);
> void intel_vga_redisable_power_on(struct drm_i915_private *i915);
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-02 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
2019-10-02 13:17 ` [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c Jani Nikula
2019-10-02 15:04 ` Ville Syrjälä
2019-10-02 13:17 ` [PATCH 3/4] drm/i915: register vga switcheroo later, unregister earlier Jani Nikula
2019-10-02 13:18 ` [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init() Jani Nikula
2019-10-02 15:07 ` Ville Syrjälä
2019-10-02 15:03 ` Ville Syrjälä [this message]
2019-10-02 17:28 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Patchwork
2019-10-02 17:54 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-03 10:23 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2) Patchwork
2019-10-03 10:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-03 17:34 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002150335.GX1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).