* [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
@ 2019-10-02 13:17 ` Jani Nikula
2019-10-02 15:04 ` Ville Syrjälä
2019-10-02 13:17 ` [PATCH 3/4] drm/i915: register vga switcheroo later, unregister earlier Jani Nikula
` (7 subsequent siblings)
8 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2019-10-02 13:17 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Split out code related to vga switcheroo register/unregister and state
handling from i915_drv.c into new i915_switcheroo.[ch] files.
It's a bit difficult to draw the line how much to move to the new file
from i915_drv.c, but it seemed to me keeping i915_suspend_switcheroo()
and i915_resume_switcheroo() in place was the cleanest.
No functional changes.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/i915_drv.c | 63 +++---------------------
drivers/gpu/drm/i915/i915_drv.h | 3 ++
drivers/gpu/drm/i915/i915_switcheroo.c | 67 ++++++++++++++++++++++++++
drivers/gpu/drm/i915/i915_switcheroo.h | 14 ++++++
5 files changed, 92 insertions(+), 56 deletions(-)
create mode 100644 drivers/gpu/drm/i915/i915_switcheroo.c
create mode 100644 drivers/gpu/drm/i915/i915_switcheroo.h
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index d2b53b5add81..136a1a51b6e2 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -46,6 +46,7 @@ i915-y += i915_drv.o \
i915_pci.o \
i915_scatterlist.o \
i915_suspend.o \
+ i915_switcheroo.o \
i915_sysfs.o \
i915_utils.o \
intel_csr.o \
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 3306c6bb515a..7349fd8c9796 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -72,6 +72,7 @@
#include "i915_perf.h"
#include "i915_query.h"
#include "i915_suspend.h"
+#include "i915_switcheroo.h"
#include "i915_sysfs.h"
#include "i915_trace.h"
#include "i915_vgpu.h"
@@ -269,56 +270,8 @@ intel_teardown_mchbar(struct drm_i915_private *dev_priv)
release_resource(&dev_priv->mch_res);
}
-static int i915_resume_switcheroo(struct drm_i915_private *i915);
-static int i915_suspend_switcheroo(struct drm_i915_private *i915,
- pm_message_t state);
-
-static void i915_switcheroo_set_state(struct pci_dev *pdev, enum vga_switcheroo_state state)
-{
- struct drm_i915_private *i915 = pdev_to_i915(pdev);
- pm_message_t pmm = { .event = PM_EVENT_SUSPEND };
-
- if (!i915) {
- dev_err(&pdev->dev, "DRM not initialized, aborting switch.\n");
- return;
- }
-
- if (state == VGA_SWITCHEROO_ON) {
- pr_info("switched on\n");
- i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
- /* i915 resume handler doesn't set to D0 */
- pci_set_power_state(pdev, PCI_D0);
- i915_resume_switcheroo(i915);
- i915->drm.switch_power_state = DRM_SWITCH_POWER_ON;
- } else {
- pr_info("switched off\n");
- i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
- i915_suspend_switcheroo(i915, pmm);
- i915->drm.switch_power_state = DRM_SWITCH_POWER_OFF;
- }
-}
-
-static bool i915_switcheroo_can_switch(struct pci_dev *pdev)
-{
- struct drm_i915_private *i915 = pdev_to_i915(pdev);
-
- /*
- * FIXME: open_count is protected by drm_global_mutex but that would lead to
- * locking inversion with the driver load path. And the access here is
- * completely racy anyway. So don't bother with locking for now.
- */
- return i915 && i915->drm.open_count == 0;
-}
-
-static const struct vga_switcheroo_client_ops i915_switcheroo_ops = {
- .set_gpu_state = i915_switcheroo_set_state,
- .reprobe = NULL,
- .can_switch = i915_switcheroo_can_switch,
-};
-
static int i915_driver_modeset_probe(struct drm_i915_private *i915)
{
- struct pci_dev *pdev = i915->drm.pdev;
int ret;
if (i915_inject_probe_failure(i915))
@@ -339,7 +292,7 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
intel_register_dsm_handler();
- ret = vga_switcheroo_register_client(pdev, &i915_switcheroo_ops, false);
+ ret = i915_switcheroo_register(i915);
if (ret)
goto cleanup_vga_client;
@@ -394,7 +347,7 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
cleanup_csr:
intel_csr_ucode_fini(i915);
intel_power_domains_driver_remove(i915);
- vga_switcheroo_unregister_client(pdev);
+ i915_switcheroo_unregister(i915);
cleanup_vga_client:
intel_vga_unregister(i915);
out:
@@ -403,13 +356,12 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
static void i915_driver_modeset_remove(struct drm_i915_private *i915)
{
- struct pci_dev *pdev = i915->drm.pdev;
-
intel_modeset_driver_remove(i915);
intel_bios_driver_remove(i915);
- vga_switcheroo_unregister_client(pdev);
+ i915_switcheroo_unregister(i915);
+
intel_vga_unregister(i915);
intel_csr_ucode_fini(i915);
@@ -1825,8 +1777,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation)
return ret;
}
-static int
-i915_suspend_switcheroo(struct drm_i915_private *i915, pm_message_t state)
+int i915_suspend_switcheroo(struct drm_i915_private *i915, pm_message_t state)
{
int error;
@@ -1994,7 +1945,7 @@ static int i915_drm_resume_early(struct drm_device *dev)
return ret;
}
-static int i915_resume_switcheroo(struct drm_i915_private *i915)
+int i915_resume_switcheroo(struct drm_i915_private *i915)
{
int ret;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 337d8306416a..0ca4d90dfa46 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2223,6 +2223,9 @@ extern const struct dev_pm_ops i915_pm_ops;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
+int i915_resume_switcheroo(struct drm_i915_private *i915);
+int i915_suspend_switcheroo(struct drm_i915_private *i915, pm_message_t state);
+
void intel_engine_init_hangcheck(struct intel_engine_cs *engine);
int vlv_force_gfx_clock(struct drm_i915_private *dev_priv, bool on);
diff --git a/drivers/gpu/drm/i915/i915_switcheroo.c b/drivers/gpu/drm/i915/i915_switcheroo.c
new file mode 100644
index 000000000000..39c79e1c5b52
--- /dev/null
+++ b/drivers/gpu/drm/i915/i915_switcheroo.c
@@ -0,0 +1,67 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2019 Intel Corporation
+ */
+
+#include <linux/vga_switcheroo.h>
+
+#include "i915_drv.h"
+#include "i915_switcheroo.h"
+
+static void i915_switcheroo_set_state(struct pci_dev *pdev,
+ enum vga_switcheroo_state state)
+{
+ struct drm_i915_private *i915 = pdev_to_i915(pdev);
+ pm_message_t pmm = { .event = PM_EVENT_SUSPEND };
+
+ if (!i915) {
+ dev_err(&pdev->dev, "DRM not initialized, aborting switch.\n");
+ return;
+ }
+
+ if (state == VGA_SWITCHEROO_ON) {
+ pr_info("switched on\n");
+ i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
+ /* i915 resume handler doesn't set to D0 */
+ pci_set_power_state(pdev, PCI_D0);
+ i915_resume_switcheroo(i915);
+ i915->drm.switch_power_state = DRM_SWITCH_POWER_ON;
+ } else {
+ pr_info("switched off\n");
+ i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
+ i915_suspend_switcheroo(i915, pmm);
+ i915->drm.switch_power_state = DRM_SWITCH_POWER_OFF;
+ }
+}
+
+static bool i915_switcheroo_can_switch(struct pci_dev *pdev)
+{
+ struct drm_i915_private *i915 = pdev_to_i915(pdev);
+
+ /*
+ * FIXME: open_count is protected by drm_global_mutex but that would lead to
+ * locking inversion with the driver load path. And the access here is
+ * completely racy anyway. So don't bother with locking for now.
+ */
+ return i915 && i915->drm.open_count == 0;
+}
+
+static const struct vga_switcheroo_client_ops i915_switcheroo_ops = {
+ .set_gpu_state = i915_switcheroo_set_state,
+ .reprobe = NULL,
+ .can_switch = i915_switcheroo_can_switch,
+};
+
+int i915_switcheroo_register(struct drm_i915_private *i915)
+{
+ struct pci_dev *pdev = i915->drm.pdev;
+
+ return vga_switcheroo_register_client(pdev, &i915_switcheroo_ops, false);
+}
+
+void i915_switcheroo_unregister(struct drm_i915_private *i915)
+{
+ struct pci_dev *pdev = i915->drm.pdev;
+
+ vga_switcheroo_unregister_client(pdev);
+}
diff --git a/drivers/gpu/drm/i915/i915_switcheroo.h b/drivers/gpu/drm/i915/i915_switcheroo.h
new file mode 100644
index 000000000000..59b6c1e07d75
--- /dev/null
+++ b/drivers/gpu/drm/i915/i915_switcheroo.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2019 Intel Corporation
+ */
+
+#ifndef __I915_SWITCHEROO__
+#define __I915_SWITCHEROO__
+
+struct drm_i915_private;
+
+int i915_switcheroo_register(struct drm_i915_private *i915);
+void i915_switcheroo_unregister(struct drm_i915_private *i915);
+
+#endif /* __I915_SWITCHEROO__ */
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c
2019-10-02 13:17 ` [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c Jani Nikula
@ 2019-10-02 15:04 ` Ville Syrjälä
0 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjälä @ 2019-10-02 15:04 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Oct 02, 2019 at 04:17:58PM +0300, Jani Nikula wrote:
> Split out code related to vga switcheroo register/unregister and state
> handling from i915_drv.c into new i915_switcheroo.[ch] files.
>
> It's a bit difficult to draw the line how much to move to the new file
> from i915_drv.c, but it seemed to me keeping i915_suspend_switcheroo()
> and i915_resume_switcheroo() in place was the cleanest.
>
> No functional changes.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/i915_drv.c | 63 +++---------------------
> drivers/gpu/drm/i915/i915_drv.h | 3 ++
> drivers/gpu/drm/i915/i915_switcheroo.c | 67 ++++++++++++++++++++++++++
> drivers/gpu/drm/i915/i915_switcheroo.h | 14 ++++++
> 5 files changed, 92 insertions(+), 56 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/i915_switcheroo.c
> create mode 100644 drivers/gpu/drm/i915/i915_switcheroo.h
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index d2b53b5add81..136a1a51b6e2 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -46,6 +46,7 @@ i915-y += i915_drv.o \
> i915_pci.o \
> i915_scatterlist.o \
> i915_suspend.o \
> + i915_switcheroo.o \
> i915_sysfs.o \
> i915_utils.o \
> intel_csr.o \
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 3306c6bb515a..7349fd8c9796 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -72,6 +72,7 @@
> #include "i915_perf.h"
> #include "i915_query.h"
> #include "i915_suspend.h"
> +#include "i915_switcheroo.h"
> #include "i915_sysfs.h"
> #include "i915_trace.h"
> #include "i915_vgpu.h"
> @@ -269,56 +270,8 @@ intel_teardown_mchbar(struct drm_i915_private *dev_priv)
> release_resource(&dev_priv->mch_res);
> }
>
> -static int i915_resume_switcheroo(struct drm_i915_private *i915);
> -static int i915_suspend_switcheroo(struct drm_i915_private *i915,
> - pm_message_t state);
> -
> -static void i915_switcheroo_set_state(struct pci_dev *pdev, enum vga_switcheroo_state state)
> -{
> - struct drm_i915_private *i915 = pdev_to_i915(pdev);
> - pm_message_t pmm = { .event = PM_EVENT_SUSPEND };
> -
> - if (!i915) {
> - dev_err(&pdev->dev, "DRM not initialized, aborting switch.\n");
> - return;
> - }
> -
> - if (state == VGA_SWITCHEROO_ON) {
> - pr_info("switched on\n");
> - i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
> - /* i915 resume handler doesn't set to D0 */
> - pci_set_power_state(pdev, PCI_D0);
> - i915_resume_switcheroo(i915);
> - i915->drm.switch_power_state = DRM_SWITCH_POWER_ON;
> - } else {
> - pr_info("switched off\n");
> - i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
> - i915_suspend_switcheroo(i915, pmm);
> - i915->drm.switch_power_state = DRM_SWITCH_POWER_OFF;
> - }
> -}
> -
> -static bool i915_switcheroo_can_switch(struct pci_dev *pdev)
> -{
> - struct drm_i915_private *i915 = pdev_to_i915(pdev);
> -
> - /*
> - * FIXME: open_count is protected by drm_global_mutex but that would lead to
> - * locking inversion with the driver load path. And the access here is
> - * completely racy anyway. So don't bother with locking for now.
> - */
> - return i915 && i915->drm.open_count == 0;
> -}
> -
> -static const struct vga_switcheroo_client_ops i915_switcheroo_ops = {
> - .set_gpu_state = i915_switcheroo_set_state,
> - .reprobe = NULL,
> - .can_switch = i915_switcheroo_can_switch,
> -};
> -
> static int i915_driver_modeset_probe(struct drm_i915_private *i915)
> {
> - struct pci_dev *pdev = i915->drm.pdev;
> int ret;
>
> if (i915_inject_probe_failure(i915))
> @@ -339,7 +292,7 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
>
> intel_register_dsm_handler();
>
> - ret = vga_switcheroo_register_client(pdev, &i915_switcheroo_ops, false);
> + ret = i915_switcheroo_register(i915);
> if (ret)
> goto cleanup_vga_client;
>
> @@ -394,7 +347,7 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
> cleanup_csr:
> intel_csr_ucode_fini(i915);
> intel_power_domains_driver_remove(i915);
> - vga_switcheroo_unregister_client(pdev);
> + i915_switcheroo_unregister(i915);
> cleanup_vga_client:
> intel_vga_unregister(i915);
> out:
> @@ -403,13 +356,12 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
>
> static void i915_driver_modeset_remove(struct drm_i915_private *i915)
> {
> - struct pci_dev *pdev = i915->drm.pdev;
> -
> intel_modeset_driver_remove(i915);
>
> intel_bios_driver_remove(i915);
>
> - vga_switcheroo_unregister_client(pdev);
> + i915_switcheroo_unregister(i915);
> +
> intel_vga_unregister(i915);
>
> intel_csr_ucode_fini(i915);
> @@ -1825,8 +1777,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation)
> return ret;
> }
>
> -static int
> -i915_suspend_switcheroo(struct drm_i915_private *i915, pm_message_t state)
> +int i915_suspend_switcheroo(struct drm_i915_private *i915, pm_message_t state)
> {
> int error;
>
> @@ -1994,7 +1945,7 @@ static int i915_drm_resume_early(struct drm_device *dev)
> return ret;
> }
>
> -static int i915_resume_switcheroo(struct drm_i915_private *i915)
> +int i915_resume_switcheroo(struct drm_i915_private *i915)
> {
> int ret;
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 337d8306416a..0ca4d90dfa46 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2223,6 +2223,9 @@ extern const struct dev_pm_ops i915_pm_ops;
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
>
> +int i915_resume_switcheroo(struct drm_i915_private *i915);
> +int i915_suspend_switcheroo(struct drm_i915_private *i915, pm_message_t state);
> +
> void intel_engine_init_hangcheck(struct intel_engine_cs *engine);
> int vlv_force_gfx_clock(struct drm_i915_private *dev_priv, bool on);
>
> diff --git a/drivers/gpu/drm/i915/i915_switcheroo.c b/drivers/gpu/drm/i915/i915_switcheroo.c
> new file mode 100644
> index 000000000000..39c79e1c5b52
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/i915_switcheroo.c
> @@ -0,0 +1,67 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2019 Intel Corporation
> + */
> +
> +#include <linux/vga_switcheroo.h>
> +
> +#include "i915_drv.h"
> +#include "i915_switcheroo.h"
> +
> +static void i915_switcheroo_set_state(struct pci_dev *pdev,
> + enum vga_switcheroo_state state)
> +{
> + struct drm_i915_private *i915 = pdev_to_i915(pdev);
> + pm_message_t pmm = { .event = PM_EVENT_SUSPEND };
> +
> + if (!i915) {
> + dev_err(&pdev->dev, "DRM not initialized, aborting switch.\n");
> + return;
> + }
Is that dead code?
Patch is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> +
> + if (state == VGA_SWITCHEROO_ON) {
> + pr_info("switched on\n");
> + i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
> + /* i915 resume handler doesn't set to D0 */
> + pci_set_power_state(pdev, PCI_D0);
> + i915_resume_switcheroo(i915);
> + i915->drm.switch_power_state = DRM_SWITCH_POWER_ON;
> + } else {
> + pr_info("switched off\n");
> + i915->drm.switch_power_state = DRM_SWITCH_POWER_CHANGING;
> + i915_suspend_switcheroo(i915, pmm);
> + i915->drm.switch_power_state = DRM_SWITCH_POWER_OFF;
> + }
> +}
> +
> +static bool i915_switcheroo_can_switch(struct pci_dev *pdev)
> +{
> + struct drm_i915_private *i915 = pdev_to_i915(pdev);
> +
> + /*
> + * FIXME: open_count is protected by drm_global_mutex but that would lead to
> + * locking inversion with the driver load path. And the access here is
> + * completely racy anyway. So don't bother with locking for now.
> + */
> + return i915 && i915->drm.open_count == 0;
> +}
> +
> +static const struct vga_switcheroo_client_ops i915_switcheroo_ops = {
> + .set_gpu_state = i915_switcheroo_set_state,
> + .reprobe = NULL,
> + .can_switch = i915_switcheroo_can_switch,
> +};
> +
> +int i915_switcheroo_register(struct drm_i915_private *i915)
> +{
> + struct pci_dev *pdev = i915->drm.pdev;
> +
> + return vga_switcheroo_register_client(pdev, &i915_switcheroo_ops, false);
> +}
> +
> +void i915_switcheroo_unregister(struct drm_i915_private *i915)
> +{
> + struct pci_dev *pdev = i915->drm.pdev;
> +
> + vga_switcheroo_unregister_client(pdev);
> +}
> diff --git a/drivers/gpu/drm/i915/i915_switcheroo.h b/drivers/gpu/drm/i915/i915_switcheroo.h
> new file mode 100644
> index 000000000000..59b6c1e07d75
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/i915_switcheroo.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2019 Intel Corporation
> + */
> +
> +#ifndef __I915_SWITCHEROO__
> +#define __I915_SWITCHEROO__
> +
> +struct drm_i915_private;
> +
> +int i915_switcheroo_register(struct drm_i915_private *i915);
> +void i915_switcheroo_unregister(struct drm_i915_private *i915);
> +
> +#endif /* __I915_SWITCHEROO__ */
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/4] drm/i915: register vga switcheroo later, unregister earlier
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
2019-10-02 13:17 ` [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c Jani Nikula
@ 2019-10-02 13:17 ` Jani Nikula
2019-10-02 13:18 ` [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init() Jani Nikula
` (6 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2019-10-02 13:17 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Move vga switcheroo and dsm handler register later in
i915_driver_register(), and unregister in i915_driver_unregister(). The
dsm handler unregister is a nop, and is only added for completeness.
My unsubstantiated suspicion is that the vga switcheroo state change
would not work as early as we register the hooks currently. In any case
exposing the interfaces to the world only after we've got everything set
up seems prudent.
Also replace the error handling in vga switcheroo register with a simple
error message. This is done at the same time due to lack of error
propagation from i915_driver_register().
Cc: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 7349fd8c9796..7503e16aadef 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -290,12 +290,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
if (ret)
goto out;
- intel_register_dsm_handler();
-
- ret = i915_switcheroo_register(i915);
- if (ret)
- goto cleanup_vga_client;
-
/* must happen before intel_power_domains_init_hw() on VLV/CHV */
intel_update_rawclk(i915);
@@ -347,8 +341,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
cleanup_csr:
intel_csr_ucode_fini(i915);
intel_power_domains_driver_remove(i915);
- i915_switcheroo_unregister(i915);
-cleanup_vga_client:
intel_vga_unregister(i915);
out:
return ret;
@@ -360,8 +352,6 @@ static void i915_driver_modeset_remove(struct drm_i915_private *i915)
intel_bios_driver_remove(i915);
- i915_switcheroo_unregister(i915);
-
intel_vga_unregister(i915);
intel_csr_ucode_fini(i915);
@@ -1348,6 +1338,11 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
intel_power_domains_enable(dev_priv);
intel_runtime_pm_enable(&dev_priv->runtime_pm);
+
+ intel_register_dsm_handler();
+
+ if (i915_switcheroo_register(dev_priv))
+ DRM_ERROR("Failed to register vga switcheroo!\n");
}
/**
@@ -1356,6 +1351,10 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
*/
static void i915_driver_unregister(struct drm_i915_private *dev_priv)
{
+ i915_switcheroo_unregister(dev_priv);
+
+ intel_unregister_dsm_handler();
+
intel_runtime_pm_disable(&dev_priv->runtime_pm);
intel_power_domains_disable(dev_priv);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init()
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
2019-10-02 13:17 ` [PATCH 2/4] drm/i915: split out i915_switcheroo.[ch] from i915_drv.c Jani Nikula
2019-10-02 13:17 ` [PATCH 3/4] drm/i915: register vga switcheroo later, unregister earlier Jani Nikula
@ 2019-10-02 13:18 ` Jani Nikula
2019-10-02 15:07 ` Ville Syrjälä
2019-10-02 15:03 ` [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Ville Syrjälä
` (5 subsequent siblings)
8 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2019-10-02 13:18 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Pair the gmbus setup and teardown in the same layer. This also fixes the
double gmbus teardown on the i915_driver_modeset_probe() error path.
Move the gmbus setup a bit later in the sequence to make the follow-up
refactoring easier, and to pinpoint any unexpected consequences of this
change right here, instead of the later refactoring.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 ++
drivers/gpu/drm/i915/i915_drv.c | 4 ----
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d99c59e97568..2a7554e3b96d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -16233,6 +16233,8 @@ int intel_modeset_init(struct drm_i915_private *i915)
intel_panel_sanitize_ssc(i915);
+ intel_gmbus_setup(i915);
+
DRM_DEBUG_KMS("%d display pipe%s available.\n",
INTEL_NUM_PIPES(i915),
INTEL_NUM_PIPES(i915) > 1 ? "s" : "");
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 7503e16aadef..91362682f489 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -53,7 +53,6 @@
#include "display/intel_display_types.h"
#include "display/intel_dp.h"
#include "display/intel_fbdev.h"
-#include "display/intel_gmbus.h"
#include "display/intel_hotplug.h"
#include "display/intel_overlay.h"
#include "display/intel_pipe_crc.h"
@@ -301,8 +300,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
if (ret)
goto cleanup_csr;
- intel_gmbus_setup(i915);
-
/* Important: The output setup functions called by modeset_init need
* working irqs for e.g. gmbus and dp aux transfers. */
ret = intel_modeset_init(i915);
@@ -337,7 +334,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
intel_modeset_driver_remove(i915);
cleanup_irq:
intel_irq_uninstall(i915);
- intel_gmbus_teardown(i915);
cleanup_csr:
intel_csr_ucode_fini(i915);
intel_power_domains_driver_remove(i915);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init()
2019-10-02 13:18 ` [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init() Jani Nikula
@ 2019-10-02 15:07 ` Ville Syrjälä
0 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjälä @ 2019-10-02 15:07 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Oct 02, 2019 at 04:18:00PM +0300, Jani Nikula wrote:
> Pair the gmbus setup and teardown in the same layer. This also fixes the
> double gmbus teardown on the i915_driver_modeset_probe() error path.
>
> Move the gmbus setup a bit later in the sequence to make the follow-up
> refactoring easier, and to pinpoint any unexpected consequences of this
> change right here, instead of the later refactoring.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Seems safe.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 ++
> drivers/gpu/drm/i915/i915_drv.c | 4 ----
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index d99c59e97568..2a7554e3b96d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -16233,6 +16233,8 @@ int intel_modeset_init(struct drm_i915_private *i915)
>
> intel_panel_sanitize_ssc(i915);
>
> + intel_gmbus_setup(i915);
> +
> DRM_DEBUG_KMS("%d display pipe%s available.\n",
> INTEL_NUM_PIPES(i915),
> INTEL_NUM_PIPES(i915) > 1 ? "s" : "");
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 7503e16aadef..91362682f489 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -53,7 +53,6 @@
> #include "display/intel_display_types.h"
> #include "display/intel_dp.h"
> #include "display/intel_fbdev.h"
> -#include "display/intel_gmbus.h"
> #include "display/intel_hotplug.h"
> #include "display/intel_overlay.h"
> #include "display/intel_pipe_crc.h"
> @@ -301,8 +300,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
> if (ret)
> goto cleanup_csr;
>
> - intel_gmbus_setup(i915);
> -
> /* Important: The output setup functions called by modeset_init need
> * working irqs for e.g. gmbus and dp aux transfers. */
> ret = intel_modeset_init(i915);
> @@ -337,7 +334,6 @@ static int i915_driver_modeset_probe(struct drm_i915_private *i915)
> intel_modeset_driver_remove(i915);
> cleanup_irq:
> intel_irq_uninstall(i915);
> - intel_gmbus_teardown(i915);
> cleanup_csr:
> intel_csr_ucode_fini(i915);
> intel_power_domains_driver_remove(i915);
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
` (2 preceding siblings ...)
2019-10-02 13:18 ` [PATCH 4/4] drm/i915: move gmbus setup down to intel_modeset_init() Jani Nikula
@ 2019-10-02 15:03 ` Ville Syrjälä
2019-10-02 17:28 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
` (4 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjälä @ 2019-10-02 15:03 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Oct 02, 2019 at 04:17:57PM +0300, Jani Nikula wrote:
> Rename the function per Ville's suggestion. No functional changes.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> drivers/gpu/drm/i915/display/intel_vga.c | 2 +-
> drivers/gpu/drm/i915/display/intel_vga.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index bb642a1a0dd4..0616284c6da6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -267,7 +267,7 @@ static void hsw_power_well_post_enable(struct drm_i915_private *dev_priv,
> u8 irq_pipe_mask, bool has_vga)
> {
> if (has_vga)
> - intel_vga_msr_write(dev_priv);
> + intel_vga_reset_io_mem(dev_priv);
>
> if (irq_pipe_mask)
> gen8_irq_power_well_post_enable(dev_priv, irq_pipe_mask);
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
> index 732568eaa988..2ff7293986d4 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.c
> +++ b/drivers/gpu/drm/i915/display/intel_vga.c
> @@ -72,7 +72,7 @@ void intel_vga_redisable(struct drm_i915_private *i915)
> intel_display_power_put(i915, POWER_DOMAIN_VGA, wakeref);
> }
>
> -void intel_vga_msr_write(struct drm_i915_private *i915)
> +void intel_vga_reset_io_mem(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = i915->drm.pdev;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vga.h b/drivers/gpu/drm/i915/display/intel_vga.h
> index 3517872e62ac..ba5b55b917f0 100644
> --- a/drivers/gpu/drm/i915/display/intel_vga.h
> +++ b/drivers/gpu/drm/i915/display/intel_vga.h
> @@ -8,7 +8,7 @@
>
> struct drm_i915_private;
>
> -void intel_vga_msr_write(struct drm_i915_private *i915);
> +void intel_vga_reset_io_mem(struct drm_i915_private *i915);
> void intel_vga_disable(struct drm_i915_private *i915);
> void intel_vga_redisable(struct drm_i915_private *i915);
> void intel_vga_redisable_power_on(struct drm_i915_private *i915);
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
` (3 preceding siblings ...)
2019-10-02 15:03 ` [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Ville Syrjälä
@ 2019-10-02 17:28 ` Patchwork
2019-10-02 17:54 ` ✗ Fi.CI.BAT: failure " Patchwork
` (3 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-10-02 17:28 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
URL : https://patchwork.freedesktop.org/series/67493/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2436f7c1a72f drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
30cdaaada4aa drm/i915: split out i915_switcheroo.[ch] from i915_drv.c
-:172: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#172:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 208 lines checked
fedff7eacb4d drm/i915: register vga switcheroo later, unregister earlier
d0856bcc6ca3 drm/i915: move gmbus setup down to intel_modeset_init()
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
` (4 preceding siblings ...)
2019-10-02 17:28 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
@ 2019-10-02 17:54 ` Patchwork
2019-10-03 10:23 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2) Patchwork
` (2 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-10-02 17:54 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
URL : https://patchwork.freedesktop.org/series/67493/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6991 -> Patchwork_14629
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14629 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14629, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14629:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-r: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-kbl-r/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-kbl-r/igt@gem_exec_suspend@basic-s3.html
Known issues
------------
Here are the changes found in Patchwork_14629 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-copy:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-icl-u3/igt@gem_mmap_gtt@basic-copy.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [PASS][5] -> [INCOMPLETE][6] ([fdo#107807])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: [PASS][7] -> [INCOMPLETE][8] ([fdo#107718])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-small-bo-tiledx:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledx.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledx.html
* igt@i915_selftest@live_requests:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111867]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-tgl-u/igt@i915_selftest@live_requests.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-tgl-u/igt@i915_selftest@live_requests.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][13] ([fdo#109635 ]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u2: [FAIL][15] ([fdo#109483]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][17] ([fdo#111045] / [fdo#111096]) -> [FAIL][18] ([fdo#111407])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6991/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
Participating hosts (51 -> 46)
------------------------------
Additional (1): fi-kbl-soraka
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6991 -> Patchwork_14629
CI-20190529: 20190529
CI_DRM_6991: 1f02b477cc08d4560a0c2cf6cc98340e09c7c734 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5209: ec639c89860b859fdf4b038c2fa8ad593bd6909e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14629: d0856bcc6ca3260655548a1c6847c42d2f38962e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d0856bcc6ca3 drm/i915: move gmbus setup down to intel_modeset_init()
fedff7eacb4d drm/i915: register vga switcheroo later, unregister earlier
30cdaaada4aa drm/i915: split out i915_switcheroo.[ch] from i915_drv.c
2436f7c1a72f drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14629/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2)
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
` (5 preceding siblings ...)
2019-10-02 17:54 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-10-03 10:23 ` Patchwork
2019-10-03 10:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-03 17:34 ` ✗ Fi.CI.IGT: failure " Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-10-03 10:23 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2)
URL : https://patchwork.freedesktop.org/series/67493/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6bc8182b67d0 drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
936fbdecf402 drm/i915: split out i915_switcheroo.[ch] from i915_drv.c
-:172: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#172:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 208 lines checked
e1298462d5b4 drm/i915: register vga switcheroo later, unregister earlier
e17be0791474 drm/i915: move gmbus setup down to intel_modeset_init()
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2)
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
` (6 preceding siblings ...)
2019-10-03 10:23 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2) Patchwork
@ 2019-10-03 10:48 ` Patchwork
2019-10-03 17:34 ` ✗ Fi.CI.IGT: failure " Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-10-03 10:48 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2)
URL : https://patchwork.freedesktop.org/series/67493/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6996 -> Patchwork_14643
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/index.html
Known issues
------------
Here are the changes found in Patchwork_14643 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@bad-flink:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/fi-icl-u3/igt@gem_flink_basic@bad-flink.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/fi-icl-u3/igt@gem_flink_basic@bad-flink.html
#### Possible fixes ####
* igt@gem_flink_basic@double-flink:
- fi-icl-u3: [DMESG-WARN][3] ([fdo#107724]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/fi-icl-u3/igt@gem_flink_basic@double-flink.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/fi-icl-u3/igt@gem_flink_basic@double-flink.html
* igt@i915_selftest@live_hangcheck:
- fi-cfl-8109u: [INCOMPLETE][5] ([fdo#106070]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/fi-cfl-8109u/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/fi-cfl-8109u/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][7] ([fdo#109483]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][9] ([fdo#110595]) -> [DMESG-WARN][10] ([fdo#110595] / [fdo#111214])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/fi-icl-u2/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/fi-icl-u2/igt@i915_module_load@reload.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111407]) -> [FAIL][12] ([fdo#111045] / [fdo#111096])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#110595]: https://bugs.freedesktop.org/show_bug.cgi?id=110595
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
Participating hosts (52 -> 43)
------------------------------
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6996 -> Patchwork_14643
CI-20190529: 20190529
CI_DRM_6996: 98596d29a3cff9d996c42468eb606036faf42954 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5210: 74f55119f9920b65996535210a09147997804136 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14643: e17be07914742c9b5aa78154172d112bbb344137 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e17be0791474 drm/i915: move gmbus setup down to intel_modeset_init()
e1298462d5b4 drm/i915: register vga switcheroo later, unregister earlier
936fbdecf402 drm/i915: split out i915_switcheroo.[ch] from i915_drv.c
6bc8182b67d0 drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread* ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2)
2019-10-02 13:17 [PATCH 1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() Jani Nikula
` (7 preceding siblings ...)
2019-10-03 10:48 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-10-03 17:34 ` Patchwork
8 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2019-10-03 17:34 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/4] drm/i915/vga: rename intel_vga_msr_write() to intel_vga_reset_io_mem() (rev2)
URL : https://patchwork.freedesktop.org/series/67493/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6996_full -> Patchwork_14643_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14643_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14643_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14643_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_psr@sprite_render:
- shard-skl: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-skl5/igt@kms_psr@sprite_render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-skl7/igt@kms_psr@sprite_render.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_schedule@preempt-hang-vebox:
- {shard-tglb}: [PASS][3] -> [INCOMPLETE][4] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb5/igt@gem_exec_schedule@preempt-hang-vebox.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb7/igt@gem_exec_schedule@preempt-hang-vebox.html
Known issues
------------
Here are the changes found in Patchwork_14643_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110841])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb8/igt@gem_exec_async@concurrent-writes-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb2/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +17 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_userptr_blits@coherency-sync:
- shard-hsw: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-hsw6/igt@gem_userptr_blits@coherency-sync.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-hsw6/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@sync-unmap:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-glk9/igt@gem_userptr_blits@sync-unmap.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-glk6/igt@gem_userptr_blits@sync-unmap.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([fdo#109385] / [fdo#111870]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-apl3/igt@gem_userptr_blits@sync-unmap-cycles.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-apl4/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103167]) +7 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109642] / [fdo#111068])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb2/igt@kms_psr@psr2_suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb8/igt@kms_psr@psr2_suspend.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#99912])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-skl2/igt@kms_setmode@basic.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-skl4/igt@kms_setmode@basic.html
* igt@perf@polling:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#110728])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-skl5/igt@perf@polling.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-skl4/igt@perf@polling.html
* igt@perf_pmu@busy-no-semaphores-vecs0:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([fdo#111626])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-apl2/igt@perf_pmu@busy-no-semaphores-vecs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-apl3/igt@perf_pmu@busy-no-semaphores-vecs0.html
#### Possible fixes ####
* igt@gem_ctx_shared@q-smoketest-blt:
- {shard-tglb}: [INCOMPLETE][35] ([fdo#111735]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb6/igt@gem_ctx_shared@q-smoketest-blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb8/igt@gem_ctx_shared@q-smoketest-blt.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][37] ([fdo#111325]) -> [PASS][38] +5 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-iclb: [FAIL][39] -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb2/igt@gem_exec_suspend@basic-s3.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-apl: [DMESG-WARN][41] ([fdo#109385] / [fdo#111870]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-apl7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-apl7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-skl: [DMESG-WARN][43] ([fdo#111870]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-skl7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-skl9/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
- shard-hsw: [DMESG-WARN][45] ([fdo#111870]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-iclb: [DMESG-WARN][47] ([fdo#111870]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_userptr_blits@sync-unmap:
- shard-kbl: [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-kbl3/igt@gem_userptr_blits@sync-unmap.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-kbl4/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rpm@system-suspend:
- {shard-tglb}: [INCOMPLETE][51] ([fdo#111747]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb8/igt@i915_pm_rpm@system-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb6/igt@i915_pm_rpm@system-suspend.html
* igt@i915_suspend@debugfs-reader:
- {shard-tglb}: [INCOMPLETE][53] ([fdo#111867]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb3/igt@i915_suspend@debugfs-reader.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb6/igt@i915_suspend@debugfs-reader.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: [INCOMPLETE][55] ([fdo#103927]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-apl3/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-apl8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
* igt@kms_color@pipe-a-gamma:
- {shard-tglb}: [FAIL][57] ([fdo#104782]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb8/igt@kms_color@pipe-a-gamma.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb6/igt@kms_color@pipe-a-gamma.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-skl: [FAIL][59] ([fdo#103184] / [fdo#103232]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-skl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-skl5/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled.html
* igt@kms_flip@2x-flip-vs-suspend:
- shard-hsw: [INCOMPLETE][61] ([fdo#103540]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-hsw6/igt@kms_flip@2x-flip-vs-suspend.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-hsw6/igt@kms_flip@2x-flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +6 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_setmode@invalid-clone-exclusive-crtc:
- {shard-tglb}: [DMESG-WARN][69] ([fdo#111600]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb2/igt@kms_setmode@invalid-clone-exclusive-crtc.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb6/igt@kms_setmode@invalid-clone-exclusive-crtc.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][71] ([fdo#108566]) -> [PASS][72] +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- {shard-tglb}: [INCOMPLETE][73] ([fdo#111832]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-tglb4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-tglb5/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][75] ([fdo#109276]) -> [PASS][76] +10 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb5/igt@prime_busy@hang-bsd2.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb1/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][77] ([fdo#109276]) -> [FAIL][78] ([fdo#111329])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6996/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109385]: https://bugs.freedesktop.org/show_bug.cgi?id=109385
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111626]: https://bugs.freedesktop.org/show_bug.cgi?id=111626
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111867]: https://bugs.freedesktop.org/show_bug.cgi?id=111867
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6996 -> Patchwork_14643
CI-20190529: 20190529
CI_DRM_6996: 98596d29a3cff9d996c42468eb606036faf42954 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5210: 74f55119f9920b65996535210a09147997804136 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14643: e17be07914742c9b5aa78154172d112bbb344137 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14643/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread