From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC v3 5/9] drm/i915: Extract framebufer CCS offset checks into a function Date: Fri, 4 Oct 2019 18:10:29 +0300 Message-ID: <20191004151029.GF1208@intel.com> References: <20190923102935.5860-1-dhinakaran.pandiyan@intel.com> <20190923102935.5860-6-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A3BE6E30F for ; Fri, 4 Oct 2019 15:10:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190923102935.5860-6-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBTZXAgMjMsIDIwMTkgYXQgMDM6Mjk6MzFBTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBpbnRlbF9maWxsX2ZiX2luZm8oKSBoYXMgZ3Jvd24gcXVpdGUgbGFyZ2Ug YW5kIHdyYXBwaW5nIHRoZSBvZmZzZXQgY2hlY2tzCj4gaW50byBhIHNlcGFyYXRlIGZ1bmN0aW9u IG1ha2VzIHRoZSBsb29wIGEgYml0IGVhc2llciB0byBmb2xsb3cuCj4gCj4gQ2M6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1hdHQgUm9wZXIg PG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQ YW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jIHwgNjkgKysrKysrKysrKysrLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggNmZlYzQzY2RkZGY0Li43NDQ3MDAxYzFmODUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0yNjgyLDYgKzI2ODIsNDMgQEAg c3RhdGljIGJvb2wgaW50ZWxfcGxhbmVfbmVlZHNfcmVtYXAoY29uc3Qgc3RydWN0IGludGVsX3Bs YW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgCXJldHVybiBzdHJpZGUgPiBtYXhfc3RyaWRlOwo+ ICB9Cj4gIAo+ICtzdGF0aWMgaW50Cj4gK2ludGVsX2ZiX2NoZWNrX2Njc194eShzdHJ1Y3QgZHJt X2ZyYW1lYnVmZmVyICpmYiwgaW50IHgsIGludCB5KQoKZmIgY2FuIGJlIGNvbnN0Cgo+ICt7Cj4g KwlzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiID0gdG9faW50ZWxfZnJhbWVidWZm ZXIoZmIpOwo+ICsJaW50IGhzdWIgPSBmYi0+Zm9ybWF0LT5oc3ViOwo+ICsJaW50IHZzdWIgPSBm Yi0+Zm9ybWF0LT52c3ViOwo+ICsJaW50IHRpbGVfd2lkdGgsIHRpbGVfaGVpZ2h0Owo+ICsJaW50 IGNjc194LCBjY3NfeTsKPiArCWludCBtYWluX3gsIG1haW5feTsKPiArCj4gKwlpbnRlbF90aWxl X2RpbXMoZmIsIDEsICZ0aWxlX3dpZHRoLCAmdGlsZV9oZWlnaHQpOwo+ICsKPiArCXRpbGVfd2lk dGggKj0gaHN1YjsKPiArCXRpbGVfaGVpZ2h0ICo9IHZzdWI7Cj4gKwo+ICsJY2NzX3ggPSAoeCAq IGhzdWIpICUgdGlsZV93aWR0aDsKPiArCWNjc195ID0gKHkgKiB2c3ViKSAlIHRpbGVfaGVpZ2h0 Owo+ICsJbWFpbl94ID0gaW50ZWxfZmItPm5vcm1hbFswXS54ICUgdGlsZV93aWR0aDsKPiArCW1h aW5feSA9IGludGVsX2ZiLT5ub3JtYWxbMF0ueSAlIHRpbGVfaGVpZ2h0Owo+ICsKPiArCS8qCj4g KwkqIENDUyBkb2Vzbid0IGhhdmUgaXRzIG93biB4L3kgb2Zmc2V0IHJlZ2lzdGVyLCBzbyB0aGUg aW50cmEgQ0NTIHRpbGUKPiArCSogeC95IG9mZnNldHMgbXVzdCBtYXRjaCBiZXR3ZWVuIENDUyBh bmQgdGhlIG1haW4gc3VyZmFjZS4KPiArCSovCgpGb3JtYXR0aW5nIGZhaWwgd2l0aCB0aGUgY29t bWVudD8KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgoKPiArCWlmIChtYWluX3ggIT0gY2NzX3ggfHwgbWFpbl95ICE9IGNjc195KSB7 Cj4gKwkJRFJNX0RFQlVHX0tNUygiQmFkIENDUyB4L3kgKG1haW4gJWQsJWQgY2NzICVkLCVkKSBm dWxsIChtYWluICVkLCVkIGNjcyAlZCwlZClcbiIsCj4gKwkJCSAgICAgIG1haW5feCwgbWFpbl95 LAo+ICsJCQkgICAgICBjY3NfeCwgY2NzX3ksCj4gKwkJCSAgICAgIGludGVsX2ZiLT5ub3JtYWxb MF0ueCwKPiArCQkJICAgICAgaW50ZWxfZmItPm5vcm1hbFswXS55LAo+ICsJCQkgICAgICB4LCB5 KTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsK PiAgc3RhdGljIGludAo+ICBpbnRlbF9maWxsX2ZiX2luZm8oc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ICAJCSAgIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+IEBAIC0y NzEzLDM1ICsyNzUwLDkgQEAgaW50ZWxfZmlsbF9mYl9pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiAgCQl9Cj4gIAo+ICAJCWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1v ZGlmaWVyKSAmJiBpID09IDEpIHsKPiAtCQkJaW50IGhzdWIgPSBmYi0+Zm9ybWF0LT5oc3ViOwo+ IC0JCQlpbnQgdnN1YiA9IGZiLT5mb3JtYXQtPnZzdWI7Cj4gLQkJCWludCB0aWxlX3dpZHRoLCB0 aWxlX2hlaWdodDsKPiAtCQkJaW50IG1haW5feCwgbWFpbl95Owo+IC0JCQlpbnQgY2NzX3gsIGNj c195Owo+IC0KPiAtCQkJaW50ZWxfdGlsZV9kaW1zKGZiLCBpLCAmdGlsZV93aWR0aCwgJnRpbGVf aGVpZ2h0KTsKPiAtCj4gLQkJCXRpbGVfd2lkdGggKj0gaHN1YjsKPiAtCQkJdGlsZV9oZWlnaHQg Kj0gdnN1YjsKPiAtCj4gLQkJCWNjc194ID0gKHggKiBoc3ViKSAlIHRpbGVfd2lkdGg7Cj4gLQkJ CWNjc195ID0gKHkgKiB2c3ViKSAlIHRpbGVfaGVpZ2h0Owo+IC0JCQltYWluX3ggPSBpbnRlbF9m Yi0+bm9ybWFsWzBdLnggJSB0aWxlX3dpZHRoOwo+IC0JCQltYWluX3kgPSBpbnRlbF9mYi0+bm9y bWFsWzBdLnkgJSB0aWxlX2hlaWdodDsKPiAtCj4gLQkJCS8qCj4gLQkJCSAqIENDUyBkb2Vzbid0 IGhhdmUgaXRzIG93biB4L3kgb2Zmc2V0IHJlZ2lzdGVyLCBzbyB0aGUgaW50cmEgQ0NTIHRpbGUK PiAtCQkJICogeC95IG9mZnNldHMgbXVzdCBtYXRjaCBiZXR3ZWVuIENDUyBhbmQgdGhlIG1haW4g c3VyZmFjZS4KPiAtCQkJICovCj4gLQkJCWlmIChtYWluX3ggIT0gY2NzX3ggfHwgbWFpbl95ICE9 IGNjc195KSB7Cj4gLQkJCQlEUk1fREVCVUdfS01TKCJCYWQgQ0NTIHgveSAobWFpbiAlZCwlZCBj Y3MgJWQsJWQpIGZ1bGwgKG1haW4gJWQsJWQgY2NzICVkLCVkKVxuIiwKPiAtCQkJCQkgICAgICBt YWluX3gsIG1haW5feSwKPiAtCQkJCQkgICAgICBjY3NfeCwgY2NzX3ksCj4gLQkJCQkJICAgICAg aW50ZWxfZmItPm5vcm1hbFswXS54LAo+IC0JCQkJCSAgICAgIGludGVsX2ZiLT5ub3JtYWxbMF0u eSwKPiAtCQkJCQkgICAgICB4LCB5KTsKPiAtCQkJCXJldHVybiAtRUlOVkFMOwo+IC0JCQl9Cj4g KwkJCXJldCA9IGludGVsX2ZiX2NoZWNrX2Njc194eShmYiwgeCwgeSk7Cj4gKwkJCWlmIChyZXQp Cj4gKwkJCQlyZXR1cm4gcmV0Owo+ICAJCX0KPiAgCj4gIAkJLyoKPiAtLSAKPiAyLjE3LjEKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4